| Message ID | 20240703-am65-cpsw-multi-rx-v3-0-f11cd860fd72@kernel.org |
|---|---|
| Headers | show |
| Series | net: ethernet: ti: am65-cpsw: Add multi queue RX support | expand |
On Wed, Jul 03, 2024 at 04:51:36PM +0300, Roger Quadros wrote: > The Policer registers in the ALE register space are just shadow registers > and use an index field in the policer table control register to read/write > to the actual Polier registers. > Add helper functions to Read and Write to Policer registers. > > Also add a helper function to set the thread value to classifier/policer > mapping. Any packet that first matches the classifier will be sent to the > thread (flow) that is set in the classifier to thread mapping table. > If not set then it goes to the default flow. > > Default behaviour is to have 8 classifiers to map 8 DSCP/PCP > priorities to N receive threads (flows). N depends on number of > RX channels enabled for the port. > As per the standard [1] User prioritie 1 (Background) and 2 (Spare) have > lower priority than the user priority 0 (default). User priority 1 being > of the lowest priority. > > [1] IEEE802.1D-2004, IEEE Standard for Local and metropolitan area networks > Table G-2 - Traffic type acronyms > Table G-3 - Defining traffic types > > Signed-off-by: Roger Quadros <rogerq@kernel.org> > --- > Changelog: > v3: > - squashed 2 patches into 1 > - added comment explaining the default thread to priority mapping table > - typo fix "classifer"->"classifier" Thanks for the updates, Reviewed-by: Simon Horman <horms@kernel.org>
On 03/07/24 7:21 pm, Roger Quadros wrote: > Hi, > > am65-cpsw can support up to 8 queues at Rx. So far we have > been using only one queue (i.e. default flow) for all RX traffic. > > This series adds multi-queue support. The driver starts with > 1 RX queue by default. User can increase the RX queues via ethtool, > e.g. 'ethtool -L ethx rx <N>' > > The series also adds regmap and regfield support to some of the > ALE registers. It adds Policer/Classifier registers and fields. > > Converting the existing ALE control APIs to regfields can be a separate > exercise. > > Some helper functions are added to read/write to the Policer/Classifier > registers and a default Classifier setup function is added that > routes packets based on their PCP/DSCP priority to different RX queues. > > Signed-off-by: Roger Quadros <rogerq@kernel.org> > --- > Changes in v3: > - code style fixes > - squashed patches 5 and 6 > - added comment about priority to thread mapping table. > - Added Reviewed-by Simon Horman. > - Link to v2: https://lore.kernel.org/r/20240628-am65-cpsw-multi-rx-v2-0-c399cb77db56@kernel.org > > Changes in v2: > - rebase to net/next > - fixed RX stall issue during iperf > - Link to v1: https://lore.kernel.org/r/20240606-am65-cpsw-multi-rx-v1-0-0704b0cb6fdc@kernel.org > > --- > Roger Quadros (6): > net: ethernet: ti: am65-cpsw: Introduce multi queue Rx > net: ethernet: ti: cpsw_ale: use regfields for ALE registers > net: ethernet: ti: cpsw_ale: use regfields for number of Entries and Policers > net: ethernet: ti: cpsw_ale: add Policer and Thread control register fields > net: ethernet: ti: cpsw_ale: add policer/classifier helpers and setup defaults > net: ethernet: ti: am65-cpsw: setup priority to flow mapping > > drivers/net/ethernet/ti/am65-cpsw-ethtool.c | 62 +++-- > drivers/net/ethernet/ti/am65-cpsw-nuss.c | 370 ++++++++++++++++------------ > drivers/net/ethernet/ti/am65-cpsw-nuss.h | 36 +-- > drivers/net/ethernet/ti/cpsw_ale.c | 287 +++++++++++++++++++-- > drivers/net/ethernet/ti/cpsw_ale.h | 62 ++++- > 5 files changed, 609 insertions(+), 208 deletions(-) > --- > base-commit: 84562f9953ec5f91a4922baa2bd4f2d4f64fac31 > change-id: 20240606-am65-cpsw-multi-rx-fb6cf8dea5eb > > Best regards, For this series, Reviewed-by: MD Danish Anwar <danishanwar@ti.com>
Hi, am65-cpsw can support up to 8 queues at Rx. So far we have been using only one queue (i.e. default flow) for all RX traffic. This series adds multi-queue support. The driver starts with 1 RX queue by default. User can increase the RX queues via ethtool, e.g. 'ethtool -L ethx rx <N>' The series also adds regmap and regfield support to some of the ALE registers. It adds Policer/Classifier registers and fields. Converting the existing ALE control APIs to regfields can be a separate exercise. Some helper functions are added to read/write to the Policer/Classifier registers and a default Classifier setup function is added that routes packets based on their PCP/DSCP priority to different RX queues. Signed-off-by: Roger Quadros <rogerq@kernel.org> --- Changes in v3: - code style fixes - squashed patches 5 and 6 - added comment about priority to thread mapping table. - Added Reviewed-by Simon Horman. - Link to v2: https://lore.kernel.org/r/20240628-am65-cpsw-multi-rx-v2-0-c399cb77db56@kernel.org Changes in v2: - rebase to net/next - fixed RX stall issue during iperf - Link to v1: https://lore.kernel.org/r/20240606-am65-cpsw-multi-rx-v1-0-0704b0cb6fdc@kernel.org --- Roger Quadros (6): net: ethernet: ti: am65-cpsw: Introduce multi queue Rx net: ethernet: ti: cpsw_ale: use regfields for ALE registers net: ethernet: ti: cpsw_ale: use regfields for number of Entries and Policers net: ethernet: ti: cpsw_ale: add Policer and Thread control register fields net: ethernet: ti: cpsw_ale: add policer/classifier helpers and setup defaults net: ethernet: ti: am65-cpsw: setup priority to flow mapping drivers/net/ethernet/ti/am65-cpsw-ethtool.c | 62 +++-- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 370 ++++++++++++++++------------ drivers/net/ethernet/ti/am65-cpsw-nuss.h | 36 +-- drivers/net/ethernet/ti/cpsw_ale.c | 287 +++++++++++++++++++-- drivers/net/ethernet/ti/cpsw_ale.h | 62 ++++- 5 files changed, 609 insertions(+), 208 deletions(-) --- base-commit: 84562f9953ec5f91a4922baa2bd4f2d4f64fac31 change-id: 20240606-am65-cpsw-multi-rx-fb6cf8dea5eb Best regards,