| Message ID | 20240611-md-drivers-usb-serial-v1-1-c6ada535890a@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | USB: serial: add missing MODULE_DESCRIPTION() macros | expand |
On 6/11/2024 10:52 AM, Jeff Johnson wrote: > With ARCH=x86, make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/ch341.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/usb_debug.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/mxuport.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/navman.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/qcaux.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/usb-serial-simple.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/symbolserial.o > > Add the missing invocations of the MODULE_DESCRIPTION() macro. > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > --- > drivers/usb/serial/ch341.c | 1 + > drivers/usb/serial/mxuport.c | 1 + > drivers/usb/serial/navman.c | 1 + > drivers/usb/serial/qcaux.c | 1 + > drivers/usb/serial/symbolserial.c | 1 + > drivers/usb/serial/usb-serial-simple.c | 1 + > drivers/usb/serial/usb_debug.c | 1 + > 7 files changed, 7 insertions(+) Following up to see if anything else is needed from me. Hoping to see this in linux-next so I can remove it from my tracking spreadsheet :) /jeff
On Tue, Jun 11, 2024 at 10:52:54AM -0700, Jeff Johnson wrote: > With ARCH=x86, make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/ch341.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/usb_debug.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/mxuport.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/navman.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/qcaux.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/usb-serial-simple.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/symbolserial.o > > Add the missing invocations of the MODULE_DESCRIPTION() macro. > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> I amended the commit message with the (recent) commit that added this W=1 warning (and dropped C=1). I also tweaked three descriptions slightly. End result is here: https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-next&id=9f4dc05107a6db3743e6b9ea4014cbdc3795682d Thanks. Johan
On 7/5/2024 4:35 AM, Johan Hovold wrote: > On Tue, Jun 11, 2024 at 10:52:54AM -0700, Jeff Johnson wrote: >> With ARCH=x86, make allmodconfig && make W=1 C=1 reports: >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/ch341.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/usb_debug.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/mxuport.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/navman.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/qcaux.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/usb-serial-simple.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/symbolserial.o >> >> Add the missing invocations of the MODULE_DESCRIPTION() macro. >> >> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > > I amended the commit message with the (recent) commit that added this > W=1 warning (and dropped C=1). I also tweaked three descriptions > slightly. End result is here: > > https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-next&id=9f4dc05107a6db3743e6b9ea4014cbdc3795682d > > Thanks. > > Johan LGTM, thanks for the cleanup! /jeff
On 7/5/2024 4:35 AM, Johan Hovold wrote: > On Tue, Jun 11, 2024 at 10:52:54AM -0700, Jeff Johnson wrote: >> With ARCH=x86, make allmodconfig && make W=1 C=1 reports: >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/ch341.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/usb_debug.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/mxuport.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/navman.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/qcaux.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/usb-serial-simple.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/symbolserial.o >> >> Add the missing invocations of the MODULE_DESCRIPTION() macro. >> >> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > > I amended the commit message with the (recent) commit that added this > W=1 warning (and dropped C=1). I also tweaked three descriptions > slightly. End result is here: > > https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-next&id=9f4dc05107a6db3743e6b9ea4014cbdc3795682d Hi, I see this landed in linux-next, but is not currently in Linus' tree for 6.11. Will you be able to have this pulled during the merge window? I'm trying to eradicate all of these warnings before 6.11 rc-final. Thanks! /jeff
On Tue, Jul 23, 2024 at 11:44:05AM -0700, Jeff Johnson wrote: > On 7/5/2024 4:35 AM, Johan Hovold wrote: > > On Tue, Jun 11, 2024 at 10:52:54AM -0700, Jeff Johnson wrote: > >> With ARCH=x86, make allmodconfig && make W=1 C=1 reports: > >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/ch341.o > >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/usb_debug.o > >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/mxuport.o > >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/navman.o > >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/qcaux.o > >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/usb-serial-simple.o > >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/symbolserial.o > >> > >> Add the missing invocations of the MODULE_DESCRIPTION() macro. > >> > >> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > > > > I amended the commit message with the (recent) commit that added this > > W=1 warning (and dropped C=1). I also tweaked three descriptions > > slightly. End result is here: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-next&id=9f4dc05107a6db3743e6b9ea4014cbdc3795682d > I see this landed in linux-next, but is not currently in Linus' tree for 6.11. > Will you be able to have this pulled during the merge window? > I'm trying to eradicate all of these warnings before 6.11 rc-final. This one is now in Linus' tree. Johan
diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c index 612bea504d7a..060b3208494d 100644 --- a/drivers/usb/serial/ch341.c +++ b/drivers/usb/serial/ch341.c @@ -863,4 +863,5 @@ static struct usb_serial_driver * const serial_drivers[] = { module_usb_serial_driver(serial_drivers, id_table); +MODULE_DESCRIPTION("Winchiphead CH341 Single Port Serial Driver"); MODULE_LICENSE("GPL v2"); diff --git a/drivers/usb/serial/mxuport.c b/drivers/usb/serial/mxuport.c index 1f7bb3e4fcf2..9abb3fec35cd 100644 --- a/drivers/usb/serial/mxuport.c +++ b/drivers/usb/serial/mxuport.c @@ -1315,4 +1315,5 @@ module_usb_serial_driver(serial_drivers, mxuport_idtable); MODULE_AUTHOR("Andrew Lunn <andrew@lunn.ch>"); MODULE_AUTHOR("<support@moxa.com>"); +MODULE_DESCRIPTION("USB Moxa UPORT Serial Driver"); MODULE_LICENSE("GPL"); diff --git a/drivers/usb/serial/navman.c b/drivers/usb/serial/navman.c index 20277c52dded..a08ef41fd561 100644 --- a/drivers/usb/serial/navman.c +++ b/drivers/usb/serial/navman.c @@ -112,4 +112,5 @@ static struct usb_serial_driver * const serial_drivers[] = { module_usb_serial_driver(serial_drivers, id_table); +MODULE_DESCRIPTION("Navman Serial USB driver"); MODULE_LICENSE("GPL v2"); diff --git a/drivers/usb/serial/qcaux.c b/drivers/usb/serial/qcaux.c index 929ffba663f2..015bb7c5d19d 100644 --- a/drivers/usb/serial/qcaux.c +++ b/drivers/usb/serial/qcaux.c @@ -84,4 +84,5 @@ static struct usb_serial_driver * const serial_drivers[] = { }; module_usb_serial_driver(serial_drivers, id_table); +MODULE_DESCRIPTION("Qualcomm USB Auxiliary Serial Port driver"); MODULE_LICENSE("GPL v2"); diff --git a/drivers/usb/serial/symbolserial.c b/drivers/usb/serial/symbolserial.c index d7f73ad6e778..9aabb087f733 100644 --- a/drivers/usb/serial/symbolserial.c +++ b/drivers/usb/serial/symbolserial.c @@ -190,4 +190,5 @@ static struct usb_serial_driver * const serial_drivers[] = { module_usb_serial_driver(serial_drivers, id_table); +MODULE_DESCRIPTION("Symbol USB barcode to serial driver"); MODULE_LICENSE("GPL v2"); diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c index 24b8772a345e..82f4f0b992aa 100644 --- a/drivers/usb/serial/usb-serial-simple.c +++ b/drivers/usb/serial/usb-serial-simple.c @@ -163,4 +163,5 @@ static const struct usb_device_id id_table[] = { MODULE_DEVICE_TABLE(usb, id_table); module_usb_serial_driver(serial_drivers, id_table); +MODULE_DESCRIPTION("USB Serial 'Simple' driver"); MODULE_LICENSE("GPL v2"); diff --git a/drivers/usb/serial/usb_debug.c b/drivers/usb/serial/usb_debug.c index 6934970f180d..8188776b57d1 100644 --- a/drivers/usb/serial/usb_debug.c +++ b/drivers/usb/serial/usb_debug.c @@ -104,4 +104,5 @@ static struct usb_serial_driver * const serial_drivers[] = { }; module_usb_serial_driver(serial_drivers, id_table_combined); +MODULE_DESCRIPTION("USB Debug cable driver"); MODULE_LICENSE("GPL v2");
With ARCH=x86, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/ch341.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/usb_debug.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/mxuport.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/navman.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/qcaux.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/usb-serial-simple.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/symbolserial.o Add the missing invocations of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> --- drivers/usb/serial/ch341.c | 1 + drivers/usb/serial/mxuport.c | 1 + drivers/usb/serial/navman.c | 1 + drivers/usb/serial/qcaux.c | 1 + drivers/usb/serial/symbolserial.c | 1 + drivers/usb/serial/usb-serial-simple.c | 1 + drivers/usb/serial/usb_debug.c | 1 + 7 files changed, 7 insertions(+) --- base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670 change-id: 20240611-md-drivers-usb-serial-5c724873260e