Message ID | 20240722-md-powerpc-drivers-cpufreq-v2-1-bb84d715eb3d@quicinc.com |
---|---|
State | Superseded |
Headers | show |
Series | [v2] cpufreq: powerpc: add missing MODULE_DESCRIPTION() macros | expand |
Jeff Johnson <quic_jjohnson@quicinc.com> writes: > With ARCH=powerpc, make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cpufreq/ppc-cbe-cpufreq.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cpufreq/powernv-cpufreq.o > > Add the missing invocation of the MODULE_DESCRIPTION() macro to all > files which have a MODULE_LICENSE(). > > This includes three additional files which, although they did not > produce a warning with the powerpc allmodconfig configuration, may > cause this warning with specific options enabled in the kernel > configuration. > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > --- > Changes in v2: > - Per Michael Ellerman updated maple-cpufreq.c and powernv-cpufreq.c > descriptions > - Did not carry forward Viresh Kumar's Acked-by due to this change > - Link to v1: https://lore.kernel.org/r/20240614-md-powerpc-drivers-cpufreq-v1-1-de4034d87fd2@quicinc.com > --- > drivers/cpufreq/maple-cpufreq.c | 1 + > drivers/cpufreq/pasemi-cpufreq.c | 1 + > drivers/cpufreq/pmac64-cpufreq.c | 1 + > drivers/cpufreq/powernv-cpufreq.c | 1 + > drivers/cpufreq/ppc_cbe_cpufreq.c | 1 + > 5 files changed, 5 insertions(+) Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc) cheers
On 22-07-24, 10:14, Jeff Johnson wrote: > With ARCH=powerpc, make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cpufreq/ppc-cbe-cpufreq.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cpufreq/powernv-cpufreq.o > > Add the missing invocation of the MODULE_DESCRIPTION() macro to all > files which have a MODULE_LICENSE(). > > This includes three additional files which, although they did not > produce a warning with the powerpc allmodconfig configuration, may > cause this warning with specific options enabled in the kernel > configuration. > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > --- > Changes in v2: > - Per Michael Ellerman updated maple-cpufreq.c and powernv-cpufreq.c > descriptions > - Did not carry forward Viresh Kumar's Acked-by due to this change > - Link to v1: https://lore.kernel.org/r/20240614-md-powerpc-drivers-cpufreq-v1-1-de4034d87fd2@quicinc.com Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
On Wed, Jul 24, 2024 at 6:39 AM Viresh Kumar <viresh.kumar@linaro.org> wrote: > > On 22-07-24, 10:14, Jeff Johnson wrote: > > With ARCH=powerpc, make allmodconfig && make W=1 C=1 reports: > > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cpufreq/ppc-cbe-cpufreq.o > > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cpufreq/powernv-cpufreq.o > > > > Add the missing invocation of the MODULE_DESCRIPTION() macro to all > > files which have a MODULE_LICENSE(). > > > > This includes three additional files which, although they did not > > produce a warning with the powerpc allmodconfig configuration, may > > cause this warning with specific options enabled in the kernel > > configuration. > > > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > > --- > > Changes in v2: > > - Per Michael Ellerman updated maple-cpufreq.c and powernv-cpufreq.c > > descriptions > > - Did not carry forward Viresh Kumar's Acked-by due to this change > > - Link to v1: https://lore.kernel.org/r/20240614-md-powerpc-drivers-cpufreq-v1-1-de4034d87fd2@quicinc.com > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Applied as 6.12 material, thanks!
diff --git a/drivers/cpufreq/maple-cpufreq.c b/drivers/cpufreq/maple-cpufreq.c index f9306410a07f..690da85c4865 100644 --- a/drivers/cpufreq/maple-cpufreq.c +++ b/drivers/cpufreq/maple-cpufreq.c @@ -238,4 +238,5 @@ static int __init maple_cpufreq_init(void) module_init(maple_cpufreq_init); +MODULE_DESCRIPTION("cpufreq driver for Maple 970FX/970MP boards"); MODULE_LICENSE("GPL"); diff --git a/drivers/cpufreq/pasemi-cpufreq.c b/drivers/cpufreq/pasemi-cpufreq.c index ee925b53b6b9..5fc9cb480516 100644 --- a/drivers/cpufreq/pasemi-cpufreq.c +++ b/drivers/cpufreq/pasemi-cpufreq.c @@ -269,5 +269,6 @@ static void __exit pas_cpufreq_exit(void) module_init(pas_cpufreq_init); module_exit(pas_cpufreq_exit); +MODULE_DESCRIPTION("cpufreq driver for PA Semi PWRficient"); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Egor Martovetsky <egor@pasemi.com>, Olof Johansson <olof@lixom.net>"); diff --git a/drivers/cpufreq/pmac64-cpufreq.c b/drivers/cpufreq/pmac64-cpufreq.c index 2cd2b06849a2..9d3fe36075f8 100644 --- a/drivers/cpufreq/pmac64-cpufreq.c +++ b/drivers/cpufreq/pmac64-cpufreq.c @@ -671,4 +671,5 @@ static int __init g5_cpufreq_init(void) module_init(g5_cpufreq_init); +MODULE_DESCRIPTION("cpufreq driver for SMU & 970FX based G5 Macs"); MODULE_LICENSE("GPL"); diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c index 50c62929f7ca..bc55723b4d87 100644 --- a/drivers/cpufreq/powernv-cpufreq.c +++ b/drivers/cpufreq/powernv-cpufreq.c @@ -1160,5 +1160,6 @@ static void __exit powernv_cpufreq_exit(void) } module_exit(powernv_cpufreq_exit); +MODULE_DESCRIPTION("cpufreq driver for IBM/OpenPOWER powernv systems"); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Vaidyanathan Srinivasan <svaidy at linux.vnet.ibm.com>"); diff --git a/drivers/cpufreq/ppc_cbe_cpufreq.c b/drivers/cpufreq/ppc_cbe_cpufreq.c index 5ee4c7bfdcc5..98595b3ea13f 100644 --- a/drivers/cpufreq/ppc_cbe_cpufreq.c +++ b/drivers/cpufreq/ppc_cbe_cpufreq.c @@ -168,5 +168,6 @@ static void __exit cbe_cpufreq_exit(void) module_init(cbe_cpufreq_init); module_exit(cbe_cpufreq_exit); +MODULE_DESCRIPTION("cpufreq driver for Cell BE processors"); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Christian Krafft <krafft@de.ibm.com>");
With ARCH=powerpc, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cpufreq/ppc-cbe-cpufreq.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cpufreq/powernv-cpufreq.o Add the missing invocation of the MODULE_DESCRIPTION() macro to all files which have a MODULE_LICENSE(). This includes three additional files which, although they did not produce a warning with the powerpc allmodconfig configuration, may cause this warning with specific options enabled in the kernel configuration. Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> --- Changes in v2: - Per Michael Ellerman updated maple-cpufreq.c and powernv-cpufreq.c descriptions - Did not carry forward Viresh Kumar's Acked-by due to this change - Link to v1: https://lore.kernel.org/r/20240614-md-powerpc-drivers-cpufreq-v1-1-de4034d87fd2@quicinc.com --- drivers/cpufreq/maple-cpufreq.c | 1 + drivers/cpufreq/pasemi-cpufreq.c | 1 + drivers/cpufreq/pmac64-cpufreq.c | 1 + drivers/cpufreq/powernv-cpufreq.c | 1 + drivers/cpufreq/ppc_cbe_cpufreq.c | 1 + 5 files changed, 5 insertions(+) --- base-commit: 933069701c1b507825b514317d4edd5d3fd9d417 change-id: 20240614-md-powerpc-drivers-cpufreq-6d345e48164e