| Message ID | 20240808184048.63030-7-danila@jiaxyga.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add Nothing Phone (1) support | expand |
On 08/08/2024 20:40, Danila Tikhonov wrote: > The PN553 is another NFC chip from NXP, document the compatible in the > bindings. > > Signed-off-by: Danila Tikhonov <danila@jiaxyga.com> > --- > Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml b/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml > index 6924aff0b2c5..364b36151180 100644 > --- a/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml > +++ b/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml > @@ -17,6 +17,7 @@ properties: > - enum: > - nxp,nq310 > - nxp,pn547 > + - nxp,pn553 Keep the list ordered. Best regards, Krzysztof
On 8/9/24 08:39, Krzysztof Kozlowski wrote: > On 08/08/2024 20:40, Danila Tikhonov wrote: >> The PN553 is another NFC chip from NXP, document the compatible in the >> bindings. >> >> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com> >> --- >> Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml b/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml >> index 6924aff0b2c5..364b36151180 100644 >> --- a/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml >> +++ b/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml >> @@ -17,6 +17,7 @@ properties: >> - enum: >> - nxp,nq310 >> - nxp,pn547 >> + - nxp,pn553 > Keep the list ordered. > > Best regards, > Krzysztof > Thanks for your comment. Then I will fix it for nxp,pn547 too in this patch. Do you mind? --- Best wishes, Danila.
On Fri, Aug 09, 2024 at 07:39:53AM +0200, Krzysztof Kozlowski wrote: > On 08/08/2024 20:40, Danila Tikhonov wrote: > > The PN553 is another NFC chip from NXP, document the compatible in the > > bindings. > > > > Signed-off-by: Danila Tikhonov <danila@jiaxyga.com> > > --- > > Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml b/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml > > index 6924aff0b2c5..364b36151180 100644 > > --- a/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml > > +++ b/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml > > @@ -17,6 +17,7 @@ properties: > > - enum: > > - nxp,nq310 > > - nxp,pn547 > > + - nxp,pn553 > > Keep the list ordered. Looks ordered to me. n before p... Rob
On Thu, 08 Aug 2024 21:40:20 +0300, Danila Tikhonov wrote: > The PN553 is another NFC chip from NXP, document the compatible in the > bindings. > > Signed-off-by: Danila Tikhonov <danila@jiaxyga.com> > --- > Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring (Arm) <robh@kernel.org>
On 13/08/2024 21:33, Rob Herring wrote: > On Fri, Aug 09, 2024 at 07:39:53AM +0200, Krzysztof Kozlowski wrote: >> On 08/08/2024 20:40, Danila Tikhonov wrote: >>> The PN553 is another NFC chip from NXP, document the compatible in the >>> bindings. >>> >>> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com> >>> --- >>> Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml b/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml >>> index 6924aff0b2c5..364b36151180 100644 >>> --- a/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml >>> +++ b/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml >>> @@ -17,6 +17,7 @@ properties: >>> - enum: >>> - nxp,nq310 >>> - nxp,pn547 >>> + - nxp,pn553 >> >> Keep the list ordered. > > Looks ordered to me. n before p... Now it is... I think I misread 5->3. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml b/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml index 6924aff0b2c5..364b36151180 100644 --- a/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml +++ b/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml @@ -17,6 +17,7 @@ properties: - enum: - nxp,nq310 - nxp,pn547 + - nxp,pn553 - const: nxp,nxp-nci-i2c enable-gpios:
The PN553 is another NFC chip from NXP, document the compatible in the bindings. Signed-off-by: Danila Tikhonov <danila@jiaxyga.com> --- Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml | 1 + 1 file changed, 1 insertion(+)