| Message ID | 20240423141551.2410199-1-caleb.connolly@linaro.org |
|---|---|
| State | Accepted |
| Commit | ef1e322f3e1d9a221a1ee6109f6571429ee9fb4a |
| Headers | show |
| Series | [v2] usb: dwc3: support USB 3.1 controllers | expand |
Small ping, I think this patch slipped through the cracks. On 23/04/2024 16:15, Caleb Connolly wrote: > The revision is different for these, add the additional check as in > xhci-dwc3 core_init code. > > Equivalent upstream Linux patch: > 690fb3718a70 ("usb: dwc3: Support Synopsys USB 3.1 IP") > > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> > Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550 > Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> > Reviewed-by: Marek Vasut <marex@denx.de> > Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> > --- > Changes since v1: > * Reference Linux patch > * V1: https://lore.kernel.org/u-boot/20240411160527.835767-1-caleb.connolly@linaro.org > --- > drivers/usb/dwc3/core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index 96e850b7170f..db045f5822d4 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -594,9 +594,10 @@ static int dwc3_core_init(struct dwc3 *dwc) > int ret; > > reg = dwc3_readl(dwc->regs, DWC3_GSNPSID); > /* This should read as U3 followed by revision number */ > - if ((reg & DWC3_GSNPSID_MASK) != 0x55330000) { > + if ((reg & DWC3_GSNPSID_MASK) != 0x55330000 && > + (reg & DWC3_GSNPSID_MASK) != 0x33310000) { > dev_err(dwc->dev, "this is not a DesignWare USB3 DRD Core\n"); > ret = -ENODEV; > goto err0; > }
On 4/23/24 4:15 PM, Caleb Connolly wrote: > The revision is different for these, add the additional check as in > xhci-dwc3 core_init code. Reviewed-by: Marek Vasut <marex@denx.de> Thanks !
On dim., août 11, 2024 at 19:37, Marek Vasut <marex@denx.de> wrote: > On 4/23/24 4:15 PM, Caleb Connolly wrote: >> The revision is different for these, add the additional check as in >> xhci-dwc3 core_init code. > > Reviewed-by: Marek Vasut <marex@denx.de> > > Thanks ! Marek, should I pick this up through u-boot-dfu or will you pick it up?
On 8/13/24 2:26 PM, Mattijs Korpershoek wrote: > On dim., août 11, 2024 at 19:37, Marek Vasut <marex@denx.de> wrote: > >> On 4/23/24 4:15 PM, Caleb Connolly wrote: >>> The revision is different for these, add the additional check as in >>> xhci-dwc3 core_init code. >> >> Reviewed-by: Marek Vasut <marex@denx.de> >> >> Thanks ! > > Marek, should I pick this up through u-boot-dfu or will you pick it up? I think this is already in u-boot/master , isn't it ?
Hi Mattijs,
On Tue, Aug 13, 2024 at 9:26 AM Mattijs Korpershoek
<mkorpershoek@baylibre.com> wrote:
> Marek, should I pick this up through u-boot-dfu or will you pick it up?
This one is already in master:
https://gitlab.com/u-boot/u-boot/-/commit/ef1e322f3e1d9a221a1ee6109f6571429ee9fb4a
Hi, On mar., août 13, 2024 at 09:43, Fabio Estevam <festevam@gmail.com> wrote: > Hi Mattijs, > > On Tue, Aug 13, 2024 at 9:26 AM Mattijs Korpershoek > <mkorpershoek@baylibre.com> wrote: > >> Marek, should I pick this up through u-boot-dfu or will you pick it up? > > This one is already in master: > > https://gitlab.com/u-boot/u-boot/-/commit/ef1e322f3e1d9a221a1ee6109f6571429ee9fb4a I see. Since I did not see any "applied" message I assumed it was still pending. Sorry for the noise!
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 96e850b7170f..db045f5822d4 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -594,9 +594,10 @@ static int dwc3_core_init(struct dwc3 *dwc) int ret; reg = dwc3_readl(dwc->regs, DWC3_GSNPSID); /* This should read as U3 followed by revision number */ - if ((reg & DWC3_GSNPSID_MASK) != 0x55330000) { + if ((reg & DWC3_GSNPSID_MASK) != 0x55330000 && + (reg & DWC3_GSNPSID_MASK) != 0x33310000) { dev_err(dwc->dev, "this is not a DesignWare USB3 DRD Core\n"); ret = -ENODEV; goto err0; }
The revision is different for these, add the additional check as in xhci-dwc3 core_init code. Equivalent upstream Linux patch: 690fb3718a70 ("usb: dwc3: Support Synopsys USB 3.1 IP") Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550 Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> Reviewed-by: Marek Vasut <marex@denx.de> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> --- Changes since v1: * Reference Linux patch * V1: https://lore.kernel.org/u-boot/20240411160527.835767-1-caleb.connolly@linaro.org --- drivers/usb/dwc3/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)