| Message ID | 20240812-dbus-v5-0-ead288509217@linaro.org |
|---|---|
| Headers | show |
| Series | dbus: add GLib-based D-Bus daemon and command-line client | expand |
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> On Mon, 12 Aug 2024 10:22:21 +0200, Bartosz Golaszewski wrote: > I'm resending it once more but with commits squashed into how they'll appear > in git once applied upstream. I think the code is in good enough shape that > it can now go into the master branch and any further development can happen > from there. > > Big thanks to Philip Withnall <philip@tecnocode.co.uk> for his thorough review > of this series. I think I addressed most of the issues pointed out. > > [...] Applied, thanks! [1/4] tests: split out reusable test code into a local static library commit: e60e38375c7a5b9a0bae99b27e9c5b4d9fe21f27 [2/4] tests: split out the common test code for bash scripts commit: ad325c0b650b2ff543ec1edb8f802cfb54a0d6e3 [3/4] bindings: add GLib bindings commit: e090088c21b7e52f2f407dddd8d6f113182660d0 [4/4] dbus: add the D-Bus daemon, command-line client and tests commit: a5ab76da1e0a7475c42336829c611f438bffd584 Best regards,
I'm resending it once more but with commits squashed into how they'll appear in git once applied upstream. I think the code is in good enough shape that it can now go into the master branch and any further development can happen from there. Big thanks to Philip Withnall <philip@tecnocode.co.uk> for his thorough review of this series. I think I addressed most of the issues pointed out. This series introduces the D-Bus API definition and its implementation in the form of a GPIO manager daemon and a companion command-line client as well as GLib bindings to libgpiod which form the base on which the former are built. While I split the GLib and D-Bus code into several commits for easier review, I intend to apply all changes to bindings/glib/ and dbus/ as two big commits in the end as otherwise the split commits are not buildable until all of them are applied. The main point of interest is the D-Bus interface definition XML at dbus/lib/io.gpiod1.xml as it is what defines the actual D-Bus API. Everything else can be considered as implementation details as it's easier to change later than the API that's supposed to be stable once released. The first two patches expose the test infrastructure we use for the core library and tools to the GLib bindings and dbus code. Next we add the GLib bindings themselves. Not much to discuss here, they cover the entire libgpiod API but wrap it in GObject abstractions and plug into the GLib event loop. Finally we add the D-Bus code that's split into the daemon and command-line client. I added some examples to the README and documented the behavior in the help text of the programs as well as documented the interface file with XML comments that gdbus-codegen can parse and use to generate docbook output. For D-Bus, most of the testing happens in the command-line client bash tests. It has a very good coverage of the daemon's code and also allows to run the daemon through valgrind and verify there are no memory leaks and invalid accesses. Changes in v5: - squash GLib bindings and D-Bus commits into two big commits - Link to v4: https://lore.kernel.org/r/20240807-dbus-v4-0-64ea80169e51@linaro.org Changes in v4: - fix generating GObject introspection data - use GLib doc blocks with introspection annotations suitable for generating docs with gi-docgen - various comment and doc tweaks - Link to v3: https://lore.kernel.org/r/20240718-dbus-v3-0-c9ea2604f082@linaro.org Changes in v3: - make gpio-manager run as its own user in the systemd service file and add udev rules that automate the group assignment for gpiochips - add sandboxing options to the service file for an overall exposure score from systemd-analyze of 2.3 - enable introspection for GLib bindings - set the minimum required GLib version for gdbus-codegen - fix time units in dbus docs - change the D-Bus type for Chip's path to byte-array - change the naming convention in strings: s/DBus/D-Bus/g - add the "unknown" value to the EventClock property and document how to interpret other unrecognized values - various doc updates - don't set environment variables from the daemon code, use the provided g_log_writer_default_set_debug_domains() helper - use g_build_filename() where appropriate - use g_steal_pointer() to improve error propagation - use G_PARAM_STATIC_STRINGS across all properties - use G_GNUC_PRINTF() in g_gpiod_set_error_from_errno() - change the library's namespace to Gpiodglib/GPIODGLIB/gpiodglib_ - remove the "handle" properties in favor of passing the core libgpiod pointers to GObjects directly after they're constructed - add typedefs to property enums for better build-time safety - don't use g_value_set_static_string() for strings that are not really static across the entire lifetime of the program - rework the code for internal property setting and getting - add Requires.private: libgpiod to gpiod-glib pkgconfig file - Link to v2: https://lore.kernel.org/r/20240628-dbus-v2-0-c1331ac17cb8@linaro.org Changes in v2: - fixed most segfaults I noticed (or was made aware of by others) in RFC - improve the code in GLib examples - make command-line tests pass shellckeck - fix build issue resulting in implicit pointer-to-int casting on some platforms - many small tweaks, fixes and improvements all over the place but without changing the API - fix a bunch of memory leaks reported by valgrind - Link to v1: https://lore.kernel.org/linux-gpio/20240412122804.109323-1-brgl@bgdev.pl/ --- Bartosz Golaszewski (4): tests: split out reusable test code into a local static library tests: split out the common test code for bash scripts bindings: add GLib bindings dbus: add the D-Bus daemon, command-line client and tests .gitignore | 2 + Makefile.am | 7 + README | 73 +- TODO | 17 - bindings/Makefile.am | 7 + bindings/glib/.gitignore | 6 + bindings/glib/Makefile.am | 131 ++ bindings/glib/chip-info.c | 129 ++ bindings/glib/chip.c | 397 ++++++ bindings/glib/edge-event.c | 186 +++ bindings/glib/error.c | 67 + bindings/glib/examples/.gitignore | 14 + bindings/glib/examples/Makefile.am | 22 + bindings/glib/examples/find_line_by_name_glib.c | 71 + bindings/glib/examples/get_chip_info_glib.c | 42 + bindings/glib/examples/get_line_info_glib.c | 80 ++ bindings/glib/examples/get_line_value_glib.c | 68 + .../glib/examples/get_multiple_line_values_glib.c | 73 + .../examples/reconfigure_input_to_output_glib.c | 104 ++ bindings/glib/examples/toggle_line_value_glib.c | 99 ++ .../examples/toggle_multiple_line_values_glib.c | 132 ++ bindings/glib/examples/watch_line_info_glib.c | 63 + bindings/glib/examples/watch_line_value_glib.c | 91 ++ .../examples/watch_multiple_edge_rising_glib.c | 95 ++ bindings/glib/generated-enums.c.template | 43 + bindings/glib/generated-enums.h.template | 30 + bindings/glib/gpiod-glib.h | 22 + bindings/glib/gpiod-glib.pc.in | 15 + bindings/glib/gpiod-glib/chip-info.h | 62 + bindings/glib/gpiod-glib/chip.h | 157 +++ bindings/glib/gpiod-glib/edge-event.h | 97 ++ bindings/glib/gpiod-glib/error.h | 45 + bindings/glib/gpiod-glib/info-event.h | 76 ++ bindings/glib/gpiod-glib/line-config.h | 101 ++ bindings/glib/gpiod-glib/line-info.h | 171 +++ bindings/glib/gpiod-glib/line-request.h | 186 +++ bindings/glib/gpiod-glib/line-settings.h | 220 +++ bindings/glib/gpiod-glib/line.h | 113 ++ bindings/glib/gpiod-glib/misc.h | 39 + bindings/glib/gpiod-glib/request-config.h | 93 ++ bindings/glib/info-event.c | 163 +++ bindings/glib/internal.c | 327 +++++ bindings/glib/internal.h | 79 ++ bindings/glib/line-config.c | 193 +++ bindings/glib/line-info.c | 342 +++++ bindings/glib/line-request.c | 452 ++++++ bindings/glib/line-settings.c | 408 ++++++ bindings/glib/misc.c | 17 + bindings/glib/request-config.c | 170 +++ bindings/glib/tests/.gitignore | 4 + bindings/glib/tests/Makefile.am | 29 + bindings/glib/tests/helpers.c | 12 + bindings/glib/tests/helpers.h | 140 ++ bindings/glib/tests/tests-chip-info.c | 58 + bindings/glib/tests/tests-chip.c | 187 +++ bindings/glib/tests/tests-edge-event.c | 225 +++ bindings/glib/tests/tests-info-event.c | 322 +++++ bindings/glib/tests/tests-line-config.c | 187 +++ bindings/glib/tests/tests-line-info.c | 102 ++ bindings/glib/tests/tests-line-request.c | 710 ++++++++++ bindings/glib/tests/tests-line-settings.c | 256 ++++ bindings/glib/tests/tests-misc.c | 88 ++ bindings/glib/tests/tests-request-config.c | 64 + configure.ac | 84 ++ dbus/Makefile.am | 10 + dbus/client/.gitignore | 4 + dbus/client/Makefile.am | 31 + dbus/client/common.c | 646 +++++++++ dbus/client/common.h | 203 +++ dbus/client/detect.c | 53 + dbus/client/find.c | 66 + dbus/client/get.c | 212 +++ dbus/client/gpiocli-test.bash | 1443 ++++++++++++++++++++ dbus/client/gpiocli.c | 174 +++ dbus/client/info.c | 184 +++ dbus/client/monitor.c | 191 +++ dbus/client/notify.c | 295 ++++ dbus/client/reconfigure.c | 76 ++ dbus/client/release.c | 64 + dbus/client/request.c | 250 ++++ dbus/client/requests.c | 71 + dbus/client/set.c | 173 +++ dbus/client/wait.c | 188 +++ dbus/data/90-gpio.rules | 4 + dbus/data/Makefile.am | 16 + dbus/data/gpio-manager.service | 50 + dbus/data/io.gpiod1.conf | 41 + dbus/lib/Makefile.am | 29 + dbus/lib/gpiodbus.h | 9 + dbus/lib/io.gpiod1.xml | 324 +++++ dbus/manager/.gitignore | 4 + dbus/manager/Makefile.am | 21 + dbus/manager/daemon.c | 821 +++++++++++ dbus/manager/daemon.h | 22 + dbus/manager/gpio-manager.c | 173 +++ dbus/manager/helpers.c | 431 ++++++ dbus/manager/helpers.h | 26 + dbus/tests/.gitignore | 4 + dbus/tests/Makefile.am | 25 + dbus/tests/daemon-process.c | 129 ++ dbus/tests/daemon-process.h | 20 + dbus/tests/helpers.c | 107 ++ dbus/tests/helpers.h | 114 ++ dbus/tests/tests-chip.c | 133 ++ dbus/tests/tests-line.c | 231 ++++ dbus/tests/tests-request.c | 116 ++ tests/Makefile.am | 14 +- tests/gpiod-test-helpers.c | 41 - tests/gpiosim-glib/Makefile.am | 13 + .../gpiosim-glib.c} | 30 +- .../gpiosim-glib.h} | 14 + tests/harness/Makefile.am | 12 + tests/harness/gpiod-test-common.h | 23 + tests/{ => harness}/gpiod-test.c | 0 tests/{ => harness}/gpiod-test.h | 0 tests/{gpiod-test-helpers.h => helpers.h} | 36 +- tests/scripts/Makefile.am | 4 + tests/scripts/gpiod-bash-test-helper.inc | 330 +++++ tests/tests-chip-info.c | 7 +- tests/tests-chip.c | 15 +- tests/tests-edge-event.c | 7 +- tests/tests-info-event.c | 7 +- tests/tests-kernel-uapi.c | 7 +- tests/tests-line-config.c | 7 +- tests/tests-line-info.c | 11 +- tests/tests-line-request.c | 7 +- tests/tests-line-settings.c | 5 +- tests/tests-misc.c | 7 +- tests/tests-request-config.c | 5 +- tools/gpio-tools-test.bash | 566 ++------ 130 files changed, 15833 insertions(+), 584 deletions(-) --- base-commit: 9fdd6e23faa5e0011d6ee047b25928e8ad4c3320 change-id: 20240527-dbus-820e9f7463d0 Best regards,