| Message ID | 20240807210103.142483-1-luiz.dentz@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | pull request: bluetooth 2024-07-26 | expand |
Hi Jakub, On Wed, Aug 7, 2024 at 11:40 PM <patchwork-bot+netdevbpf@kernel.org> wrote: > > Hello: > > This pull request was applied to netdev/net.git (main) > by Jakub Kicinski <kuba@kernel.org>: > > On Wed, 7 Aug 2024 17:01:03 -0400 you wrote: > > The following changes since commit 1ca645a2f74a4290527ae27130c8611391b07dbf: > > > > net: usb: qmi_wwan: add MeiG Smart SRM825L (2024-08-06 19:35:08 -0700) > > > > are available in the Git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git tags/for-net-2024-08-07 > > > > [...] > > Here is the summary with links: > - pull request: bluetooth 2024-07-26 > https://git.kernel.org/netdev/net/c/b928e7d19dfd > > You are awesome, thank you! Im trying to rebase on top of net-next but Im getting the following error: In file included from arch/x86/entry/vdso/vgetrandom.c:7: arch/x86/entry/vdso/../../../../lib/vdso/getrandom.c: In function ‘memcpy_and_zero_src’: arch/x86/entry/vdso/../../../../lib/vdso/getrandom.c:18:17: error: implicit declaration of function ‘__put_unaligned_t’; did you mean ‘__put_unaligned_le24’? [-Wimplicit-function-declaration] I tried to google it but got no results, perhaps there is something wrong with my .config, it used to work just fine but it seems something had changed. > -- > Deet-doot-dot, I am a bot. > https://korg.docs.kernel.org/patchwork/pwbot.html > >
Hi, On Fri, Aug 9, 2024 at 10:48 AM Luiz Augusto von Dentz <luiz.dentz@gmail.com> wrote: > > Hi Jakub, > > On Wed, Aug 7, 2024 at 11:40 PM <patchwork-bot+netdevbpf@kernel.org> wrote: > > > > Hello: > > > > This pull request was applied to netdev/net.git (main) > > by Jakub Kicinski <kuba@kernel.org>: > > > > On Wed, 7 Aug 2024 17:01:03 -0400 you wrote: > > > The following changes since commit 1ca645a2f74a4290527ae27130c8611391b07dbf: > > > > > > net: usb: qmi_wwan: add MeiG Smart SRM825L (2024-08-06 19:35:08 -0700) > > > > > > are available in the Git repository at: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git tags/for-net-2024-08-07 > > > > > > [...] > > > > Here is the summary with links: > > - pull request: bluetooth 2024-07-26 > > https://git.kernel.org/netdev/net/c/b928e7d19dfd > > > > You are awesome, thank you! > > Im trying to rebase on top of net-next but Im getting the following error: > > In file included from arch/x86/entry/vdso/vgetrandom.c:7: > arch/x86/entry/vdso/../../../../lib/vdso/getrandom.c: In function > ‘memcpy_and_zero_src’: > arch/x86/entry/vdso/../../../../lib/vdso/getrandom.c:18:17: error: > implicit declaration of function ‘__put_unaligned_t’; did you mean > ‘__put_unaligned_le24’? [-Wimplicit-function-declaration] > > I tried to google it but got no results, perhaps there is something > wrong with my .config, it used to work just fine but it seems > something had changed. Looks like the culprit is "x86: vdso: Wire up getrandom() vDSO implementation", if I revert that I got it to build properly. @Jason A. Donenfeld since you are the author of the specific change perhaps you can tell me what is going on, my .config is based on: https://github.com/Vudentz/BlueZ/blob/master/doc/test-runner.txt > > > -- > > Deet-doot-dot, I am a bot. > > https://korg.docs.kernel.org/patchwork/pwbot.html > > > > > > > -- > Luiz Augusto von Dentz
Hi, On Fri, Aug 09, 2024 at 11:12:32AM -0400, Luiz Augusto von Dentz wrote: > Hi, > > On Fri, Aug 9, 2024 at 10:48 AM Luiz Augusto von Dentz > <luiz.dentz@gmail.com> wrote: > > > > Hi Jakub, > > > > On Wed, Aug 7, 2024 at 11:40 PM <patchwork-bot+netdevbpf@kernel.org> wrote: > > > > > > Hello: > > > > > > This pull request was applied to netdev/net.git (main) > > > by Jakub Kicinski <kuba@kernel.org>: > > > > > > On Wed, 7 Aug 2024 17:01:03 -0400 you wrote: > > > > The following changes since commit 1ca645a2f74a4290527ae27130c8611391b07dbf: > > > > > > > > net: usb: qmi_wwan: add MeiG Smart SRM825L (2024-08-06 19:35:08 -0700) > > > > > > > > are available in the Git repository at: > > > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git tags/for-net-2024-08-07 > > > > > > > > [...] > > > > > > Here is the summary with links: > > > - pull request: bluetooth 2024-07-26 > > > https://git.kernel.org/netdev/net/c/b928e7d19dfd > > > > > > You are awesome, thank you! > > > > Im trying to rebase on top of net-next but Im getting the following error: > > > > In file included from arch/x86/entry/vdso/vgetrandom.c:7: > > arch/x86/entry/vdso/../../../../lib/vdso/getrandom.c: In function > > ‘memcpy_and_zero_src’: > > arch/x86/entry/vdso/../../../../lib/vdso/getrandom.c:18:17: error: > > implicit declaration of function ‘__put_unaligned_t’; did you mean > > ‘__put_unaligned_le24’? [-Wimplicit-function-declaration] > > > > I tried to google it but got no results, perhaps there is something > > wrong with my .config, it used to work just fine but it seems > > something had changed. > > Looks like the culprit is "x86: vdso: Wire up getrandom() vDSO > implementation", if I revert that I got it to build properly. > > @Jason A. Donenfeld since you are the author of the specific change > perhaps you can tell me what is going on, my .config is based on: > > https://github.com/Vudentz/BlueZ/blob/master/doc/test-runner.txt Could you send your actual .config so I can repro? Thanks, Jason
Hi Jason, On Fri, Aug 9, 2024 at 3:54 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote: > > Hi, > > On Fri, Aug 09, 2024 at 11:12:32AM -0400, Luiz Augusto von Dentz wrote: > > Hi, > > > > On Fri, Aug 9, 2024 at 10:48 AM Luiz Augusto von Dentz > > <luiz.dentz@gmail.com> wrote: > > > > > > Hi Jakub, > > > > > > On Wed, Aug 7, 2024 at 11:40 PM <patchwork-bot+netdevbpf@kernel.org> wrote: > > > > > > > > Hello: > > > > > > > > This pull request was applied to netdev/net.git (main) > > > > by Jakub Kicinski <kuba@kernel.org>: > > > > > > > > On Wed, 7 Aug 2024 17:01:03 -0400 you wrote: > > > > > The following changes since commit 1ca645a2f74a4290527ae27130c8611391b07dbf: > > > > > > > > > > net: usb: qmi_wwan: add MeiG Smart SRM825L (2024-08-06 19:35:08 -0700) > > > > > > > > > > are available in the Git repository at: > > > > > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git tags/for-net-2024-08-07 > > > > > > > > > > [...] > > > > > > > > Here is the summary with links: > > > > - pull request: bluetooth 2024-07-26 > > > > https://git.kernel.org/netdev/net/c/b928e7d19dfd > > > > > > > > You are awesome, thank you! > > > > > > Im trying to rebase on top of net-next but Im getting the following error: > > > > > > In file included from arch/x86/entry/vdso/vgetrandom.c:7: > > > arch/x86/entry/vdso/../../../../lib/vdso/getrandom.c: In function > > > ‘memcpy_and_zero_src’: > > > arch/x86/entry/vdso/../../../../lib/vdso/getrandom.c:18:17: error: > > > implicit declaration of function ‘__put_unaligned_t’; did you mean > > > ‘__put_unaligned_le24’? [-Wimplicit-function-declaration] > > > > > > I tried to google it but got no results, perhaps there is something > > > wrong with my .config, it used to work just fine but it seems > > > something had changed. > > > > Looks like the culprit is "x86: vdso: Wire up getrandom() vDSO > > implementation", if I revert that I got it to build properly. > > > > @Jason A. Donenfeld since you are the author of the specific change > > perhaps you can tell me what is going on, my .config is based on: > > > > https://github.com/Vudentz/BlueZ/blob/master/doc/test-runner.txt > > Could you send your actual .config so I can repro? Here it is. > Thanks, > Jason
On Fri, Aug 09, 2024 at 04:02:36PM -0400, Luiz Augusto von Dentz wrote: > Hi Jason, > > On Fri, Aug 9, 2024 at 3:54 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote: > > > > Hi, > > > > On Fri, Aug 09, 2024 at 11:12:32AM -0400, Luiz Augusto von Dentz wrote: > > > Hi, > > > > > > On Fri, Aug 9, 2024 at 10:48 AM Luiz Augusto von Dentz > > > <luiz.dentz@gmail.com> wrote: > > > > > > > > Hi Jakub, > > > > > > > > On Wed, Aug 7, 2024 at 11:40 PM <patchwork-bot+netdevbpf@kernel.org> wrote: > > > > > > > > > > Hello: > > > > > > > > > > This pull request was applied to netdev/net.git (main) > > > > > by Jakub Kicinski <kuba@kernel.org>: > > > > > > > > > > On Wed, 7 Aug 2024 17:01:03 -0400 you wrote: > > > > > > The following changes since commit 1ca645a2f74a4290527ae27130c8611391b07dbf: > > > > > > > > > > > > net: usb: qmi_wwan: add MeiG Smart SRM825L (2024-08-06 19:35:08 -0700) > > > > > > > > > > > > are available in the Git repository at: > > > > > > > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git tags/for-net-2024-08-07 > > > > > > > > > > > > [...] > > > > > > > > > > Here is the summary with links: > > > > > - pull request: bluetooth 2024-07-26 > > > > > https://git.kernel.org/netdev/net/c/b928e7d19dfd > > > > > > > > > > You are awesome, thank you! > > > > > > > > Im trying to rebase on top of net-next but Im getting the following error: > > > > > > > > In file included from arch/x86/entry/vdso/vgetrandom.c:7: > > > > arch/x86/entry/vdso/../../../../lib/vdso/getrandom.c: In function > > > > ‘memcpy_and_zero_src’: > > > > arch/x86/entry/vdso/../../../../lib/vdso/getrandom.c:18:17: error: > > > > implicit declaration of function ‘__put_unaligned_t’; did you mean > > > > ‘__put_unaligned_le24’? [-Wimplicit-function-declaration] > > > > > > > > I tried to google it but got no results, perhaps there is something > > > > wrong with my .config, it used to work just fine but it seems > > > > something had changed. > > > > > > Looks like the culprit is "x86: vdso: Wire up getrandom() vDSO > > > implementation", if I revert that I got it to build properly. > > > > > > @Jason A. Donenfeld since you are the author of the specific change > > > perhaps you can tell me what is going on, my .config is based on: > > > > > > https://github.com/Vudentz/BlueZ/blob/master/doc/test-runner.txt > > > > Could you send your actual .config so I can repro? > > Here it is. Hmm, I did a clean checkout of net-next, used this .config, and it built just fine. Any oddities I should look into? Jason
Hi Jason, On Fri, Aug 9, 2024 at 4:21 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote: > > On Fri, Aug 09, 2024 at 04:02:36PM -0400, Luiz Augusto von Dentz wrote: > > Hi Jason, > > > > On Fri, Aug 9, 2024 at 3:54 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote: > > > > > > Hi, > > > > > > On Fri, Aug 09, 2024 at 11:12:32AM -0400, Luiz Augusto von Dentz wrote: > > > > Hi, > > > > > > > > On Fri, Aug 9, 2024 at 10:48 AM Luiz Augusto von Dentz > > > > <luiz.dentz@gmail.com> wrote: > > > > > > > > > > Hi Jakub, > > > > > > > > > > On Wed, Aug 7, 2024 at 11:40 PM <patchwork-bot+netdevbpf@kernel.org> wrote: > > > > > > > > > > > > Hello: > > > > > > > > > > > > This pull request was applied to netdev/net.git (main) > > > > > > by Jakub Kicinski <kuba@kernel.org>: > > > > > > > > > > > > On Wed, 7 Aug 2024 17:01:03 -0400 you wrote: > > > > > > > The following changes since commit 1ca645a2f74a4290527ae27130c8611391b07dbf: > > > > > > > > > > > > > > net: usb: qmi_wwan: add MeiG Smart SRM825L (2024-08-06 19:35:08 -0700) > > > > > > > > > > > > > > are available in the Git repository at: > > > > > > > > > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git tags/for-net-2024-08-07 > > > > > > > > > > > > > > [...] > > > > > > > > > > > > Here is the summary with links: > > > > > > - pull request: bluetooth 2024-07-26 > > > > > > https://git.kernel.org/netdev/net/c/b928e7d19dfd > > > > > > > > > > > > You are awesome, thank you! > > > > > > > > > > Im trying to rebase on top of net-next but Im getting the following error: > > > > > > > > > > In file included from arch/x86/entry/vdso/vgetrandom.c:7: > > > > > arch/x86/entry/vdso/../../../../lib/vdso/getrandom.c: In function > > > > > ‘memcpy_and_zero_src’: > > > > > arch/x86/entry/vdso/../../../../lib/vdso/getrandom.c:18:17: error: > > > > > implicit declaration of function ‘__put_unaligned_t’; did you mean > > > > > ‘__put_unaligned_le24’? [-Wimplicit-function-declaration] > > > > > > > > > > I tried to google it but got no results, perhaps there is something > > > > > wrong with my .config, it used to work just fine but it seems > > > > > something had changed. > > > > > > > > Looks like the culprit is "x86: vdso: Wire up getrandom() vDSO > > > > implementation", if I revert that I got it to build properly. > > > > > > > > @Jason A. Donenfeld since you are the author of the specific change > > > > perhaps you can tell me what is going on, my .config is based on: > > > > > > > > https://github.com/Vudentz/BlueZ/blob/master/doc/test-runner.txt > > > > > > Could you send your actual .config so I can repro? > > > > Here it is. > > Hmm, I did a clean checkout of net-next, used this .config, and it built > just fine. Any oddities I should look into? Something is wrong with asm/unaligned.h on my system, if I do the following change it builds properly: diff --git a/lib/vdso/getrandom.c b/lib/vdso/getrandom.c index b230f0b10832..c1a18f5c6fe3 100644 --- a/lib/vdso/getrandom.c +++ b/lib/vdso/getrandom.c @@ -10,7 +10,7 @@ #include <vdso/getrandom.h> #include <asm/vdso/getrandom.h> #include <asm/vdso/vsyscall.h> -#include <asm/unaligned.h> +#include <asm-generic/unaligned.h> #include <uapi/linux/mman.h> #define MEMCPY_AND_ZERO_SRC(type, dst, src, len) do { \ My system is based on meteor lake, not sure if that is affecting the build with a mix of LP+E+P cores? > Jason
Hi Jason, On Thu, Aug 15, 2024 at 12:32 PM Luiz Augusto von Dentz <luiz.dentz@gmail.com> wrote: > > Hi Jason, > > On Fri, Aug 9, 2024 at 4:21 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote: > > > > On Fri, Aug 09, 2024 at 04:02:36PM -0400, Luiz Augusto von Dentz wrote: > > > Hi Jason, > > > > > > On Fri, Aug 9, 2024 at 3:54 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote: > > > > > > > > Hi, > > > > > > > > On Fri, Aug 09, 2024 at 11:12:32AM -0400, Luiz Augusto von Dentz wrote: > > > > > Hi, > > > > > > > > > > On Fri, Aug 9, 2024 at 10:48 AM Luiz Augusto von Dentz > > > > > <luiz.dentz@gmail.com> wrote: > > > > > > > > > > > > Hi Jakub, > > > > > > > > > > > > On Wed, Aug 7, 2024 at 11:40 PM <patchwork-bot+netdevbpf@kernel.org> wrote: > > > > > > > > > > > > > > Hello: > > > > > > > > > > > > > > This pull request was applied to netdev/net.git (main) > > > > > > > by Jakub Kicinski <kuba@kernel.org>: > > > > > > > > > > > > > > On Wed, 7 Aug 2024 17:01:03 -0400 you wrote: > > > > > > > > The following changes since commit 1ca645a2f74a4290527ae27130c8611391b07dbf: > > > > > > > > > > > > > > > > net: usb: qmi_wwan: add MeiG Smart SRM825L (2024-08-06 19:35:08 -0700) > > > > > > > > > > > > > > > > are available in the Git repository at: > > > > > > > > > > > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git tags/for-net-2024-08-07 > > > > > > > > > > > > > > > > [...] > > > > > > > > > > > > > > Here is the summary with links: > > > > > > > - pull request: bluetooth 2024-07-26 > > > > > > > https://git.kernel.org/netdev/net/c/b928e7d19dfd > > > > > > > > > > > > > > You are awesome, thank you! > > > > > > > > > > > > Im trying to rebase on top of net-next but Im getting the following error: > > > > > > > > > > > > In file included from arch/x86/entry/vdso/vgetrandom.c:7: > > > > > > arch/x86/entry/vdso/../../../../lib/vdso/getrandom.c: In function > > > > > > ‘memcpy_and_zero_src’: > > > > > > arch/x86/entry/vdso/../../../../lib/vdso/getrandom.c:18:17: error: > > > > > > implicit declaration of function ‘__put_unaligned_t’; did you mean > > > > > > ‘__put_unaligned_le24’? [-Wimplicit-function-declaration] > > > > > > > > > > > > I tried to google it but got no results, perhaps there is something > > > > > > wrong with my .config, it used to work just fine but it seems > > > > > > something had changed. > > > > > > > > > > Looks like the culprit is "x86: vdso: Wire up getrandom() vDSO > > > > > implementation", if I revert that I got it to build properly. > > > > > > > > > > @Jason A. Donenfeld since you are the author of the specific change > > > > > perhaps you can tell me what is going on, my .config is based on: > > > > > > > > > > https://github.com/Vudentz/BlueZ/blob/master/doc/test-runner.txt > > > > > > > > Could you send your actual .config so I can repro? > > > > > > Here it is. > > > > Hmm, I did a clean checkout of net-next, used this .config, and it built > > just fine. Any oddities I should look into? > > Something is wrong with asm/unaligned.h on my system, if I do the > following change it builds properly: > > diff --git a/lib/vdso/getrandom.c b/lib/vdso/getrandom.c > index b230f0b10832..c1a18f5c6fe3 100644 > --- a/lib/vdso/getrandom.c > +++ b/lib/vdso/getrandom.c > @@ -10,7 +10,7 @@ > #include <vdso/getrandom.h> > #include <asm/vdso/getrandom.h> > #include <asm/vdso/vsyscall.h> > -#include <asm/unaligned.h> > +#include <asm-generic/unaligned.h> > #include <uapi/linux/mman.h> > > #define MEMCPY_AND_ZERO_SRC(type, dst, src, len) do { > \ > > My system is based on meteor lake, not sure if that is affecting the > build with a mix of LP+E+P cores? Sorry for the noise, it seems that there is some leftover when I switch branches since on bluetooth-next I do have ./arch/x86/include/asm/unaligned.h but on net-next that was removed but it was still left on the tree for some reason. > > Jason > > > > -- > Luiz Augusto von Dentz
Hello: This pull request was applied to bluetooth/bluetooth-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Wed, 7 Aug 2024 17:01:03 -0400 you wrote: > The following changes since commit 1ca645a2f74a4290527ae27130c8611391b07dbf: > > net: usb: qmi_wwan: add MeiG Smart SRM825L (2024-08-06 19:35:08 -0700) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git tags/for-net-2024-08-07 > > [...] Here is the summary with links: - pull request: bluetooth 2024-07-26 https://git.kernel.org/bluetooth/bluetooth-next/c/b928e7d19dfd You are awesome, thank you!
The following changes since commit 1ca645a2f74a4290527ae27130c8611391b07dbf: net: usb: qmi_wwan: add MeiG Smart SRM825L (2024-08-06 19:35:08 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git tags/for-net-2024-08-07 for you to fetch changes up to b5431dc2803ac159d6d4645ae237d15c3cb252db: Bluetooth: hci_sync: avoid dup filtering when passive scanning with adv monitor (2024-08-07 16:36:01 -0400) ---------------------------------------------------------------- bluetooth pull request for net: - hci_sync: avoid dup filtering when passive scanning with adv monitor - hci_qca: don't call pwrseq_power_off() twice for QCA6390 - hci_qca: fix QCA6390 support on non-DT platforms - hci_qca: fix a NULL-pointer derefence at shutdown - l2cap: always unlock channel in l2cap_conless_channel() ---------------------------------------------------------------- Anton Khirnov (1): Bluetooth: hci_sync: avoid dup filtering when passive scanning with adv monitor Bartosz Golaszewski (3): Bluetooth: hci_qca: don't call pwrseq_power_off() twice for QCA6390 Bluetooth: hci_qca: fix QCA6390 support on non-DT platforms Bluetooth: hci_qca: fix a NULL-pointer derefence at shutdown Dmitry Antipov (1): Bluetooth: l2cap: always unlock channel in l2cap_conless_channel() drivers/bluetooth/hci_qca.c | 19 +++++++++---------- net/bluetooth/hci_sync.c | 14 ++++++++++++++ net/bluetooth/l2cap_core.c | 1 + 3 files changed, 24 insertions(+), 10 deletions(-)