| Message ID | 20240820093452.68270-1-tzimmermann@suse.de |
|---|---|
| Headers | show |
| Series | backlight: lcd: Remove fbdev dependencies | expand |
On Tue, 20 Aug 2024, Thomas Zimmermann wrote: > Store the lcd device in struct fb_info.lcd_dev. The lcd subsystem can > now detect the lcd's fbdev device from this field. > > This makes the implementation of check_fb in picolcd_lcdops obsolete. > Remove it. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Acked-by: Jiri Kosina <jkosina@suse.com>
On Tue, Aug 20, 2024 at 11:22:38AM +0200, Thomas Zimmermann wrote: > This series removes most dependencies on fbdev from the lcd subsystem > and its drivers. > > Patches 1 to 3 rework the fbdev notifier, the fbdev's fb_info can > now refer to a dedicated lcd device, and lcd defines constants for > power states. These changes resemble similar changes to the backlight > code. > > Patches 4 to 19 update lcd drivers to the new interfaces and perform > minor cleanups during the process. Patches 20 to 24 update fbdev > drivers and patch 25 updates the picolcd driver from the hid subsystem. > > Patches 25 to 28 finally clean up various lcd interfaces and files. > > This patchset is part of a larger effort to implement the lcd code > without depending on fbdev. Similar patches have been sent out for > the backlight subsystem, such as in [1] and [2]. > > Hopefully this series can be merged at once through the lcd tree. > > [1] https://patchwork.freedesktop.org/series/129782/ > [2] https://patchwork.freedesktop.org/series/134718/ I shared a could of nitpicks. You can do what you like with them since none are major enough to stop me also sharing a: Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Daniel.
Hi Am 03.09.24 um 16:58 schrieb Daniel Thompson: > On Tue, Aug 20, 2024 at 11:22:38AM +0200, Thomas Zimmermann wrote: >> This series removes most dependencies on fbdev from the lcd subsystem >> and its drivers. >> >> Patches 1 to 3 rework the fbdev notifier, the fbdev's fb_info can >> now refer to a dedicated lcd device, and lcd defines constants for >> power states. These changes resemble similar changes to the backlight >> code. >> >> Patches 4 to 19 update lcd drivers to the new interfaces and perform >> minor cleanups during the process. Patches 20 to 24 update fbdev >> drivers and patch 25 updates the picolcd driver from the hid subsystem. >> >> Patches 25 to 28 finally clean up various lcd interfaces and files. >> >> This patchset is part of a larger effort to implement the lcd code >> without depending on fbdev. Similar patches have been sent out for >> the backlight subsystem, such as in [1] and [2]. >> >> Hopefully this series can be merged at once through the lcd tree. >> >> [1] https://patchwork.freedesktop.org/series/129782/ >> [2] https://patchwork.freedesktop.org/series/134718/ > I shared a could of nitpicks. You can do what you like with them since > none are major enough to stop me also sharing a: > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Thanks for reviewing. I'll send out an update. Why tree do these patches go into? Backlight? Best regards Thomas > > > Daniel.
Helge, you might want to look through the fbdev patches in this series. Am 20.08.24 um 11:22 schrieb Thomas Zimmermann: > This series removes most dependencies on fbdev from the lcd subsystem > and its drivers. > > Patches 1 to 3 rework the fbdev notifier, the fbdev's fb_info can > now refer to a dedicated lcd device, and lcd defines constants for > power states. These changes resemble similar changes to the backlight > code. > > Patches 4 to 19 update lcd drivers to the new interfaces and perform > minor cleanups during the process. Patches 20 to 24 update fbdev > drivers and patch 25 updates the picolcd driver from the hid subsystem. > > Patches 25 to 28 finally clean up various lcd interfaces and files. > > This patchset is part of a larger effort to implement the lcd code > without depending on fbdev. Similar patches have been sent out for > the backlight subsystem, such as in [1] and [2]. > > Hopefully this series can be merged at once through the lcd tree. > > [1] https://patchwork.freedesktop.org/series/129782/ > [2] https://patchwork.freedesktop.org/series/134718/ > > Thomas Zimmermann (28): > backlight: lcd: Rearrange code in fb_notifier_callback() > backlight: lcd: Test against struct fb_info.lcd_dev > backlight: lcd: Add LCD_POWER_ constants for power states > backlight: corgi_lcd: Use lcd power constants > backlight: hx8357: Use lcd power constants > backlight: ili922x: Use lcd power constants > backlight: ili9320: Use lcd power constants > backlight: jornada720_lcd: Include <linux/io.h> for IOMEM() macro > backlight: jornada720_lcd: Use lcd power constants > backlight: l4f00242t03: Use lcd power constants > backlight: lms283gf05: Use lcd power constants > backlight: lms501kf03: Remove unnecessary include of > <linux/backlight.h> > backlight: lms501kf03: Use lcd power constants > backlight: ltv350qv: Use lcd power constants > backlight: otm3225a: Use lcd power constants > backlight: platform_lcd: Remove include statement for > <linux/backlight.h> > backlight: platform_lcd: Remove match_fb from struct plat_lcd_data > backlight: platform_lcd: Use lcd power constants > backlight: tdo24m: Use lcd power constants > fbdev: clps711x-fb: Replace check_fb in favor of struct > fb_info.lcd_dev > fbdev: clps711x-fb: Use lcd power constants > fbdev: imxfb: Replace check_fb in favor of struct fb_info.lcd_dev > fbdev: imxfb: Use lcd power constants > fbdev: omap: Use lcd power constants > HID: picoLCD: Replace check_fb in favor of struct fb_info.lcd_dev > backlight: lcd: Replace check_fb with controls_device > backlight: lcd: Remove struct fb_videomode from set_mode callback > backlight: lcd: Do not include <linux/fb.h> in lcd header > > drivers/hid/hid-picolcd_fb.c | 4 ++ > drivers/hid/hid-picolcd_lcd.c | 6 --- > drivers/video/backlight/corgi_lcd.c | 17 ++++---- > drivers/video/backlight/hx8357.c | 2 +- > drivers/video/backlight/ili922x.c | 7 ++-- > drivers/video/backlight/ili9320.c | 15 ++++---- > drivers/video/backlight/jornada720_lcd.c | 10 ++--- > drivers/video/backlight/l4f00242t03.c | 32 ++++++++-------- > drivers/video/backlight/lcd.c | 49 +++++++++++++++++++----- > drivers/video/backlight/lms283gf05.c | 2 +- > drivers/video/backlight/lms501kf03.c | 24 ++++++------ > drivers/video/backlight/ltv350qv.c | 15 ++++---- > drivers/video/backlight/otm3225a.c | 2 +- > drivers/video/backlight/platform_lcd.c | 20 ++++------ > drivers/video/backlight/tdo24m.c | 19 +++++---- > drivers/video/fbdev/clps711x-fb.c | 29 +++++++------- > drivers/video/fbdev/imxfb.c | 32 ++++++---------- > drivers/video/fbdev/omap/lcd_ams_delta.c | 8 ++-- > include/linux/fb.h | 13 +++++++ > include/linux/lcd.h | 29 ++++++++++---- > include/video/platform_lcd.h | 3 -- > 21 files changed, 182 insertions(+), 156 deletions(-) >
On Thu, 05 Sep 2024, Thomas Zimmermann wrote: > Hi > > Am 03.09.24 um 16:58 schrieb Daniel Thompson: > > On Tue, Aug 20, 2024 at 11:22:38AM +0200, Thomas Zimmermann wrote: > > > This series removes most dependencies on fbdev from the lcd subsystem > > > and its drivers. > > > > > > Patches 1 to 3 rework the fbdev notifier, the fbdev's fb_info can > > > now refer to a dedicated lcd device, and lcd defines constants for > > > power states. These changes resemble similar changes to the backlight > > > code. > > > > > > Patches 4 to 19 update lcd drivers to the new interfaces and perform > > > minor cleanups during the process. Patches 20 to 24 update fbdev > > > drivers and patch 25 updates the picolcd driver from the hid subsystem. > > > > > > Patches 25 to 28 finally clean up various lcd interfaces and files. > > > > > > This patchset is part of a larger effort to implement the lcd code > > > without depending on fbdev. Similar patches have been sent out for > > > the backlight subsystem, such as in [1] and [2]. > > > > > > Hopefully this series can be merged at once through the lcd tree. > > > > > > [1] https://patchwork.freedesktop.org/series/129782/ > > > [2] https://patchwork.freedesktop.org/series/134718/ > > I shared a could of nitpicks. You can do what you like with them since > > none are major enough to stop me also sharing a: > > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> > > Thanks for reviewing. I'll send out an update. Why tree do these patches go > into? Backlight? Yes, that's expected.
This series removes most dependencies on fbdev from the lcd subsystem and its drivers. Patches 1 to 3 rework the fbdev notifier, the fbdev's fb_info can now refer to a dedicated lcd device, and lcd defines constants for power states. These changes resemble similar changes to the backlight code. Patches 4 to 19 update lcd drivers to the new interfaces and perform minor cleanups during the process. Patches 20 to 24 update fbdev drivers and patch 25 updates the picolcd driver from the hid subsystem. Patches 25 to 28 finally clean up various lcd interfaces and files. This patchset is part of a larger effort to implement the lcd code without depending on fbdev. Similar patches have been sent out for the backlight subsystem, such as in [1] and [2]. Hopefully this series can be merged at once through the lcd tree. [1] https://patchwork.freedesktop.org/series/129782/ [2] https://patchwork.freedesktop.org/series/134718/ Thomas Zimmermann (28): backlight: lcd: Rearrange code in fb_notifier_callback() backlight: lcd: Test against struct fb_info.lcd_dev backlight: lcd: Add LCD_POWER_ constants for power states backlight: corgi_lcd: Use lcd power constants backlight: hx8357: Use lcd power constants backlight: ili922x: Use lcd power constants backlight: ili9320: Use lcd power constants backlight: jornada720_lcd: Include <linux/io.h> for IOMEM() macro backlight: jornada720_lcd: Use lcd power constants backlight: l4f00242t03: Use lcd power constants backlight: lms283gf05: Use lcd power constants backlight: lms501kf03: Remove unnecessary include of <linux/backlight.h> backlight: lms501kf03: Use lcd power constants backlight: ltv350qv: Use lcd power constants backlight: otm3225a: Use lcd power constants backlight: platform_lcd: Remove include statement for <linux/backlight.h> backlight: platform_lcd: Remove match_fb from struct plat_lcd_data backlight: platform_lcd: Use lcd power constants backlight: tdo24m: Use lcd power constants fbdev: clps711x-fb: Replace check_fb in favor of struct fb_info.lcd_dev fbdev: clps711x-fb: Use lcd power constants fbdev: imxfb: Replace check_fb in favor of struct fb_info.lcd_dev fbdev: imxfb: Use lcd power constants fbdev: omap: Use lcd power constants HID: picoLCD: Replace check_fb in favor of struct fb_info.lcd_dev backlight: lcd: Replace check_fb with controls_device backlight: lcd: Remove struct fb_videomode from set_mode callback backlight: lcd: Do not include <linux/fb.h> in lcd header drivers/hid/hid-picolcd_fb.c | 4 ++ drivers/hid/hid-picolcd_lcd.c | 6 --- drivers/video/backlight/corgi_lcd.c | 17 ++++---- drivers/video/backlight/hx8357.c | 2 +- drivers/video/backlight/ili922x.c | 7 ++-- drivers/video/backlight/ili9320.c | 15 ++++---- drivers/video/backlight/jornada720_lcd.c | 10 ++--- drivers/video/backlight/l4f00242t03.c | 32 ++++++++-------- drivers/video/backlight/lcd.c | 49 +++++++++++++++++++----- drivers/video/backlight/lms283gf05.c | 2 +- drivers/video/backlight/lms501kf03.c | 24 ++++++------ drivers/video/backlight/ltv350qv.c | 15 ++++---- drivers/video/backlight/otm3225a.c | 2 +- drivers/video/backlight/platform_lcd.c | 20 ++++------ drivers/video/backlight/tdo24m.c | 19 +++++---- drivers/video/fbdev/clps711x-fb.c | 29 +++++++------- drivers/video/fbdev/imxfb.c | 32 ++++++---------- drivers/video/fbdev/omap/lcd_ams_delta.c | 8 ++-- include/linux/fb.h | 13 +++++++ include/linux/lcd.h | 29 ++++++++++---- include/video/platform_lcd.h | 3 -- 21 files changed, 182 insertions(+), 156 deletions(-)