| Message ID | 20240811-dt-bindings-serial-peripheral-props-v1-4-1dba258b7492@linaro.org |
|---|---|
| State | Accepted |
| Commit | 38415a81e685eefaf5cd4d045ffc798134071654 |
| Headers | show |
| Series | dt-bindings: add serial-peripheral-props.yaml | expand |
On Sun, Aug 11, 2024 at 8:17 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > The "current-speed" property is not a common property for all GNSS > devices, but only to these connected with serial. Drop the property > from the common GNSS properties schema and instead reference common > serial properties schema (for children of UART controllers). > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/gnss/brcm,bcm4751.yaml b/Documentation/devicetree/bindings/gnss/brcm,bcm4751.yaml index c21549e0fba6..089166089498 100644 --- a/Documentation/devicetree/bindings/gnss/brcm,bcm4751.yaml +++ b/Documentation/devicetree/bindings/gnss/brcm,bcm4751.yaml @@ -18,6 +18,7 @@ description: allOf: - $ref: gnss-common.yaml# + - $ref: /schemas/serial/serial-peripheral-props.yaml# properties: compatible: diff --git a/Documentation/devicetree/bindings/gnss/gnss-common.yaml b/Documentation/devicetree/bindings/gnss/gnss-common.yaml index 963b926e30a7..d4430d2d6855 100644 --- a/Documentation/devicetree/bindings/gnss/gnss-common.yaml +++ b/Documentation/devicetree/bindings/gnss/gnss-common.yaml @@ -35,11 +35,6 @@ properties: GPIO line, this is used. maxItems: 1 - current-speed: - description: The baudrate in bits per second of the device as it comes - online, current active speed. - $ref: /schemas/types.yaml#/definitions/uint32 - additionalProperties: true examples: diff --git a/Documentation/devicetree/bindings/gnss/mediatek.yaml b/Documentation/devicetree/bindings/gnss/mediatek.yaml index c0eb35beb2ef..2b9e5be4ebf3 100644 --- a/Documentation/devicetree/bindings/gnss/mediatek.yaml +++ b/Documentation/devicetree/bindings/gnss/mediatek.yaml @@ -15,6 +15,7 @@ description: allOf: - $ref: gnss-common.yaml# + - $ref: /schemas/serial/serial-peripheral-props.yaml# properties: compatible: diff --git a/Documentation/devicetree/bindings/gnss/sirfstar.yaml b/Documentation/devicetree/bindings/gnss/sirfstar.yaml index 0bbe684d82e1..7e5da89a5ad7 100644 --- a/Documentation/devicetree/bindings/gnss/sirfstar.yaml +++ b/Documentation/devicetree/bindings/gnss/sirfstar.yaml @@ -21,6 +21,7 @@ description: allOf: - $ref: gnss-common.yaml# + - $ref: /schemas/serial/serial-peripheral-props.yaml# properties: compatible: diff --git a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml index cd80668182b6..7d4b6d49e5ee 100644 --- a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml +++ b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml @@ -8,6 +8,7 @@ title: U-blox GNSS Receiver allOf: - $ref: gnss-common.yaml# + - $ref: /schemas/serial/serial-peripheral-props.yaml# maintainers: - Johan Hovold <johan@kernel.org>
The "current-speed" property is not a common property for all GNSS devices, but only to these connected with serial. Drop the property from the common GNSS properties schema and instead reference common serial properties schema (for children of UART controllers). Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- This patch should probably go via Rob's Devicetree tree. It depends on the serial patch adding serial-peripheral-props.yaml. --- Documentation/devicetree/bindings/gnss/brcm,bcm4751.yaml | 1 + Documentation/devicetree/bindings/gnss/gnss-common.yaml | 5 ----- Documentation/devicetree/bindings/gnss/mediatek.yaml | 1 + Documentation/devicetree/bindings/gnss/sirfstar.yaml | 1 + Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml | 1 + 5 files changed, 4 insertions(+), 5 deletions(-)