diff mbox series

[v1,7/7] of/irq: Make use of irq_get_trigger_type()

Message ID 20240902225534.130383-8-vassilisamir@gmail.com
State New
Headers show
Series Use functionality of irq_get_trigger_type() | expand

Commit Message

Vasileios Amoiridis Sept. 2, 2024, 10:55 p.m. UTC 
Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
simple irq_get_trigger_type(irq).

Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
---
 drivers/of/irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Sept. 3, 2024, 7:09 a.m. UTC | #1 
On Tue, Sep 03, 2024 at 12:55:34AM +0200, Vasileios Amoiridis wrote:
> Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> simple irq_get_trigger_type(irq).
> 
> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> ---
>  drivers/of/irq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Rob Herring Sept. 3, 2024, 2:39 p.m. UTC | #2 
On Tue, 03 Sep 2024 00:55:34 +0200, Vasileios Amoiridis wrote:
> Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> simple irq_get_trigger_type(irq).
> 
> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> ---
>  drivers/of/irq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied, thanks!
Andy Shevchenko Sept. 3, 2024, 2:48 p.m. UTC | #3 
On Tue, Sep 03, 2024 at 12:55:34AM +0200, Vasileios Amoiridis wrote:
> Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> simple irq_get_trigger_type(irq).

...

>  		r->start = r->end = irq;
> -		r->flags = IORESOURCE_IRQ | irqd_get_trigger_type(irq_get_irq_data(irq));
> +		r->flags = IORESOURCE_IRQ | irq_get_trigger_type(irq);
>  		r->name = name ? name : of_node_full_name(dev);

As per previous patch this can be utilised to

		*r = DEFINE_RES_IRQ_NAMED(irq, name ?: of_node_full_name(dev));
		r->flags |= irq_get_trigger_type(irq);
Andy Shevchenko Sept. 3, 2024, 2:58 p.m. UTC | #4 
On Tue, Sep 03, 2024 at 09:39:43AM -0500, Rob Herring (Arm) wrote:
> On Tue, 03 Sep 2024 00:55:34 +0200, Vasileios Amoiridis wrote:

...

> Applied, thanks!

It was fast :-)

Vasileios, consider my previous comment as a material for followup,
if Rob likes the idea.
Rob Herring Sept. 3, 2024, 6:59 p.m. UTC | #5 
On Tue, Sep 3, 2024 at 9:59 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Tue, Sep 03, 2024 at 09:39:43AM -0500, Rob Herring (Arm) wrote:
> > On Tue, 03 Sep 2024 00:55:34 +0200, Vasileios Amoiridis wrote:
>
> ...
>
> > Applied, thanks!
>
> It was fast :-)

You're right. I didn't really look at that and was catching up from holidays.

> Vasileios, consider my previous comment as a material for followup,
> if Rob likes the idea.

Yes. I've dropped the patch for now.

Rob
diff mbox series

Patch

diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 36351ad6115e..5d27b20634d3 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -430,7 +430,7 @@  int of_irq_to_resource(struct device_node *dev, int index, struct resource *r)
 					      &name);
 
 		r->start = r->end = irq;
-		r->flags = IORESOURCE_IRQ | irqd_get_trigger_type(irq_get_irq_data(irq));
+		r->flags = IORESOURCE_IRQ | irq_get_trigger_type(irq);
 		r->name = name ? name : of_node_full_name(dev);
 	}