| Message ID | 20240909093101.14113-1-antoniu.miclaus@analog.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v3,1/3] input: touchscreem: ad7877: add match table | expand |
On Mon, Sep 09, 2024 at 12:30:11PM +0300, Antoniu Miclaus wrote: > Add match table for the ad7877 driver and define the compatible string. > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> > --- > no changes in v3. > drivers/input/touchscreen/ad7877.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/input/touchscreen/ad7877.c b/drivers/input/touchscreen/ad7877.c > index a0598e9c7aff..7886454a19c6 100644 > --- a/drivers/input/touchscreen/ad7877.c > +++ b/drivers/input/touchscreen/ad7877.c > @@ -805,10 +805,17 @@ static int ad7877_resume(struct device *dev) > > static DEFINE_SIMPLE_DEV_PM_OPS(ad7877_pm, ad7877_suspend, ad7877_resume); > > +static const struct of_device_id ad7877_of_match[] = { > + { .compatible = "adi,ad7877", }, Bindings are before their users. Best regards, Krzysztof
On Mon, 2024-09-09 at 12:30 +0300, Antoniu Miclaus wrote: > Add match table for the ad7877 driver and define the compatible string. > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> > --- > no changes in v3. > drivers/input/touchscreen/ad7877.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/input/touchscreen/ad7877.c > b/drivers/input/touchscreen/ad7877.c > index a0598e9c7aff..7886454a19c6 100644 > --- a/drivers/input/touchscreen/ad7877.c > +++ b/drivers/input/touchscreen/ad7877.c > @@ -805,10 +805,17 @@ static int ad7877_resume(struct device *dev) > > static DEFINE_SIMPLE_DEV_PM_OPS(ad7877_pm, ad7877_suspend, ad7877_resume); > > +static const struct of_device_id ad7877_of_match[] = { > + { .compatible = "adi,ad7877", }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, ad7877_of_match); > + Just curious, is there any reason for this patch to be split from patch 2? Also, this patch should directly include mod_devicetable.h for 'struct of_device_id' (instead of relying in other headers). - Nuno Sá
diff --git a/drivers/input/touchscreen/ad7877.c b/drivers/input/touchscreen/ad7877.c index a0598e9c7aff..7886454a19c6 100644 --- a/drivers/input/touchscreen/ad7877.c +++ b/drivers/input/touchscreen/ad7877.c @@ -805,10 +805,17 @@ static int ad7877_resume(struct device *dev) static DEFINE_SIMPLE_DEV_PM_OPS(ad7877_pm, ad7877_suspend, ad7877_resume); +static const struct of_device_id ad7877_of_match[] = { + { .compatible = "adi,ad7877", }, + { } +}; +MODULE_DEVICE_TABLE(of, ad7877_of_match); + static struct spi_driver ad7877_driver = { .driver = { .name = "ad7877", .dev_groups = ad7877_groups, + .of_match_table = ad7877_of_match, .pm = pm_sleep_ptr(&ad7877_pm), }, .probe = ad7877_probe,
Add match table for the ad7877 driver and define the compatible string. Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> --- no changes in v3. drivers/input/touchscreen/ad7877.c | 7 +++++++ 1 file changed, 7 insertions(+)