| Message ID | 20240913082937.444367-5-andrei.stefanescu@oss.nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: siul2-s32g2: add initial GPIO driver | expand |
On Fri, Sep 13, 2024 at 11:29:35AM +0300, Andrei Stefanescu wrote:
> Signed-off-by: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com>
For obvious reasons, we can't take patches without any changelog text,
even for simple stuff.
thanks,
greg k-h
Hi Greg, On 13/09/2024 14:05, Greg Kroah-Hartman wrote: > On Fri, Sep 13, 2024 at 11:29:35AM +0300, Andrei Stefanescu wrote: >> Signed-off-by: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com> > > For obvious reasons, we can't take patches without any changelog text, > even for simple stuff. > > thanks, > > greg k-h Thank you! I will fix it in v3. Best regards, Andrei
On 13/09/2024 10:29, Andrei Stefanescu wrote: > Signed-off-by: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com> > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 10430778c998..e23c4369b6e1 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2689,10 +2689,12 @@ ARM/NXP S32G ARCHITECTURE > R: Chester Lin <chester62515@gmail.com> > R: Matthias Brugger <mbrugger@suse.com> > R: Ghennadi Procopciuc <ghennadi.procopciuc@oss.nxp.com> > +R: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com> That's another patch where NXP adds silently themself as platform maintainer without explanation. Although here at least existing maintainers are Cced. This looks like some pattern, so maybe clarifications are needed. You wanted to be maintainer of this driver alone, right? So separate entry. Best regards, Krzysztof
Hi Krzysztof, On 17/09/2024 20:44, Krzysztof Kozlowski wrote: > On 13/09/2024 10:29, Andrei Stefanescu wrote: >> Signed-off-by: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com> >> --- >> MAINTAINERS | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 10430778c998..e23c4369b6e1 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -2689,10 +2689,12 @@ ARM/NXP S32G ARCHITECTURE >> R: Chester Lin <chester62515@gmail.com> >> R: Matthias Brugger <mbrugger@suse.com> >> R: Ghennadi Procopciuc <ghennadi.procopciuc@oss.nxp.com> >> +R: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com> > > That's another patch where NXP adds silently themself as platform > maintainer without explanation. Although here at least existing > maintainers are Cced. > > This looks like some pattern, so maybe clarifications are needed. > > You wanted to be maintainer of this driver alone, right? So separate entry. I would actually want to become a maintainer for the platform. I have already added changes to the pinctrl driver and the s32g2.dtsi/s32g3.dtsi files. I intend to submit more patches to these files and I would like to review changes to them. However, if you or any of the existing maintainers consider that I should only add myself as a maintainer for the SIUL2 GPIO driver, I can fix this in v3. > > Best regards, > Krzysztof > Best regards, Andrei
On 18/09/2024 09:57, Andrei Stefanescu wrote: > Hi Krzysztof, > > On 17/09/2024 20:44, Krzysztof Kozlowski wrote: >> On 13/09/2024 10:29, Andrei Stefanescu wrote: >>> Signed-off-by: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com> >>> --- >>> MAINTAINERS | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index 10430778c998..e23c4369b6e1 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -2689,10 +2689,12 @@ ARM/NXP S32G ARCHITECTURE >>> R: Chester Lin <chester62515@gmail.com> >>> R: Matthias Brugger <mbrugger@suse.com> >>> R: Ghennadi Procopciuc <ghennadi.procopciuc@oss.nxp.com> >>> +R: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com> >> >> That's another patch where NXP adds silently themself as platform >> maintainer without explanation. Although here at least existing >> maintainers are Cced. >> >> This looks like some pattern, so maybe clarifications are needed. >> >> You wanted to be maintainer of this driver alone, right? So separate entry. > > I would actually want to become a maintainer for the platform. I have > already added changes to the pinctrl driver and the s32g2.dtsi/s32g3.dtsi files. > I intend to submit more patches to these files and I would like to review > changes to them. That's fine, so please provide some sort of message in the commit, describing your intention, document the commitment. > > However, if you or any of the existing maintainers consider that I should > only add myself as a maintainer for the SIUL2 GPIO driver, I can fix this in v3. I assume you proposed this after consulting them? It is unusual to add yourself to maintainers without first talking to existing folks... Best regards, Krzysztof
On 18/09/2024 11:13, Krzysztof Kozlowski wrote: > On 18/09/2024 09:57, Andrei Stefanescu wrote: >> Hi Krzysztof, >> >> On 17/09/2024 20:44, Krzysztof Kozlowski wrote: >>> On 13/09/2024 10:29, Andrei Stefanescu wrote: >>>> Signed-off-by: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com> >>>> --- >>>> MAINTAINERS | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>> index 10430778c998..e23c4369b6e1 100644 >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -2689,10 +2689,12 @@ ARM/NXP S32G ARCHITECTURE >>>> R: Chester Lin <chester62515@gmail.com> >>>> R: Matthias Brugger <mbrugger@suse.com> >>>> R: Ghennadi Procopciuc <ghennadi.procopciuc@oss.nxp.com> >>>> +R: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com> >>> >>> That's another patch where NXP adds silently themself as platform >>> maintainer without explanation. Although here at least existing >>> maintainers are Cced. >>> >>> This looks like some pattern, so maybe clarifications are needed. >>> >>> You wanted to be maintainer of this driver alone, right? So separate entry. >> >> I would actually want to become a maintainer for the platform. I have >> already added changes to the pinctrl driver and the s32g2.dtsi/s32g3.dtsi files. >> I intend to submit more patches to these files and I would like to review >> changes to them. > > That's fine, so please provide some sort of message in the commit, > describing your intention, document the commitment. > >> >> However, if you or any of the existing maintainers consider that I should >> only add myself as a maintainer for the SIUL2 GPIO driver, I can fix this in v3. > > I assume you proposed this after consulting them? It is unusual to add > yourself to maintainers without first talking to existing folks... No, unfortunately I haven't consulted with them before proposing it here. I am sorry for that! I will add myself as a reviewer only for the SIUL2 GPIO driver in v3. > > > Best regards, > Krzysztof > Best regards, Andrei
diff --git a/MAINTAINERS b/MAINTAINERS index 10430778c998..e23c4369b6e1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2689,10 +2689,12 @@ ARM/NXP S32G ARCHITECTURE R: Chester Lin <chester62515@gmail.com> R: Matthias Brugger <mbrugger@suse.com> R: Ghennadi Procopciuc <ghennadi.procopciuc@oss.nxp.com> +R: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com> L: NXP S32 Linux Team <s32@nxp.com> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) S: Maintained F: arch/arm64/boot/dts/freescale/s32g*.dts* +F: drivers/gpio/gpio-siul2-s32g2.c F: drivers/pinctrl/nxp/ ARM/Orion SoC/Technologic Systems TS-78xx platform support
Signed-off-by: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com> --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+)