| Message ID | 20240913092430.31569-2-quic_jinlmao@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: sm8450: Add coresight nodes | expand |
On Fri, Sep 13, 2024 at 02:24:28AM -0700, Mao Jinlong wrote: > The device full name is embedded trace extension. There is no good fit > in generic names list for the embedded trace extension. ETE is abbreviation > of embedded trace extension and the number is the CPU number that ete is > associated. > > Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com> > --- > .../bindings/arm/arm,embedded-trace-extension.yaml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml > index f725e6940993..0a88e14e7db3 100644 > --- a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml > +++ b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml > @@ -23,7 +23,7 @@ description: | > > properties: > $nodename: > - pattern: "^ete([0-9a-f]+)$" > + pattern: "^ete-[0-9]+$" -[0-9]+ should be optional, because you could have just one ete, right? ^ete(-[0-9]+)?$ Best regards, Krzysztof
On Fri, Sep 13, 2024 at 02:24:28AM -0700, Mao Jinlong wrote: > The device full name is embedded trace extension. There is no good fit > in generic names list for the embedded trace extension. ETE is abbreviation > of embedded trace extension and the number is the CPU number that ete is > associated. It looks like you've just changed things for all the existing users which would not be okay. However, it looks like there aren't any in tree, so the change is fine, but you need to mention this. > > Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com> > --- > .../bindings/arm/arm,embedded-trace-extension.yaml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml > index f725e6940993..0a88e14e7db3 100644 > --- a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml > +++ b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml > @@ -23,7 +23,7 @@ description: | > > properties: > $nodename: > - pattern: "^ete([0-9a-f]+)$" > + pattern: "^ete-[0-9]+$" > compatible: > items: > - const: arm,embedded-trace-extension > @@ -55,13 +55,13 @@ examples: > > # An ETE node without legacy CoreSight connections > - | > - ete0 { > + ete-0 { > compatible = "arm,embedded-trace-extension"; > cpu = <&cpu_0>; > }; > # An ETE node with legacy CoreSight connections > - | > - ete1 { > + ete-1 { > compatible = "arm,embedded-trace-extension"; > cpu = <&cpu_1>; > > -- > 2.46.0 >
diff --git a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml index f725e6940993..0a88e14e7db3 100644 --- a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml +++ b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml @@ -23,7 +23,7 @@ description: | properties: $nodename: - pattern: "^ete([0-9a-f]+)$" + pattern: "^ete-[0-9]+$" compatible: items: - const: arm,embedded-trace-extension @@ -55,13 +55,13 @@ examples: # An ETE node without legacy CoreSight connections - | - ete0 { + ete-0 { compatible = "arm,embedded-trace-extension"; cpu = <&cpu_0>; }; # An ETE node with legacy CoreSight connections - | - ete1 { + ete-1 { compatible = "arm,embedded-trace-extension"; cpu = <&cpu_1>;
The device full name is embedded trace extension. There is no good fit in generic names list for the embedded trace extension. ETE is abbreviation of embedded trace extension and the number is the CPU number that ete is associated. Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com> --- .../bindings/arm/arm,embedded-trace-extension.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)