| Message ID | 20240930012757.2395-1-zhangjiao2@cmss.chinamobile.com |
|---|---|
| State | Accepted |
| Commit | 7ca93aa9204b706e4afcd4fae0dc8798500598d5 |
| Headers | show |
| Series | [v2] selftests/powerpc: Remove the path after initialization. | expand |
zhangjiao2 <zhangjiao2@cmss.chinamobile.com> writes: > From: zhang jiao <zhangjiao2@cmss.chinamobile.com> > > If there were no anamolies noted, then we can > simply remove the log file and return, .... after the path variable has been initialized. (minor nit) > > Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com> > --- > v1->v2: > Remove the path after initialization. > > tools/testing/selftests/powerpc/mm/tlbie_test.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Thanks for the fix. Looks good to me. Please feel free to add - Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
On Mon, 30 Sep 2024 09:27:57 +0800, zhangjiao2 wrote: > If there were no anamolies noted, then we can > simply remove the log file and return. > > Applied to powerpc/next. [1/1] selftests/powerpc: Remove the path after initialization. https://git.kernel.org/powerpc/c/7ca93aa9204b706e4afcd4fae0dc8798500598d5 cheers
diff --git a/tools/testing/selftests/powerpc/mm/tlbie_test.c b/tools/testing/selftests/powerpc/mm/tlbie_test.c index 48344a74b212..35f0098399cc 100644 --- a/tools/testing/selftests/powerpc/mm/tlbie_test.c +++ b/tools/testing/selftests/powerpc/mm/tlbie_test.c @@ -313,16 +313,16 @@ static inline void end_verification_log(unsigned int tid, unsigned nr_anamolies) fclose(f); - if (nr_anamolies == 0) { - remove(path); - return; - } - sprintf(logfile, logfilename, tid); strcpy(path, logdir); strcat(path, separator); strcat(path, logfile); + if (nr_anamolies == 0) { + remove(path); + return; + } + printf("Thread %02d chunk has %d corrupted words. For details check %s\n", tid, nr_anamolies, path); }