| Message ID | 20240816-sa8775p-mm-v3-v1-0-77d53c3c0cef@quicinc.com |
|---|---|
| Headers | show |
| Series | Add support for SA8775P Multimedia clock controllers | expand |
On Fri, Aug 16, 2024 at 12:01:43PM +0530, Taniya Das wrote: > Add device tree bindings for the video clock controller on Qualcomm > SA8775P platform. > > Signed-off-by: Taniya Das <quic_tdas@quicinc.com> > --- Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
On Fri, Aug 16, 2024 at 12:01:45PM +0530, Taniya Das wrote: > Add device tree bindings for the camera clock controller > on Qualcomm SA8775P platform. > > Signed-off-by: Taniya Das <quic_tdas@quicinc.com> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, Aug 16, 2024 at 12:01:47PM +0530, Taniya Das wrote: > Add device tree bindings for the display clock controllers > on Qualcomm SA8775P platform. > > Signed-off-by: Taniya Das <quic_tdas@quicinc.com> > --- > .../bindings/clock/qcom,sa8775p-dispcc.yaml | 79 ++++++++++++++++++++ > include/dt-bindings/clock/qcom,sa8775p-dispcc.h | 87 ++++++++++++++++++++++ > 2 files changed, 166 insertions(+) > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 18/08/2024 20:02, Krzysztof Kozlowski wrote: > On Fri, Aug 16, 2024 at 12:01:45PM +0530, Taniya Das wrote: >> Add device tree bindings for the camera clock controller >> on Qualcomm SA8775P platform. >> >> Signed-off-by: Taniya Das <quic_tdas@quicinc.com> >> --- > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Un-reviewed. We achieved consensus allowing sa8775p to stay, but now Qualcomm changes point of view and insists on new approach of dropping sa8775p. Therefore this change does not make much sense in the new approach. Best regards, Krzysztof
On 9/6/2024 5:54 PM, Krzysztof Kozlowski wrote: > On 18/08/2024 20:02, Krzysztof Kozlowski wrote: >> On Fri, Aug 16, 2024 at 12:01:45PM +0530, Taniya Das wrote: >>> Add device tree bindings for the camera clock controller >>> on Qualcomm SA8775P platform. >>> >>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com> >>> --- >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Un-reviewed. > > We achieved consensus allowing sa8775p to stay, but now Qualcomm changes > point of view and insists on new approach of dropping sa8775p. Therefore > this change does not make much sense in the new approach. > Krzysztof could you please re-review the patches again? As I understand the that Qualcomm will support both SA8775p and QCS9100 in Kernel. There’s no plan to drop SA8775p support. These two SoCs will keep compatible. > Best regards, > Krzysztof >
On 9/6/2024 5:54 PM, Krzysztof Kozlowski wrote: > On 18/08/2024 20:02, Krzysztof Kozlowski wrote: >> On Fri, Aug 16, 2024 at 12:01:47PM +0530, Taniya Das wrote: >>> Add device tree bindings for the display clock controllers >>> on Qualcomm SA8775P platform. >>> >>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com> >>> --- >>> .../bindings/clock/qcom,sa8775p-dispcc.yaml | 79 ++++++++++++++++++++ >>> include/dt-bindings/clock/qcom,sa8775p-dispcc.h | 87 ++++++++++++++++++++++ >>> 2 files changed, 166 insertions(+) >>> >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Un-reviewed. > > We achieved consensus allowing sa8775p to stay, but now Qualcomm changes > point of view and insists on new approach of dropping sa8775p. Therefore > this change does not make much sense in the new approach. > Krzysztof could you please re-review the patches again? As I understand that Qualcomm will support both SA8775p and QCS9100 in Kernel. There’s no plan to drop SA8775p support. These two SoCs will keep compatible. > Best regards, > Krzysztof >
On 9/13/2024 10:32 AM, Taniya Das wrote: > > > On 9/6/2024 5:54 PM, Krzysztof Kozlowski wrote: >> On 18/08/2024 20:02, Krzysztof Kozlowski wrote: >>> On Fri, Aug 16, 2024 at 12:01:45PM +0530, Taniya Das wrote: >>>> Add device tree bindings for the camera clock controller >>>> on Qualcomm SA8775P platform. >>>> >>>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com> >>>> --- >>> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> Un-reviewed. >> >> We achieved consensus allowing sa8775p to stay, but now Qualcomm changes >> point of view and insists on new approach of dropping sa8775p. Therefore >> this change does not make much sense in the new approach. >> > > Krzysztof could you please re-review the patches again? As I understand > the that Qualcomm will support both SA8775p and QCS9100 in Kernel. > There’s no plan to drop SA8775p support. These two SoCs will keep > compatible. > Krzysztof, Could you please help reviewing the patches again?
On 9/13/2024 10:35 AM, Taniya Das wrote: > > > On 9/6/2024 5:54 PM, Krzysztof Kozlowski wrote: >> On 18/08/2024 20:02, Krzysztof Kozlowski wrote: >>> On Fri, Aug 16, 2024 at 12:01:47PM +0530, Taniya Das wrote: >>>> Add device tree bindings for the display clock controllers >>>> on Qualcomm SA8775P platform. >>>> >>>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com> >>>> --- >>>> .../bindings/clock/qcom,sa8775p-dispcc.yaml | 79 >>>> ++++++++++++++++++++ >>>> include/dt-bindings/clock/qcom,sa8775p-dispcc.h | 87 >>>> ++++++++++++++++++++++ >>>> 2 files changed, 166 insertions(+) >>>> >>> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> Un-reviewed. >> >> We achieved consensus allowing sa8775p to stay, but now Qualcomm changes >> point of view and insists on new approach of dropping sa8775p. Therefore >> this change does not make much sense in the new approach. >> > > Krzysztof could you please re-review the patches again? As I understand > that Qualcomm will support both SA8775p and QCS9100 in Kernel. There’s > no plan to drop SA8775p support. These two SoCs will keep compatible. > Krzysztof, Could you please help reviewing the patches again?
On 04/10/2024 11:31, Taniya Das wrote: > > > On 9/13/2024 10:35 AM, Taniya Das wrote: >> >> >> On 9/6/2024 5:54 PM, Krzysztof Kozlowski wrote: >>> On 18/08/2024 20:02, Krzysztof Kozlowski wrote: >>>> On Fri, Aug 16, 2024 at 12:01:47PM +0530, Taniya Das wrote: >>>>> Add device tree bindings for the display clock controllers >>>>> on Qualcomm SA8775P platform. >>>>> >>>>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com> >>>>> --- >>>>> .../bindings/clock/qcom,sa8775p-dispcc.yaml | 79 >>>>> ++++++++++++++++++++ >>>>> include/dt-bindings/clock/qcom,sa8775p-dispcc.h | 87 >>>>> ++++++++++++++++++++++ >>>>> 2 files changed, 166 insertions(+) >>>>> >>>> >>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> >>> Un-reviewed. >>> >>> We achieved consensus allowing sa8775p to stay, but now Qualcomm changes >>> point of view and insists on new approach of dropping sa8775p. Therefore >>> this change does not make much sense in the new approach. >>> >> >> Krzysztof could you please re-review the patches again? As I understand >> that Qualcomm will support both SA8775p and QCS9100 in Kernel. There’s >> no plan to drop SA8775p support. These two SoCs will keep compatible. >> > Krzysztof, Could you please help reviewing the patches again? They are not in the patchwork anymore, not in my inbox, so I cannot review them. Please resend. That's generic rule - don't ping needlessly multiple times, but resend. Best regards, Krzysztof
Add support for videocc, camcc, dispcc0 and dispcc1 on Qualcomm SA8775P platform. [v4] Changes in [v4] compared to [v3] Videocc: Update the mvs0/mvs1 gdsc to use HW_CTRL_TRIGGER [Konrad and Qualcomm internal discussions] Camcc: Add new clock to the clock tree. Change the patch order for 'Update sleep_clk frequency to 32000 on SA8775P' [Krzysztof] Changes in [v3] compared to [v2]: Update the qcom_cc_really_probe() to use &pdev->dev, for the CAMCC, DISPCC & VIDEOCC drivers. [v2] https://lore.kernel.org/all/20240612-sa8775p-mm-clock-controllers-v1-0-db295a846ee7@quicinc.com/ Changes in [v2] compared to [v1]: [PATCH 1/8]: Updated bindings to reference qcom,gcc.yaml [PATCH 3/8]: Updated bindings to reference qcom,gcc.yaml [PATCH 5/8]: Updated bindings to reference qcom,gcc.yaml [PATCH 7/8]: Split updating sleep_clk frequency to separate patch [PATCH 8/8]: Newly added to update sleep_clk frequency to 32000 These multimedia clock controller and device tree patches are split from the below [v1] series. [v1] https://lore.kernel.org/all/20240531090249.10293-1-quic_tdas@quicinc.com/ Signed-off-by: Taniya Das <quic_tdas@quicinc.com> --- Taniya Das (8): dt-bindings: clock: qcom: Add SA8775P video clock controller clk: qcom: Add support for Video clock controller on SA8775P dt-bindings: clock: qcom: Add SA8775P camera clock controller clk: qcom: Add support for Camera Clock Controller on SA8775P dt-bindings: clock: qcom: Add SA8775P display clock controllers clk: qcom: Add support for Display clock Controllers on SA8775P arm64: dts: qcom: Update sleep_clk frequency to 32000 on SA8775P arm64: dts: qcom: Add support for multimedia clock controllers .../bindings/clock/qcom,sa8775p-camcc.yaml | 62 + .../bindings/clock/qcom,sa8775p-dispcc.yaml | 79 + .../bindings/clock/qcom,sa8775p-videocc.yaml | 62 + arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 2 +- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 57 + drivers/clk/qcom/Kconfig | 31 + drivers/clk/qcom/Makefile | 3 + drivers/clk/qcom/camcc-sa8775p.c | 1868 ++++++++++++++++++++ drivers/clk/qcom/dispcc0-sa8775p.c | 1481 ++++++++++++++++ drivers/clk/qcom/dispcc1-sa8775p.c | 1481 ++++++++++++++++ drivers/clk/qcom/videocc-sa8775p.c | 576 ++++++ include/dt-bindings/clock/qcom,sa8775p-camcc.h | 108 ++ include/dt-bindings/clock/qcom,sa8775p-dispcc.h | 87 + include/dt-bindings/clock/qcom,sa8775p-videocc.h | 47 + 14 files changed, 5943 insertions(+), 1 deletion(-) --- base-commit: 3fe121b622825ff8cc995a1e6b026181c48188db change-id: 20240715-sa8775p-mm-v3-27a7a25e87a2 Best regards,