diff mbox series

[v2] pinctrl: renesas: rzg2l: Fix missing return statement

Message ID 20241003082550.33341-1-biju.das.jz@bp.renesas.com
State Superseded
Headers show
Series [v2] pinctrl: renesas: rzg2l: Fix missing return statement | expand

Commit Message

Biju Das Oct. 3, 2024, 8:25 a.m. UTC
Fix the missing return statement on the error path for
rzg2l_pinctrl_register().

Fixes: f73f63b24491 ("pinctrl: renesas: rzg2l: Use dev_err_probe()")
Reported-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Closes: https://lore.kernel.org/all/OS0PR01MB638837327E5487B71D88A70392712@OS0PR01MB6388.jpnprd01.prod.outlook.com/
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v1->v2:
 * Fixed mail id of Nobuhiro Iwamatsu in Reported-by tag
 * Replaced tab with space charater after return statement
---
 drivers/pinctrl/renesas/pinctrl-rzg2l.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Geert Uytterhoeven Oct. 4, 2024, 7:22 a.m. UTC | #1
On Thu, Oct 3, 2024 at 10:26 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Fix the missing return statement on the error path for
> rzg2l_pinctrl_register().
>
> Fixes: f73f63b24491 ("pinctrl: renesas: rzg2l: Use dev_err_probe()")
> Reported-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> Closes: https://lore.kernel.org/all/OS0PR01MB638837327E5487B71D88A70392712@OS0PR01MB6388.jpnprd01.prod.outlook.com/
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> v1->v2:
>  * Fixed mail id of Nobuhiro Iwamatsu in Reported-by tag
>  * Replaced tab with space charater after return statement

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-pinctrl for v6.13.

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
index 5a403915fed2..3a81837b5e62 100644
--- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
+++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
@@ -2710,7 +2710,7 @@  static int rzg2l_pinctrl_register(struct rzg2l_pinctrl *pctrl)
 
 	ret = pinctrl_enable(pctrl->pctl);
 	if (ret)
-		dev_err_probe(pctrl->dev, ret, "pinctrl enable failed\n");
+		return dev_err_probe(pctrl->dev, ret, "pinctrl enable failed\n");
 
 	ret = rzg2l_gpio_register(pctrl);
 	if (ret)