| Message ID | 20241010061408.1351865-1-karthikeyan@linumiz.com |
|---|---|
| Headers | show |
| Series | Add RV1126 compatible watchdog string | expand |
On 10/9/24 23:14, Karthikeyan Krishnasamy wrote: > This patch is introduces a watchdog compatible string for rockchip's > RV1126. I have already send this patch[1] in the series[2] but somehow > missed watchdog maintainers and list. So resending this patch alone > again from the series[2]. > > Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com> > --- > > - Link to patch: [1]. https://lore.kernel.org/all/20240912142451.2952633-2-karthikeyan@linumiz.com > - Link to series: [2]. https://lore.kernel.org/all/20240912142451.2952633-1-karthikeyan@linumiz.com > > Karthikeyan Krishnasamy (1): > dt-bindings: watchdog: rockchip: Add rockchip,rv1126-wdt string > > Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 1 + > 1 file changed, 1 insertion(+) > I am curious: More and more people send introduction patches for individual patches. I don't see any value in it, the intro patch is not available in patchwork, and thus the context is missing when trying to review the patch from there. This makes reviews much more difficult if one doesn't reply directly to the patch. It doesn't make any sense to me, yet people do it more and more. Where is it suggested to send introduction patches for single-patch series, and what is the rationale ? Thanks, Guenter
On 10/10/24 19:44, Guenter Roeck wrote: > On 10/9/24 23:14, Karthikeyan Krishnasamy wrote: >> This patch is introduces a watchdog compatible string for rockchip's >> RV1126. I have already send this patch[1] in the series[2] but somehow >> missed watchdog maintainers and list. So resending this patch alone >> again from the series[2]. >> >> Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com> >> --- >> >> - Link to patch: [1]. >> https://lore.kernel.org/all/20240912142451.2952633-2-karthikeyan@linumiz.com >> - Link to series: [2]. >> https://lore.kernel.org/all/20240912142451.2952633-1-karthikeyan@linumiz.com >> >> Karthikeyan Krishnasamy (1): >> dt-bindings: watchdog: rockchip: Add rockchip,rv1126-wdt string >> >> Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 1 + >> 1 file changed, 1 insertion(+) >> > > I am curious: More and more people send introduction patches for individual > patches. I don't see any value in it, the intro patch is not available > in patchwork, and thus the context is missing when trying to review the > patch from there. This makes reviews much more difficult if one doesn't > reply directly to the patch. It doesn't make any sense to me, yet people > do it more and more. > > Where is it suggested to send introduction patches for single-patch series, > and what is the rationale ? > > Thanks, > Guenter > Hi, I had missed watchdog maintainers in previous patch series, and received a tag for this patch from the one of the maintainer. So i thought, mention this make sense and added this info in introduction patch. That is the reason. Looks like i made a mistake. Best Regards, Karthikeyan
Hi Guenter, Am Donnerstag, 10. Oktober 2024, 16:14:48 CEST schrieb Guenter Roeck: > On 10/9/24 23:14, Karthikeyan Krishnasamy wrote: > > Add rockchip,rv1126-wdt compatible string. > > > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com> > > Reviewed-by: Guenter Roeck <linux@roeck-us.net> I'll go the same route as before and apply this patch with the rest of the rv1126 changes. Heiko > > --- > > Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml > > index b5a3dc377070..1efefd741c06 100644 > > --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml > > +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml > > @@ -32,6 +32,7 @@ properties: > > - rockchip,rk3576-wdt > > - rockchip,rk3588-wdt > > - rockchip,rv1108-wdt > > + - rockchip,rv1126-wdt > > - const: snps,dw-wdt > > > > reg: > >
On Thu, 10 Oct 2024 11:44:07 +0530, Karthikeyan Krishnasamy wrote: > This patch is introduces a watchdog compatible string for rockchip's > RV1126. I have already send this patch[1] in the series[2] but somehow > missed watchdog maintainers and list. So resending this patch alone > again from the series[2]. > > Applied, thanks! [1/1] dt-bindings: watchdog: rockchip: Add rockchip,rv1126-wdt string commit: 39579b8c8f9e6aba5b299d0309c4a411688b60b9 Best regards,
This patch is introduces a watchdog compatible string for rockchip's RV1126. I have already send this patch[1] in the series[2] but somehow missed watchdog maintainers and list. So resending this patch alone again from the series[2]. Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com> --- - Link to patch: [1]. https://lore.kernel.org/all/20240912142451.2952633-2-karthikeyan@linumiz.com - Link to series: [2]. https://lore.kernel.org/all/20240912142451.2952633-1-karthikeyan@linumiz.com Karthikeyan Krishnasamy (1): dt-bindings: watchdog: rockchip: Add rockchip,rv1126-wdt string Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 1 + 1 file changed, 1 insertion(+)