| Message ID | 20241010-schema-v1-0-98b2d0a2f7a2@quicinc.com |
|---|---|
| Headers | show |
| Series | Add ethernet dts schema for qcs615/qcs8300 | expand |
On 2024-10-10 14:15, Krzysztof Kozlowski wrote: > On Thu, Oct 10, 2024 at 10:03:45AM +0800, Yijie Yang wrote: >> Add compatible for the MAC controller on qcs8300 platforms. >> Since qcs8300 shares the same EMAC as sa8775p, so it fallback to the >> compatible. >> >> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com> >> --- >> Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >> index 8cf29493b822..3ee5367bdde1 100644 >> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >> @@ -23,6 +23,10 @@ properties: >> - enum: >> - qcom,qcs615-ethqos >> - const: qcom,sm8150-ethqos >> + - items: >> + - enum: >> + - qcom,qcs8300-ethqos >> + - const: qcom,sa8775p-ethqos > > This block should go before earlier qcs615, to keep order by fallback. Why this block should positioned before qcs615, given that it comes later in alphabetical order? > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Best regards, > Krzysztof >
On 15/10/2024 08:21, Yijie Yang wrote: > > > On 2024-10-10 14:15, Krzysztof Kozlowski wrote: >> On Thu, Oct 10, 2024 at 10:03:45AM +0800, Yijie Yang wrote: >>> Add compatible for the MAC controller on qcs8300 platforms. >>> Since qcs8300 shares the same EMAC as sa8775p, so it fallback to the >>> compatible. >>> >>> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com> >>> --- >>> Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >>> index 8cf29493b822..3ee5367bdde1 100644 >>> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >>> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >>> @@ -23,6 +23,10 @@ properties: >>> - enum: >>> - qcom,qcs615-ethqos >>> - const: qcom,sm8150-ethqos >>> + - items: >>> + - enum: >>> + - qcom,qcs8300-ethqos >>> + - const: qcom,sa8775p-ethqos >> >> This block should go before earlier qcs615, to keep order by fallback. --------------------------------------------------^^^^^^^^^^^^^^^^^^^^^^^ Here > > Why this block should positioned before qcs615, given that it comes > later in alphabetical order? sa < sm Best regards, Krzysztof
On 2024-10-15 14:27, Krzysztof Kozlowski wrote: > On 15/10/2024 08:21, Yijie Yang wrote: >> >> >> On 2024-10-10 14:15, Krzysztof Kozlowski wrote: >>> On Thu, Oct 10, 2024 at 10:03:45AM +0800, Yijie Yang wrote: >>>> Add compatible for the MAC controller on qcs8300 platforms. >>>> Since qcs8300 shares the same EMAC as sa8775p, so it fallback to the >>>> compatible. >>>> >>>> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com> >>>> --- >>>> Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >>>> index 8cf29493b822..3ee5367bdde1 100644 >>>> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >>>> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >>>> @@ -23,6 +23,10 @@ properties: >>>> - enum: >>>> - qcom,qcs615-ethqos >>>> - const: qcom,sm8150-ethqos >>>> + - items: >>>> + - enum: >>>> + - qcom,qcs8300-ethqos >>>> + - const: qcom,sa8775p-ethqos >>> >>> This block should go before earlier qcs615, to keep order by fallback. > > --------------------------------------------------^^^^^^^^^^^^^^^^^^^^^^^ > > Here > >> >> Why this block should positioned before qcs615, given that it comes >> later in alphabetical order? > > sa < sm Understood, thanks. > > Best regards, > Krzysztof >
Document the ethernet and SerDes compatible for qcs8300. This platform shares the same EMAC and SerDes as sa8775p, so the compatible fallback to it. Document the ethernet compatible for qcs615. This platform shares the same EMAC as sm8150, so the compatible fallback to it. Document the compatible for revision 2 of the qcs8300-ride board. Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com> --- This patch series depends on below patch series: https://lore.kernel.org/all/20240925-qcs8300_initial_dtsi-v2-0-494c40fa2a42@quicinc.com/ https://lore.kernel.org/all/20240926-add_initial_support_for_qcs615-v3-0-e37617e91c62@quicinc.com/ --- Yijie Yang (3): dt-bindings: net: qcom,ethqos: add description for qcs615 dt-bindings: phy: describe the Qualcomm SGMII PHY dt-bindings: net: qcom,ethqos: add description for qcs8300 .../devicetree/bindings/net/qcom,ethqos.yaml | 19 ++++++++++++++----- .../bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml | 7 ++++++- 2 files changed, 20 insertions(+), 6 deletions(-) --- base-commit: 70c6ab36f8b7756260369952a3c13b3362034bd1 change-id: 20241010-schema-50b0b777c28b Best regards,