| Message ID | 20241025164732.73121-1-andrew.goodbody@linaro.org |
|---|---|
| State | Accepted |
| Commit | 467a84e0127ca6b8ca285c7a0b1ff625b6b2ca4b |
| Headers | show |
| Series | test: efi_loader: Fix dependency for http test | expand |
On Fri, Oct 25, 2024 at 05:47:32PM +0100, Andrew Goodbody wrote: > The config setting CMD_BOOTEFI_HELLO_COMPILE was removed in favour > of BOOTEFI_HELLO_COMPILE but the dependency for > test_efi_helloworld_net_http was not updated and so is now incorrect > preventing the test from ever running. Fix it. > > Fixes: 6fe80876dcc7 ("efi_loader: Rename and move CMD_BOOTEFI_HELLO_COMPILE") > Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org> Reviewed-by: Tom Rini <trini@konsulko.com> And I see arch/x86/lib/Makefile has an invalid reference still now too, can you please fix that as a follow up? Thanks.
Thanks, Andrew On Fri, 25 Oct 2024 at 19:47, Andrew Goodbody <andrew.goodbody@linaro.org> wrote: > > The config setting CMD_BOOTEFI_HELLO_COMPILE was removed in favour > of BOOTEFI_HELLO_COMPILE but the dependency for > test_efi_helloworld_net_http was not updated and so is now incorrect > preventing the test from ever running. Fix it. > > Fixes: 6fe80876dcc7 ("efi_loader: Rename and move CMD_BOOTEFI_HELLO_COMPILE") > Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org> > --- > > test/py/tests/test_efi_loader.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/py/tests/test_efi_loader.py b/test/py/tests/test_efi_loader.py > index 707b2c9e79..33434935fe 100644 > --- a/test/py/tests/test_efi_loader.py > +++ b/test/py/tests/test_efi_loader.py > @@ -182,7 +182,7 @@ def test_efi_helloworld_net_tftp(u_boot_console): > do_test_efi_helloworld_net(u_boot_console, PROTO_TFTP); > > @pytest.mark.buildconfigspec('of_control') > -@pytest.mark.buildconfigspec('cmd_bootefi_hello_compile') > +@pytest.mark.buildconfigspec('bootefi_hello_compile') > @pytest.mark.buildconfigspec('cmd_wget') > def test_efi_helloworld_net_http(u_boot_console): > """Run the helloworld.efi binary via HTTP. > -- > 2.39.5 > Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
On 25/10/2024 17:56, Tom Rini wrote: > On Fri, Oct 25, 2024 at 05:47:32PM +0100, Andrew Goodbody wrote: > >> The config setting CMD_BOOTEFI_HELLO_COMPILE was removed in favour >> of BOOTEFI_HELLO_COMPILE but the dependency for >> test_efi_helloworld_net_http was not updated and so is now incorrect >> preventing the test from ever running. Fix it. >> >> Fixes: 6fe80876dcc7 ("efi_loader: Rename and move CMD_BOOTEFI_HELLO_COMPILE") >> Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org> > > Reviewed-by: Tom Rini <trini@konsulko.com> > > And I see arch/x86/lib/Makefile has an invalid reference still now too, > can you please fix that as a follow up? Thanks. Patch sent. Andrew
On Fri, 25 Oct 2024 17:47:32 +0100, Andrew Goodbody wrote: > The config setting CMD_BOOTEFI_HELLO_COMPILE was removed in favour > of BOOTEFI_HELLO_COMPILE but the dependency for > test_efi_helloworld_net_http was not updated and so is now incorrect > preventing the test from ever running. Fix it. > > Applied to u-boot/master, thanks!
diff --git a/test/py/tests/test_efi_loader.py b/test/py/tests/test_efi_loader.py index 707b2c9e79..33434935fe 100644 --- a/test/py/tests/test_efi_loader.py +++ b/test/py/tests/test_efi_loader.py @@ -182,7 +182,7 @@ def test_efi_helloworld_net_tftp(u_boot_console): do_test_efi_helloworld_net(u_boot_console, PROTO_TFTP); @pytest.mark.buildconfigspec('of_control') -@pytest.mark.buildconfigspec('cmd_bootefi_hello_compile') +@pytest.mark.buildconfigspec('bootefi_hello_compile') @pytest.mark.buildconfigspec('cmd_wget') def test_efi_helloworld_net_http(u_boot_console): """Run the helloworld.efi binary via HTTP.
The config setting CMD_BOOTEFI_HELLO_COMPILE was removed in favour of BOOTEFI_HELLO_COMPILE but the dependency for test_efi_helloworld_net_http was not updated and so is now incorrect preventing the test from ever running. Fix it. Fixes: 6fe80876dcc7 ("efi_loader: Rename and move CMD_BOOTEFI_HELLO_COMPILE") Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org> --- test/py/tests/test_efi_loader.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)