| Message ID | 20241025145959.185373-2-pstanner@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Remove pcim_iomap_regions_request_all() | expand |
On Fri, 25 Oct 2024, Philipp Stanner wrote: > In order to remove the deprecated function > pcim_iomap_regions_request_all(), a few drivers need an interface to > request all BARs a PCI-Device offers. Hi Philipp, I don't know why you put that dash there, it looks a bit odd. Other than that, Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> -- i. > Make pcim_request_all_regions() a public interface. > > Signed-off-by: Philipp Stanner <pstanner@redhat.com> > Reviewed-by: Damien Le Moal <dlemoal@kernel.org> > --- > drivers/pci/devres.c | 3 ++- > include/linux/pci.h | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/devres.c b/drivers/pci/devres.c > index b133967faef8..2a64da5c91fb 100644 > --- a/drivers/pci/devres.c > +++ b/drivers/pci/devres.c > @@ -939,7 +939,7 @@ static void pcim_release_all_regions(struct pci_dev *pdev) > * desired, release individual regions with pcim_release_region() or all of > * them at once with pcim_release_all_regions(). > */ > -static int pcim_request_all_regions(struct pci_dev *pdev, const char *name) > +int pcim_request_all_regions(struct pci_dev *pdev, const char *name) > { > int ret; > int bar; > @@ -957,6 +957,7 @@ static int pcim_request_all_regions(struct pci_dev *pdev, const char *name) > > return ret; > } > +EXPORT_SYMBOL(pcim_request_all_regions); > > /** > * pcim_iomap_regions_request_all - Request all BARs and iomap specified ones > diff --git a/include/linux/pci.h b/include/linux/pci.h > index 573b4c4c2be6..3b151c8331e5 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -2293,6 +2293,7 @@ static inline void pci_fixup_device(enum pci_fixup_pass pass, > struct pci_dev *dev) { } > #endif > > +int pcim_request_all_regions(struct pci_dev *pdev, const char *name); > void __iomem *pcim_iomap(struct pci_dev *pdev, int bar, unsigned long maxlen); > void __iomem *pcim_iomap_region(struct pci_dev *pdev, int bar, > const char *name); >
diff --git a/drivers/pci/devres.c b/drivers/pci/devres.c index b133967faef8..2a64da5c91fb 100644 --- a/drivers/pci/devres.c +++ b/drivers/pci/devres.c @@ -939,7 +939,7 @@ static void pcim_release_all_regions(struct pci_dev *pdev) * desired, release individual regions with pcim_release_region() or all of * them at once with pcim_release_all_regions(). */ -static int pcim_request_all_regions(struct pci_dev *pdev, const char *name) +int pcim_request_all_regions(struct pci_dev *pdev, const char *name) { int ret; int bar; @@ -957,6 +957,7 @@ static int pcim_request_all_regions(struct pci_dev *pdev, const char *name) return ret; } +EXPORT_SYMBOL(pcim_request_all_regions); /** * pcim_iomap_regions_request_all - Request all BARs and iomap specified ones diff --git a/include/linux/pci.h b/include/linux/pci.h index 573b4c4c2be6..3b151c8331e5 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -2293,6 +2293,7 @@ static inline void pci_fixup_device(enum pci_fixup_pass pass, struct pci_dev *dev) { } #endif +int pcim_request_all_regions(struct pci_dev *pdev, const char *name); void __iomem *pcim_iomap(struct pci_dev *pdev, int bar, unsigned long maxlen); void __iomem *pcim_iomap_region(struct pci_dev *pdev, int bar, const char *name);