diff mbox series

efi_loader: Mark static functions in smbiosdump

Message ID 20241026075745.117832-1-ilias.apalodimas@linaro.org
State Accepted
Commit 6507ec20ba543103875a431b0897ea6cb9b1aaf5
Headers show
Series efi_loader: Mark static functions in smbiosdump | expand

Commit Message

Ilias Apalodimas Oct. 26, 2024, 7:57 a.m. UTC
Mark functions that are only used locally as static and
quiesce W=1 warnings

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---
 lib/efi_loader/smbiosdump.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Heinrich Schuchardt Oct. 28, 2024, 6:13 a.m. UTC | #1
On 10/26/24 09:57, Ilias Apalodimas wrote:
> Mark functions that are only used locally as static and
> quiesce W=1 warnings
>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> ---
>   lib/efi_loader/smbiosdump.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/efi_loader/smbiosdump.c b/lib/efi_loader/smbiosdump.c
> index 2f0b91a353d1..d7f2ba30a954 100644
> --- a/lib/efi_loader/smbiosdump.c
> +++ b/lib/efi_loader/smbiosdump.c
> @@ -289,7 +289,7 @@ static void *get_config_table(const efi_guid_t *guid)
>    * @len:	length of buffer
>    * Return:	checksum
>    */
> -u8 checksum(void *buf, int len)
> +static u8 checksum(void *buf, int len)
>   {
>   	u8 ret = 0;
>
> @@ -304,7 +304,7 @@ u8 checksum(void *buf, int len)
>    *
>    * Return:	status code
>    */
> -efi_status_t do_check(void)
> +static efi_status_t do_check(void)
>   {
>   	struct smbios3_entry *smbios3_anchor;
>   	void *table, *table_end;
> @@ -401,7 +401,7 @@ efi_status_t do_check(void)
>    * @buf:	buffer to write
>    * @size:	size of the buffer
>    */
> -efi_status_t save_file(u16 *filename, void *buf, efi_uintn_t size)
> +static efi_status_t save_file(u16 *filename, void *buf, efi_uintn_t size)
>   {
>   	efi_uintn_t ret;
>   	struct efi_simple_file_system_protocol *file_system;

Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
diff mbox series

Patch

diff --git a/lib/efi_loader/smbiosdump.c b/lib/efi_loader/smbiosdump.c
index 2f0b91a353d1..d7f2ba30a954 100644
--- a/lib/efi_loader/smbiosdump.c
+++ b/lib/efi_loader/smbiosdump.c
@@ -289,7 +289,7 @@  static void *get_config_table(const efi_guid_t *guid)
  * @len:	length of buffer
  * Return:	checksum
  */
-u8 checksum(void *buf, int len)
+static u8 checksum(void *buf, int len)
 {
 	u8 ret = 0;
 
@@ -304,7 +304,7 @@  u8 checksum(void *buf, int len)
  *
  * Return:	status code
  */
-efi_status_t do_check(void)
+static efi_status_t do_check(void)
 {
 	struct smbios3_entry *smbios3_anchor;
 	void *table, *table_end;
@@ -401,7 +401,7 @@  efi_status_t do_check(void)
  * @buf:	buffer to write
  * @size:	size of the buffer
  */
-efi_status_t save_file(u16 *filename, void *buf, efi_uintn_t size)
+static efi_status_t save_file(u16 *filename, void *buf, efi_uintn_t size)
 {
 	efi_uintn_t ret;
 	struct efi_simple_file_system_protocol *file_system;