| Message ID | 20241019-qcs615-mm-clockcontroller-v1-0-4cfb96d779ae@quicinc.com |
|---|---|
| Headers | show |
| Series | Add support for videocc, camcc, dispcc and gpucc on Qualcomm QCS615 platform | expand |
2024. 10. 18. 21:15 keltezéssel, Taniya Das írta: > The alpha_en_mask and alpha_mode_mask must be applied within the > clk_alpha_pll_configure() function to ensure proper configuration of > the alpha mode of the PLL. > > Fixes: c45ae598fc16 ("clk: qcom: support for alpha mode configuration") > Signed-off-by: Taniya Das <quic_tdas@quicinc.com> > --- > drivers/clk/qcom/clk-alpha-pll.c | 2 ++ > 1 file changed, 2 insertions(+) > Tested-by: Gabor Juhos <j4g8y7@gmail.com>
On Sat, Oct 19, 2024 at 12:45:39AM +0530, Taniya Das wrote: > Add DT bindings for the Camera clock on QCS615 platforms. Add the > relevant DT include definitions as well. > > Signed-off-by: Taniya Das <quic_tdas@quicinc.com> > --- > .../bindings/clock/qcom,qcs615-camcc.yaml | 60 +++++++++++ > include/dt-bindings/clock/qcom,qcs615-camcc.h | 110 +++++++++++++++++++++ > 2 files changed, 170 insertions(+) > That's some duplicate posting. I already reviewed some of the patches here, so please implement that feedback. Best regards, Krzysztof
On 10/22/2024 11:31 AM, Krzysztof Kozlowski wrote: >> Add DT bindings for the Camera clock on QCS615 platforms. Add the >> relevant DT include definitions as well. >> >> Signed-off-by: Taniya Das<quic_tdas@quicinc.com> >> --- >> .../bindings/clock/qcom,qcs615-camcc.yaml | 60 +++++++++++ >> include/dt-bindings/clock/qcom,qcs615-camcc.h | 110 +++++++++++++++++++++ >> 2 files changed, 170 insertions(+) >> > That's some duplicate posting. I already reviewed some of the patches > here, so please implement that feedback. I will implement the fixes in the next patch.
On 10/19/2024 1:52 AM, Dmitry Baryshkov wrote: >> +static struct gdsc ife_1_gdsc = { >> + .gdscr = 0xa004, >> + .en_rest_wait_val = 0x2, >> + .en_few_wait_val = 0x2, >> + .clk_dis_wait_val = 0xf, >> + .pd = { >> + .name = "ife_1_gdsc", >> + }, >> + .pwrsts = PWRSTS_OFF_ON, >> + .flags = POLL_CFG_GDSCR, >> +}; > Shouldn't IFE GDSCs have titan_top as a parent? Yes, I will fix in the next patch.
On 10/19/2024 2:02 AM, Dmitry Baryshkov wrote: >> Enable the QCS615 display, video, camera and graphics clock >> controller for their respective functionalities on Qualcomm QCS615. > .... used on Qualcomm ABCDEF board, please. Yes, I missed that, will fix it in the next patch. >
Add support for multimedia clock controllers on Qualcomm QCS615 platform. Update the defconfig to enable these clock controllers. Global clock controller support https://lore.kernel.org/all/20240920-qcs615-clock-driver-v2-0-2f6de44eb2aa@quicinc.com/ Signed-off-by: Taniya Das <quic_tdas@quicinc.com> --- Taniya Das (11): clk: qcom: Update the support for alpha mode configuration clk: qcom: clk-alpha-pll: Add support for dynamic update for slewing PLLs dt-bindings: clock: Add Qualcomm QCS615 Camera clock controller clk: qcom: camcc-qcs615: Add QCS615 camera clock controller driver dt-bindings: clock: Add Qualcomm QCS615 Display clock controller clk: qcom: dispcc-qcs615: Add QCS615 display clock controller driver dt-bindings: clock: Add Qualcomm QCS615 Graphics clock controller clk: qcom: gpucc-qcs615: Add QCS615 graphics clock controller driver dt-bindings: clock: Add Qualcomm QCS615 Video clock controller clk: qcom: videocc-qcs615: Add QCS615 video clock controller driver arm64: defconfig: Enable QCS615 clock controllers .../bindings/clock/qcom,qcs615-camcc.yaml | 60 + .../bindings/clock/qcom,qcs615-dispcc.yaml | 73 + .../bindings/clock/qcom,qcs615-gpucc.yaml | 66 + .../bindings/clock/qcom,qcs615-videocc.yaml | 64 + arch/arm64/configs/defconfig | 4 + drivers/clk/qcom/Kconfig | 35 + drivers/clk/qcom/Makefile | 4 + drivers/clk/qcom/camcc-qcs615.c | 1588 ++++++++++++++++++++ drivers/clk/qcom/clk-alpha-pll.c | 174 +++ drivers/clk/qcom/clk-alpha-pll.h | 1 + drivers/clk/qcom/dispcc-qcs615.c | 786 ++++++++++ drivers/clk/qcom/gpucc-qcs615.c | 525 +++++++ drivers/clk/qcom/videocc-qcs615.c | 332 ++++ include/dt-bindings/clock/qcom,qcs615-camcc.h | 110 ++ include/dt-bindings/clock/qcom,qcs615-dispcc.h | 52 + include/dt-bindings/clock/qcom,qcs615-gpucc.h | 39 + include/dt-bindings/clock/qcom,qcs615-videocc.h | 30 + 17 files changed, 3943 insertions(+) --- base-commit: 15e7d45e786a62a211dd0098fee7c57f84f8c681 change-id: 20241016-qcs615-mm-clockcontroller-cff9aea7a006 Best regards,