diff mbox series

[v2,1/1] dt-bindings: watchdog: fsl-imx-wdt: Add missing 'big-endian' property

Message ID 20241007212434.895521-1-Frank.Li@nxp.com
State New
Headers show
Series [v2,1/1] dt-bindings: watchdog: fsl-imx-wdt: Add missing 'big-endian' property | expand

Commit Message

Frank Li Oct. 7, 2024, 9:24 p.m. UTC 
From: Animesh Agarwal <animeshagarwal28@gmail.com>

Add missing big-endian property in watchdog/fsl-imx-wdt.yaml schema. Only
allow big-endian property for ls1012a and ls1043a.

Fix dtbs_check errors.
arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dtb: watchdog@2ad0000:
    Unevaluated properties are not allowed ('big-endian' was unexpected)

Cc: Daniel Baluta <daniel.baluta@nxp.com>
Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---

Change from v1 to v2:
  only allow big endian for layerscape platform.

previous post at:
https://lore.kernel.org/imx/20240806103819.10890-1-animeshagarwal28@gmail.com/

check spec, and dump watch dog reset value
at ls1043a platform.

0x02A80000:  00 30 00 00 00 10 00 04 00 01 00 00 00 00 00 0

It is big-endian. imx2_wdt.c use regmap which call regmap_get_val_endian()
to handle endian.

So this change is corret.

big-endian for wdt is necessary
---
 .../devicetree/bindings/watchdog/fsl-imx-wdt.yaml  | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Krzysztof Kozlowski Oct. 8, 2024, 1:34 p.m. UTC | #1 
On Mon, Oct 07, 2024 at 05:24:33PM -0400, Frank Li wrote:
> From: Animesh Agarwal <animeshagarwal28@gmail.com>
> 
> Add missing big-endian property in watchdog/fsl-imx-wdt.yaml schema. Only
> allow big-endian property for ls1012a and ls1043a.
> 
> Fix dtbs_check errors.
> arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dtb: watchdog@2ad0000:
>     Unevaluated properties are not allowed ('big-endian' was unexpected)
> 
> Cc: Daniel Baluta <daniel.baluta@nxp.com>
> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Frank Li Oct. 31, 2024, 7:02 p.m. UTC | #2 
On Mon, Oct 07, 2024 at 05:24:33PM -0400, Frank Li wrote:
> From: Animesh Agarwal <animeshagarwal28@gmail.com>
>
> Add missing big-endian property in watchdog/fsl-imx-wdt.yaml schema. Only
> allow big-endian property for ls1012a and ls1043a.
>
> Fix dtbs_check errors.
> arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dtb: watchdog@2ad0000:
>     Unevaluated properties are not allowed ('big-endian' was unexpected)
>
> Cc: Daniel Baluta <daniel.baluta@nxp.com>
> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---

Wim Van Sebroeck:

	Any update this patch? Kyzy already acked.


Frank


>
> Change from v1 to v2:
>   only allow big endian for layerscape platform.
>
> previous post at:
> https://lore.kernel.org/imx/20240806103819.10890-1-animeshagarwal28@gmail.com/
>
> check spec, and dump watch dog reset value
> at ls1043a platform.
>
> 0x02A80000:  00 30 00 00 00 10 00 04 00 01 00 00 00 00 00 0
>
> It is big-endian. imx2_wdt.c use regmap which call regmap_get_val_endian()
> to handle endian.
>
> So this change is corret.
>
> big-endian for wdt is necessary
> ---
>  .../devicetree/bindings/watchdog/fsl-imx-wdt.yaml  | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> index 36b836d0620c9..0da953cb71272 100644
> --- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> @@ -48,6 +48,8 @@ properties:
>    clocks:
>      maxItems: 1
>
> +  big-endian: true
> +
>    fsl,ext-reset-output:
>      $ref: /schemas/types.yaml#/definitions/flag
>      description: |
> @@ -93,6 +95,18 @@ allOf:
>        properties:
>          fsl,suspend-in-wait: false
>
> +  - if:
> +      not:
> +        properties:
> +          compatible:
> +            contains:
> +              enum:
> +                - fsl,ls1012a-wdt
> +                - fsl,ls1043a-wdt
> +    then:
> +      properties:
> +        big-endian: false
> +
>  unevaluatedProperties: false
>
>  examples:
> --
> 2.34.1
>
Wim Van Sebroeck Nov. 5, 2024, 8:32 a.m. UTC | #3 
Hi Frank,

> On Mon, Oct 07, 2024 at 05:24:33PM -0400, Frank Li wrote:
> > From: Animesh Agarwal <animeshagarwal28@gmail.com>
> >
> > Add missing big-endian property in watchdog/fsl-imx-wdt.yaml schema. Only
> > allow big-endian property for ls1012a and ls1043a.
> >
> > Fix dtbs_check errors.
> > arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dtb: watchdog@2ad0000:
> >     Unevaluated properties are not allowed ('big-endian' was unexpected)
> >
> > Cc: Daniel Baluta <daniel.baluta@nxp.com>
> > Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> 
> Wim Van Sebroeck:
> 
> 	Any update this patch? Kyzy already acked.
> 

Acked-by: Wim Van Sebroeck <wim@linux-watchdog.org>

Via which tree will this go upsteam?

Kind regards,
Wim.

> 
> Frank
> 
> 
> >
> > Change from v1 to v2:
> >   only allow big endian for layerscape platform.
> >
> > previous post at:
> > https://lore.kernel.org/imx/20240806103819.10890-1-animeshagarwal28@gmail.com/
> >
> > check spec, and dump watch dog reset value
> > at ls1043a platform.
> >
> > 0x02A80000:  00 30 00 00 00 10 00 04 00 01 00 00 00 00 00 0
> >
> > It is big-endian. imx2_wdt.c use regmap which call regmap_get_val_endian()
> > to handle endian.
> >
> > So this change is corret.
> >
> > big-endian for wdt is necessary
> > ---
> >  .../devicetree/bindings/watchdog/fsl-imx-wdt.yaml  | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> > index 36b836d0620c9..0da953cb71272 100644
> > --- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> > @@ -48,6 +48,8 @@ properties:
> >    clocks:
> >      maxItems: 1
> >
> > +  big-endian: true
> > +
> >    fsl,ext-reset-output:
> >      $ref: /schemas/types.yaml#/definitions/flag
> >      description: |
> > @@ -93,6 +95,18 @@ allOf:
> >        properties:
> >          fsl,suspend-in-wait: false
> >
> > +  - if:
> > +      not:
> > +        properties:
> > +          compatible:
> > +            contains:
> > +              enum:
> > +                - fsl,ls1012a-wdt
> > +                - fsl,ls1043a-wdt
> > +    then:
> > +      properties:
> > +        big-endian: false
> > +
> >  unevaluatedProperties: false
> >
> >  examples:
> > --
> > 2.34.1
> >
Rob Herring (Arm) Nov. 5, 2024, 1:02 p.m. UTC | #4 
On Tue, Nov 5, 2024 at 3:00 AM Wim Van Sebroeck <wim@linux-watchdog.org> wrote:
>
> Hi Frank,
>
> > On Mon, Oct 07, 2024 at 05:24:33PM -0400, Frank Li wrote:
> > > From: Animesh Agarwal <animeshagarwal28@gmail.com>
> > >
> > > Add missing big-endian property in watchdog/fsl-imx-wdt.yaml schema. Only
> > > allow big-endian property for ls1012a and ls1043a.
> > >
> > > Fix dtbs_check errors.
> > > arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dtb: watchdog@2ad0000:
> > >     Unevaluated properties are not allowed ('big-endian' was unexpected)
> > >
> > > Cc: Daniel Baluta <daniel.baluta@nxp.com>
> > > Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> >
> > Wim Van Sebroeck:
> >
> >       Any update this patch? Kyzy already acked.
> >
>
> Acked-by: Wim Van Sebroeck <wim@linux-watchdog.org>
>
> Via which tree will this go upsteam?

Your tree.

DT bindings go in via $subsystem tree. I only take DT bindings if they
don't get picked up by the subsystem maintainer.

Rob
Wim Van Sebroeck Nov. 6, 2024, 8:01 a.m. UTC | #5 
Hi Frank, Rob,

> On Tue, Nov 5, 2024 at 3:00 AM Wim Van Sebroeck <wim@linux-watchdog.org> wrote:
> >
> > Hi Frank,
> >
> > > On Mon, Oct 07, 2024 at 05:24:33PM -0400, Frank Li wrote:
> > > > From: Animesh Agarwal <animeshagarwal28@gmail.com>
> > > >
> > > > Add missing big-endian property in watchdog/fsl-imx-wdt.yaml schema. Only
> > > > allow big-endian property for ls1012a and ls1043a.
> > > >
> > > > Fix dtbs_check errors.
> > > > arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dtb: watchdog@2ad0000:
> > > >     Unevaluated properties are not allowed ('big-endian' was unexpected)
> > > >
> > > > Cc: Daniel Baluta <daniel.baluta@nxp.com>
> > > > Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > > ---
> > >
> > > Wim Van Sebroeck:
> > >
> > >       Any update this patch? Kyzy already acked.
> > >
> >
> > Acked-by: Wim Van Sebroeck <wim@linux-watchdog.org>
> >
> > Via which tree will this go upsteam?
> 
> Your tree.
> 
> DT bindings go in via $subsystem tree. I only take DT bindings if they
> don't get picked up by the subsystem maintainer.
> 
> Rob

Added.

Kind regards,
Wim.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
index 36b836d0620c9..0da953cb71272 100644
--- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
@@ -48,6 +48,8 @@  properties:
   clocks:
     maxItems: 1
 
+  big-endian: true
+
   fsl,ext-reset-output:
     $ref: /schemas/types.yaml#/definitions/flag
     description: |
@@ -93,6 +95,18 @@  allOf:
       properties:
         fsl,suspend-in-wait: false
 
+  - if:
+      not:
+        properties:
+          compatible:
+            contains:
+              enum:
+                - fsl,ls1012a-wdt
+                - fsl,ls1043a-wdt
+    then:
+      properties:
+        big-endian: false
+
 unevaluatedProperties: false
 
 examples: