| Message ID | 20241107073332.5483-1-liujing@cmss.chinamobile.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | tty: hvc: Fix incorrect formatted output | expand |
On 07. 11. 24, 8:33, liujing wrote: > The termno parameter is defined as an unsigned int > in hvc_opal_probe(), So the output format should be %u instead of %d. > > Signed-off-by: liujing <liujing@cmss.chinamobile.com> > > --- > v1 -> V2: Modified the description of commit. > > diff --git a/drivers/tty/hvc/hvc_opal.c b/drivers/tty/hvc/hvc_opal.c > index 095c33ad10f8..1d2e7f2ce088 100644 > --- a/drivers/tty/hvc/hvc_opal.c > +++ b/drivers/tty/hvc/hvc_opal.c > @@ -199,7 +199,7 @@ static int hvc_opal_probe(struct platform_device *dev) > /* Instanciate now to establish a mapping index==vtermno */ > hvc_instantiate(termno, termno, ops); > } else { > - pr_err("hvc_opal: Device %pOF has duplicate terminal number #%d\n", > + pr_err("hvc_opal: Device %pOF has duplicate terminal number #%u\n", Please re-read my _whole_ previous e-mail.
diff --git a/drivers/tty/hvc/hvc_opal.c b/drivers/tty/hvc/hvc_opal.c index 095c33ad10f8..1d2e7f2ce088 100644 --- a/drivers/tty/hvc/hvc_opal.c +++ b/drivers/tty/hvc/hvc_opal.c @@ -199,7 +199,7 @@ static int hvc_opal_probe(struct platform_device *dev) /* Instanciate now to establish a mapping index==vtermno */ hvc_instantiate(termno, termno, ops); } else { - pr_err("hvc_opal: Device %pOF has duplicate terminal number #%d\n", + pr_err("hvc_opal: Device %pOF has duplicate terminal number #%u\n", dev->dev.of_node, termno); return -ENXIO; }
The termno parameter is defined as an unsigned int in hvc_opal_probe(), So the output format should be %u instead of %d. Signed-off-by: liujing <liujing@cmss.chinamobile.com> --- v1 -> V2: Modified the description of commit.