| Message ID | 20241121172737.255-2-quic_rlaggysh@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | Drop QPIC related interconnect and BCM nodes on | expand |
On 21/11/2024 18:27, Raviteja Laggyshetty wrote: > QPIC resources are modeled as clks, therefore remove corresponding s/clks/clocks/ > defines from the binding as they're unused. As clocks where? Details are needed since you are affecting the ABI. > > Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@quicinc.com> > --- > include/dt-bindings/interconnect/qcom,sdx75.h | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > This does not build. ../drivers/interconnect/qcom/sdx75.c:906:10: error: ‘MASTER_QPIC_CORE’ undeclared here (not in a function); did you mean ‘MASTER_QPIC’? Best regards, Krzysztof
On Thu, Nov 21, 2024 at 05:27:36PM +0000, Raviteja Laggyshetty wrote: > QPIC resources are modeled as clks, therefore remove corresponding > defines from the binding as they're unused. > > Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@quicinc.com> > --- > include/dt-bindings/interconnect/qcom,sdx75.h | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/include/dt-bindings/interconnect/qcom,sdx75.h b/include/dt-bindings/interconnect/qcom,sdx75.h > index e903f5f3dd8f..0746f1704ec0 100644 > --- a/include/dt-bindings/interconnect/qcom,sdx75.h > +++ b/include/dt-bindings/interconnect/qcom,sdx75.h > @@ -6,10 +6,8 @@ > #ifndef __DT_BINDINGS_INTERCONNECT_QCOM_SDX75_H > #define __DT_BINDINGS_INTERCONNECT_QCOM_SDX75_H > > -#define MASTER_QPIC_CORE 0 > -#define MASTER_QUP_CORE_0 1 > -#define SLAVE_QPIC_CORE 2 > -#define SLAVE_QUP_CORE_0 3 > +#define MASTER_QUP_CORE_0 0 > +#define SLAVE_QUP_CORE_0 1 This changes the ABI of the driver. If this intended, please provide a reason for that. Otherwise you can not change the values for the existing defines. > > #define MASTER_LLCC 0 > #define SLAVE_EBI1 1 > -- > 2.39.2 >
diff --git a/include/dt-bindings/interconnect/qcom,sdx75.h b/include/dt-bindings/interconnect/qcom,sdx75.h index e903f5f3dd8f..0746f1704ec0 100644 --- a/include/dt-bindings/interconnect/qcom,sdx75.h +++ b/include/dt-bindings/interconnect/qcom,sdx75.h @@ -6,10 +6,8 @@ #ifndef __DT_BINDINGS_INTERCONNECT_QCOM_SDX75_H #define __DT_BINDINGS_INTERCONNECT_QCOM_SDX75_H -#define MASTER_QPIC_CORE 0 -#define MASTER_QUP_CORE_0 1 -#define SLAVE_QPIC_CORE 2 -#define SLAVE_QUP_CORE_0 3 +#define MASTER_QUP_CORE_0 0 +#define SLAVE_QUP_CORE_0 1 #define MASTER_LLCC 0 #define SLAVE_EBI1 1
QPIC resources are modeled as clks, therefore remove corresponding defines from the binding as they're unused. Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@quicinc.com> --- include/dt-bindings/interconnect/qcom,sdx75.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)