| Message ID | 20241208105223.2821049-5-ilias.apalodimas@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Cleanup the LMB subsystem | expand |
Am 8. Dezember 2024 11:52:07 MEZ schrieb Ilias Apalodimas <ilias.apalodimas@linaro.org>: >There's no point defining a function that's called only once just to >avoid passing the flags. Remove the wrapper and just call >lmb_add_region_flags(). > >Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> >--- > lib/lmb.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > >diff --git a/lib/lmb.c b/lib/lmb.c >index ffdd23d87b9b..56e005308dde 100644 >--- a/lib/lmb.c >+++ b/lib/lmb.c >@@ -640,19 +640,13 @@ void lmb_add_memory(void) > } > } > >-static long lmb_add_region(struct alist *lmb_rgn_lst, phys_addr_t base, >- phys_size_t size) >-{ >- return lmb_add_region_flags(lmb_rgn_lst, base, size, LMB_NONE); >-} >- > /* This routine may be called with relocation disabled. */ This comment should be moved to lmb.h. Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > long lmb_add(phys_addr_t base, phys_size_t size) > { > long ret; > struct alist *lmb_rgn_lst = &lmb.available_mem; > >- ret = lmb_add_region(lmb_rgn_lst, base, size); >+ ret = lmb_add_region_flags(lmb_rgn_lst, base, size, LMB_NONE); > if (ret) > return ret; >
On Sun, 8 Dec 2024 at 16:22, Ilias Apalodimas <ilias.apalodimas@linaro.org> wrote: > > There's no point defining a function that's called only once just to > avoid passing the flags. Remove the wrapper and just call > lmb_add_region_flags(). > > Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> > --- Acked-by: Sughosh Ganu <sughosh.ganu@linaro.org> -sughosh > lib/lmb.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/lib/lmb.c b/lib/lmb.c > index ffdd23d87b9b..56e005308dde 100644 > --- a/lib/lmb.c > +++ b/lib/lmb.c > @@ -640,19 +640,13 @@ void lmb_add_memory(void) > } > } > > -static long lmb_add_region(struct alist *lmb_rgn_lst, phys_addr_t base, > - phys_size_t size) > -{ > - return lmb_add_region_flags(lmb_rgn_lst, base, size, LMB_NONE); > -} > - > /* This routine may be called with relocation disabled. */ > long lmb_add(phys_addr_t base, phys_size_t size) > { > long ret; > struct alist *lmb_rgn_lst = &lmb.available_mem; > > - ret = lmb_add_region(lmb_rgn_lst, base, size); > + ret = lmb_add_region_flags(lmb_rgn_lst, base, size, LMB_NONE); > if (ret) > return ret; > > -- > 2.45.2 >
diff --git a/lib/lmb.c b/lib/lmb.c index ffdd23d87b9b..56e005308dde 100644 --- a/lib/lmb.c +++ b/lib/lmb.c @@ -640,19 +640,13 @@ void lmb_add_memory(void) } } -static long lmb_add_region(struct alist *lmb_rgn_lst, phys_addr_t base, - phys_size_t size) -{ - return lmb_add_region_flags(lmb_rgn_lst, base, size, LMB_NONE); -} - /* This routine may be called with relocation disabled. */ long lmb_add(phys_addr_t base, phys_size_t size) { long ret; struct alist *lmb_rgn_lst = &lmb.available_mem; - ret = lmb_add_region(lmb_rgn_lst, base, size); + ret = lmb_add_region_flags(lmb_rgn_lst, base, size, LMB_NONE); if (ret) return ret;
There's no point defining a function that's called only once just to avoid passing the flags. Remove the wrapper and just call lmb_add_region_flags(). Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> --- lib/lmb.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)