Message ID | 20241213190750.2513964-1-richard.henderson@linaro.org |
---|---|
Headers | show |
Series | whole-tree: Constify Property structures | expand |
On 12/13/24 13:06, Richard Henderson wrote: > Since d36f165d952 (qdev: make properties array "const"), we can > define our Property structure const. Do this across the entire tree. > > There are a few other minor changes: > - Two instances where it was obvious that an empty property list > could be removed entirely. There are other empty lists that > probably should be removed, but I didn't look further into usage. > - In hw/misc/xlnx-versal-trng.c, adjust a Property to use the > correct PropertyInfo in the definition, rather than setting > it at runtime. > - One instance where { } was used instead of DEFINE_PROP_END_OF_LIST. > Not a bug, but wrong style. I also meant to report that for qemu-system-aarch64 (the only one I checked), this moves 150k from .data to .data.rel.ro. I'm somewhat surprised there's that many, or that Property is as large as it is at 88 bytes. r~
On 13/12/24 20:06, Richard Henderson wrote: > Since d36f165d952 (qdev: make properties array "const"), we can > define our Property structure const. Do this across the entire tree. > > There are a few other minor changes: > - Two instances where it was obvious that an empty property list > could be removed entirely. There are other empty lists that > probably should be removed, but I didn't look further into usage. > - In hw/misc/xlnx-versal-trng.c, adjust a Property to use the > correct PropertyInfo in the definition, rather than setting > it at runtime. > - One instance where { } was used instead of DEFINE_PROP_END_OF_LIST. > Not a bug, but wrong style. > > > r~ > > > Richard Henderson (71): > target/arm: Constify all Property > target/avr: Constify all Property > target/hexagon: Constify all Property > target/i386: Constify all Property > target/microblaze: Constify all Property > target/mips: Constify all Property > target/ppc: Remove empty property list > target/riscv: Constify all Property > target/s390x: Constify all Property > target/sparc: Constify all Property and PropertyInfo > cpu-target: Constify all Property > hw/9pfs: Constify all Property > hw/acpi: Constify all Property > hw/adc: Constify all Property > hw/arm: Constify all Property > hw/audio: Constify all Property > hw/avr: Constify all Property > hw/block/xen-block: Unexport PropertyInfo > hw/block: Constify all Property > hw/char: Constify all Property > hw/core: Constify all Property > hw/cpu: Constify all Property > hw/cxl: Constify all Property > hw/display: Constify all Property > hw/dma: Constify all Property > hw/gpio: Constify all Property > hw/hyperv: Constify all Property > hw/i2c: Constify all Property > hw/i386: Constify all Property > hw/ide: Constify all Property > hw/input: Constify all Property > hw/intc: Constify all Property > hw/ipack: Constify all Property > hw/ipmi: Constify all Property > hw/isa: Constify all Property > hw/m68k: Constify all Property > hw/mem: Constify all Property > hw/mips: Constify all Property > hw/misc/xlnx-versal-trng: Constify trng_props > hw/misc: Constify all Property > hw/net: Constify all Property > hw/nubus: Constify all Property > hw/nvme: Constify all Property > hw/nvram: Constify all Property > hw/pci-bridge: Constify all Property > hw/pci-host/astro: Remove empty Property list > hw/pci-host: Constify all Property > hw/pci: Constify all Property > hw/ppc: Constify all Property > hw/remote: Constify all Property > hw/riscv: Constify all Property > hw/rtc: Constify all Property > hw/rx: Constify all Property > hw/s390x: Constify all Property > hw/scsi: Constify all Property > hw/sd: Constify all Property > hw/sparc: Constify all Property > hw/sparc64: Constify all Property > hw/ssi: Constify all Property > hw/timer: Constify all Property > hw/tpm: Constify all Property > hw/tricore: Constify all Property > hw/ufs: Constify all Property > hw/usb: Constify all Property > hw/vfio: Constify all Property > hw/virtio: Constify all Property > hw/watchdog: Constify all Property > hw/xen: Constify all Property > hw/xen: Use DEFINE_PROP_END_OF_LIST in xen_sysdev_properties > tests/unit: Constify all Property > docs: Constify all Property in examples Series: Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>