diff mbox series

[v3,08/11] Input: xpad - add support for Nacon Evol-X Xbox One Controller

Message ID 20250107192830.414709-9-rojtberg@gmail.com
State New
Headers show
Series Input: xpad - sync with github fork | expand

Commit Message

Pavel Rojtberg Jan. 7, 2025, 7:28 p.m. UTC 
From: Matheos Mattsson <matheos.mattsson@gmail.com>

Signed-off-by: Matheos Mattsson <matheos.mattsson@gmail.com>
Signed-off-by: Pavel Rojtberg <rojtberg@gmail.com>
---
 drivers/input/joystick/xpad.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Dmitry Torokhov Jan. 17, 2025, 5:30 p.m. UTC | #1 
Hi Pavel,

On Tue, Jan 07, 2025 at 08:28:27PM +0100, Pavel Rojtberg wrote:
> From: Matheos Mattsson <matheos.mattsson@gmail.com>
> 
> Signed-off-by: Matheos Mattsson <matheos.mattsson@gmail.com>

I checked several patches against the github repository and in github
there are no "Signed-off-by"s from the original authors. I understand
and fully appreciate the desire to credit the original authors, but you
can not add SOBs on their behalf.

I think the best way would be to combine all the changes into one patch
authored by you and give credit to all the people involved in the commit
description.

> Signed-off-by: Pavel Rojtberg <rojtberg@gmail.com>
> ---
>  drivers/input/joystick/xpad.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index 237704b3fab5..18e33e2aeaa7 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -394,6 +394,7 @@ static const struct xpad_device {
>  	{ 0x3285, 0x0607, "Nacon GC-100", 0, XTYPE_XBOX360 },
>  	{ 0x3285, 0x0614, "Nacon Pro Compact", 0, XTYPE_XBOXONE },
>  	{ 0x3285, 0x0662, "Nacon Revolution5 Pro", 0, XTYPE_XBOX360 },
> +	{ 0x3285, 0x0663, "Nacon Evol-X", 0, XTYPE_XBOXONE },
>  	{ 0x3537, 0x1004, "GameSir T4 Kaleid", 0, XTYPE_XBOX360 },
>  	{ 0x3767, 0x0101, "Fanatec Speedster 3 Forceshock Wheel", 0, XTYPE_XBOX },
>  	{ 0x413d, 0x2104, "Black Shark Green Ghost Gamepad", 0, XTYPE_XBOX360 },
> @@ -543,6 +544,7 @@ static const struct usb_device_id xpad_table[] = {
>  	XPAD_XBOXONE_VENDOR(0x2e95),		/* SCUF Gaming Controller */
>  	XPAD_XBOX360_VENDOR(0x31e3),		/* Wooting Keyboards */
>  	XPAD_XBOX360_VENDOR(0x3285),		/* Nacon GC-100 */
> +	XPAD_XBOXONE_VENDOR(0x3285),		/* Nacon Evol-X */
>  	XPAD_XBOX360_VENDOR(0x3537),		/* GameSir Controllers */
>  	XPAD_XBOXONE_VENDOR(0x3537),		/* GameSir Controllers */
>  	XPAD_XBOX360_VENDOR(0x413d),		/* Black Shark Green Ghost Controller */
> -- 
> 2.43.0
> 

Thanks.
Dmitry Torokhov Jan. 18, 2025, 12:43 a.m. UTC | #2 
Hi Matheos,

On Fri, Jan 17, 2025 at 11:25:06PM +0200, Matheos Mattsson wrote:
> Hi,
> 
> Sorry to jump in like this. I am not even sure what kind of "chain" this is
> really,

Pavel sent a chain of multiple patches (of which you were CCed on to
just one I assume), so that's what I was referring to.

> but if we are talking about my SOB I am 100% sure I did in my MR
> description on the xpad github repostitory.

Ah, OK, I see now. I simply cloned the repository and inspected the
commits. Pull requests is something that is only recorded in github and
is not a part of git repository.

> Apologies if this was either the wrong place, or if I am conpletely
> misunderstanding what this is about 😅

Yes, for the kernel development SOB should go into commit message
itself. This way SOBs are part of the source code and its history, not
tied to some infrastructure.

But since I am aware of your SOB now I am applying the patch.

Thank you!

> 
> Regards,
> Matheos
> 
> On Fri, 17 Jan 2025, 19:30 Dmitry Torokhov, <dmitry.torokhov@gmail.com>
> wrote:
> 
> > Hi Pavel,
> >
> > On Tue, Jan 07, 2025 at 08:28:27PM +0100, Pavel Rojtberg wrote:
> > > From: Matheos Mattsson <matheos.mattsson@gmail.com>
> > >
> > > Signed-off-by: Matheos Mattsson <matheos.mattsson@gmail.com>
> >
> > I checked several patches against the github repository and in github
> > there are no "Signed-off-by"s from the original authors. I understand
> > and fully appreciate the desire to credit the original authors, but you
> > can not add SOBs on their behalf.
> >
> > I think the best way would be to combine all the changes into one patch
> > authored by you and give credit to all the people involved in the commit
> > description.
> >
> > > Signed-off-by: Pavel Rojtberg <rojtberg@gmail.com>
> > > ---
> > >  drivers/input/joystick/xpad.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/input/joystick/xpad.c
> > b/drivers/input/joystick/xpad.c
> > > index 237704b3fab5..18e33e2aeaa7 100644
> > > --- a/drivers/input/joystick/xpad.c
> > > +++ b/drivers/input/joystick/xpad.c
> > > @@ -394,6 +394,7 @@ static const struct xpad_device {
> > >       { 0x3285, 0x0607, "Nacon GC-100", 0, XTYPE_XBOX360 },
> > >       { 0x3285, 0x0614, "Nacon Pro Compact", 0, XTYPE_XBOXONE },
> > >       { 0x3285, 0x0662, "Nacon Revolution5 Pro", 0, XTYPE_XBOX360 },
> > > +     { 0x3285, 0x0663, "Nacon Evol-X", 0, XTYPE_XBOXONE },
> > >       { 0x3537, 0x1004, "GameSir T4 Kaleid", 0, XTYPE_XBOX360 },
> > >       { 0x3767, 0x0101, "Fanatec Speedster 3 Forceshock Wheel", 0,
> > XTYPE_XBOX },
> > >       { 0x413d, 0x2104, "Black Shark Green Ghost Gamepad", 0,
> > XTYPE_XBOX360 },
> > > @@ -543,6 +544,7 @@ static const struct usb_device_id xpad_table[] = {
> > >       XPAD_XBOXONE_VENDOR(0x2e95),            /* SCUF Gaming Controller
> > */
> > >       XPAD_XBOX360_VENDOR(0x31e3),            /* Wooting Keyboards */
> > >       XPAD_XBOX360_VENDOR(0x3285),            /* Nacon GC-100 */
> > > +     XPAD_XBOXONE_VENDOR(0x3285),            /* Nacon Evol-X */
> > >       XPAD_XBOX360_VENDOR(0x3537),            /* GameSir Controllers */
> > >       XPAD_XBOXONE_VENDOR(0x3537),            /* GameSir Controllers */
> > >       XPAD_XBOX360_VENDOR(0x413d),            /* Black Shark Green Ghost
> > Controller */
> > > --
> > > 2.43.0
> > >
> >
> > Thanks.
> >
> > --
> > Dmitry
> >
Pavel Rojtberg Jan. 18, 2025, 2:02 p.m. UTC | #3 
Hi Dmitry,

Am 17.01.25 um 18:30 schrieb Dmitry Torokhov:
> Hi Pavel,
> 
> On Tue, Jan 07, 2025 at 08:28:27PM +0100, Pavel Rojtberg wrote:
>> From: Matheos Mattsson <matheos.mattsson@gmail.com>
>>
>> Signed-off-by: Matheos Mattsson <matheos.mattsson@gmail.com>
> 
> I checked several patches against the github repository and in github
> there are no "Signed-off-by"s from the original authors. I understand
> and fully appreciate the desire to credit the original authors, but you
> can not add SOBs on their behalf.
> 
> I think the best way would be to combine all the changes into one patch
> authored by you and give credit to all the people involved in the commit
> description.

sorry for the created confusion. Last time I was told to try sending the
one-liner patches individually for proper attribution:
https://lore.kernel.org/all/Yv46RSWwQDaHqE6f@kroah.com/

I was not aware of the peculiarities of the signed-off procedure.
Therefore I merely requested a real name & email from contributors.

As Matheos clarified some contributors added the signed-off line to
the pull-request and not the commit so I tried fixing this manually.

I will update the PR template and explicitly ask for having
the signed-off line in the commit and will squash commits lacking this
into one when sending updates in the future.

Greetings, Pavel

>> Signed-off-by: Pavel Rojtberg <rojtberg@gmail.com>
>> ---
>>  drivers/input/joystick/xpad.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
>> index 237704b3fab5..18e33e2aeaa7 100644
>> --- a/drivers/input/joystick/xpad.c
>> +++ b/drivers/input/joystick/xpad.c
>> @@ -394,6 +394,7 @@ static const struct xpad_device {
>>  	{ 0x3285, 0x0607, "Nacon GC-100", 0, XTYPE_XBOX360 },
>>  	{ 0x3285, 0x0614, "Nacon Pro Compact", 0, XTYPE_XBOXONE },
>>  	{ 0x3285, 0x0662, "Nacon Revolution5 Pro", 0, XTYPE_XBOX360 },
>> +	{ 0x3285, 0x0663, "Nacon Evol-X", 0, XTYPE_XBOXONE },
>>  	{ 0x3537, 0x1004, "GameSir T4 Kaleid", 0, XTYPE_XBOX360 },
>>  	{ 0x3767, 0x0101, "Fanatec Speedster 3 Forceshock Wheel", 0, XTYPE_XBOX },
>>  	{ 0x413d, 0x2104, "Black Shark Green Ghost Gamepad", 0, XTYPE_XBOX360 },
>> @@ -543,6 +544,7 @@ static const struct usb_device_id xpad_table[] = {
>>  	XPAD_XBOXONE_VENDOR(0x2e95),		/* SCUF Gaming Controller */
>>  	XPAD_XBOX360_VENDOR(0x31e3),		/* Wooting Keyboards */
>>  	XPAD_XBOX360_VENDOR(0x3285),		/* Nacon GC-100 */
>> +	XPAD_XBOXONE_VENDOR(0x3285),		/* Nacon Evol-X */
>>  	XPAD_XBOX360_VENDOR(0x3537),		/* GameSir Controllers */
>>  	XPAD_XBOXONE_VENDOR(0x3537),		/* GameSir Controllers */
>>  	XPAD_XBOX360_VENDOR(0x413d),		/* Black Shark Green Ghost Controller */
>> -- 
>> 2.43.0
>>
> 
> Thanks.
>
diff mbox series

Patch

diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index 237704b3fab5..18e33e2aeaa7 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -394,6 +394,7 @@  static const struct xpad_device {
 	{ 0x3285, 0x0607, "Nacon GC-100", 0, XTYPE_XBOX360 },
 	{ 0x3285, 0x0614, "Nacon Pro Compact", 0, XTYPE_XBOXONE },
 	{ 0x3285, 0x0662, "Nacon Revolution5 Pro", 0, XTYPE_XBOX360 },
+	{ 0x3285, 0x0663, "Nacon Evol-X", 0, XTYPE_XBOXONE },
 	{ 0x3537, 0x1004, "GameSir T4 Kaleid", 0, XTYPE_XBOX360 },
 	{ 0x3767, 0x0101, "Fanatec Speedster 3 Forceshock Wheel", 0, XTYPE_XBOX },
 	{ 0x413d, 0x2104, "Black Shark Green Ghost Gamepad", 0, XTYPE_XBOX360 },
@@ -543,6 +544,7 @@  static const struct usb_device_id xpad_table[] = {
 	XPAD_XBOXONE_VENDOR(0x2e95),		/* SCUF Gaming Controller */
 	XPAD_XBOX360_VENDOR(0x31e3),		/* Wooting Keyboards */
 	XPAD_XBOX360_VENDOR(0x3285),		/* Nacon GC-100 */
+	XPAD_XBOXONE_VENDOR(0x3285),		/* Nacon Evol-X */
 	XPAD_XBOX360_VENDOR(0x3537),		/* GameSir Controllers */
 	XPAD_XBOXONE_VENDOR(0x3537),		/* GameSir Controllers */
 	XPAD_XBOX360_VENDOR(0x413d),		/* Black Shark Green Ghost Controller */