| Message ID | 20250122001240.4166460-1-trini@konsulko.com |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: omap: Add TI Pandaboard A4 variant | expand |
On Wed, Jan 22, 2025 at 04:08:27PM +0100, Krzysztof Kozlowski wrote: > On 22/01/2025 15:17, Tom Rini wrote: > > On Wed, Jan 22, 2025 at 09:36:29AM +0100, Krzysztof Kozlowski wrote: > >> On 22/01/2025 01:12, Tom Rini wrote: > >>> Document the ti,omap4-panda-a4 compatible string in the appropriate > >>> place within the omap family binding file. > >> > >> Why? Where is any user of this? Your commit msg should explain this, > >> because it's not obvious. Obvious is to send binding with the user, but > >> the second patch is missing. > > > > You were cc'd on > > https://lore.kernel.org/all/20250121200749.4131923-1-trini@konsulko.com/ > I am cc-ed on 200 patches per day and it means nothing. Do you expect me > to look for missing user in 1000 patches per week, for every 1000 > patches? Or how does it supposed to work? Being an overwhelmed maintainer sucks, I really do get that, sorry for my short reply. > But regardless, the majority of review is done via patchwork and that > DTS patch was not in that thread. It's missing. > > You are supposed to send the binding and the user DTS in the same > patchset. Separate makes little sense in case of kernel. > > If you need the binding for other projects, then of course above changes > into: always reference the other project submission. It's fixing a 10 year old regression where the equally viable option is to just delete the dts file as I'm 99.9% sure no one has even tried using it in that time.
Am Wed, 22 Jan 2025 08:20:58 -0600 schrieb Tom Rini <trini@konsulko.com>: > On Wed, Jan 22, 2025 at 09:32:36AM +0100, Andreas Kemnade wrote: > > Am Tue, 21 Jan 2025 18:12:40 -0600 > > schrieb Tom Rini <trini@konsulko.com>: > > > > > Document the ti,omap4-panda-a4 compatible string in the appropriate > > > place within the omap family binding file. > > > > > > Signed-off-by: Tom Rini <trini@konsulko.com> > > > --- > > > Cc: Aaro Koskinen <aaro.koskinen@iki.fi> > > > Cc: Andreas Kemnade <andreas@kemnade.info> > > > Cc: Kevin Hilman <khilman@baylibre.com> > > > Cc: Roger Quadros <rogerq@kernel.org> > > > Cc: Tony Lindgren <tony@atomide.com> > > > Cc: Rob Herring <robh@kernel.org> > > > Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> > > > Cc: Conor Dooley <conor+dt@kernel.org> > > > Cc: linux-omap@vger.kernel.org > > > Cc: devicetree@vger.kernel.org > > > Cc: linux-kernel@vger.kernel.org > > > --- > > > Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml > > > index 93e04a109a12..28e23ca766b4 100644 > > > --- a/Documentation/devicetree/bindings/arm/ti/omap.yaml > > > +++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml > > > @@ -137,6 +137,7 @@ properties: > > > - motorola,xyboard-mz609 > > > - motorola,xyboard-mz617 > > > - ti,omap4-panda > > > + - ti,omap4-panda-a4 > > > - ti,omap4-sdp > > > - const: ti,omap4430 > > > - const: ti,omap4 > > > > This allows compatible = "ti,omap4-panda-a4", "ti,omap4430", "ti,omap4" > > > > According to your other patch, you want > > compatible = "ti,omap4-panda-a4", "ti,omap4-panda", "ti,omap4430", > > "ti,omap4" > > > > so you need a construction similar to the "ti,omap3-beagle-ab4" > > Do you mean the order should change, or it should be an enum? I'm not > sure where this is documented (the $id and $schema values in the file > are just 404s so I guess not something to read directly?). > you would need a block like this: - description: Early Pandaboard revision A4 items: - const: ti,omap4-panda-a4 - const: ti,omap4-panda - const: ti,omap4430 - const: ti,omap4 Regards, Andreas
diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml index 93e04a109a12..28e23ca766b4 100644 --- a/Documentation/devicetree/bindings/arm/ti/omap.yaml +++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml @@ -137,6 +137,7 @@ properties: - motorola,xyboard-mz609 - motorola,xyboard-mz617 - ti,omap4-panda + - ti,omap4-panda-a4 - ti,omap4-sdp - const: ti,omap4430 - const: ti,omap4
Document the ti,omap4-panda-a4 compatible string in the appropriate place within the omap family binding file. Signed-off-by: Tom Rini <trini@konsulko.com> --- Cc: Aaro Koskinen <aaro.koskinen@iki.fi> Cc: Andreas Kemnade <andreas@kemnade.info> Cc: Kevin Hilman <khilman@baylibre.com> Cc: Roger Quadros <rogerq@kernel.org> Cc: Tony Lindgren <tony@atomide.com> Cc: Rob Herring <robh@kernel.org> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> Cc: Conor Dooley <conor+dt@kernel.org> Cc: linux-omap@vger.kernel.org Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 + 1 file changed, 1 insertion(+)