| Message ID | 20250131221139.342967-3-s-ramamoorthy@ti.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add TI TPS65214 & TPS65215 PMIC MFD Driver Support | expand |
Hi, On 2/1/25 5:42 AM, Krzysztof Kozlowski wrote: > On 31/01/2025 23:11, Shree Ramamoorthy wrote: >> >> @@ -98,6 +102,16 @@ required: >> additionalProperties: false >> >> allOf: >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: ti,tps65214 >> + then: >> + properties: >> + regulators: >> + patternProperties: >> + "^ldo[3-4]$": false > So now, when you combined these patches, you can easily see that you are > duplicating your other "then:" from patch #1. Just combine these into > enum. Don't duplicate. > > Best regards, > Krzysztof Thank you for reviewing! I'll add in this feedback, and send a v5 soon pending any other feedback.
diff --git a/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml index b0d47415bf83..b56e7f8fe88e 100644 --- a/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml +++ b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml @@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/regulator/ti,tps65219.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: TI TPS65215/TPS65219 Power Management Integrated Circuits +title: TI TPS65214/TPS65215/TPS65219 Power Management Integrated Circuit maintainers: - Jerome Neanne <jerome.neanne@baylibre.com> @@ -18,9 +18,13 @@ description: | TI TPS65215 is a derivative of TPS65219 with 3 Buck regulators, 2 Low Drop-out Regulators (LDOs), 1 GPIO, 1 GPO, and power-button. + TI TPS65214 is a derivative of TPS65219 with 3 Buck regulators, 2 Low + Drop-out Regulators (LDOs), 1 GPIO, 1 GPO, and power-button. + properties: compatible: enum: + - ti,tps65214 - ti,tps65215 - ti,tps65219 @@ -98,6 +102,16 @@ required: additionalProperties: false allOf: + - if: + properties: + compatible: + contains: + const: ti,tps65214 + then: + properties: + regulators: + patternProperties: + "^ldo[3-4]$": false - if: properties: compatible:
- TPS65214 is a Power Management IC with 3 Buck regulators and 2 LDOs. - TPS65214 has 2 LDOS and 1 GPO, whereas TPS65219 has 4 LDOs and 2 GPOs. - TPS65214's LDO1 maps to TPS65219's LDO3. - A key difference between TPS65215 & TPS65214 are the LDO current and voltage output ranges and the configurable options available. - The remaining features for both devices are the same. Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@ti.com> --- .../bindings/regulator/ti,tps65219.yaml | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-)