diff mbox series

[v1,2/2] arm64: dts: qcom: ipq9574: Fix USB vdd info

Message ID 20250205074657.4142365-3-quic_varada@quicinc.com
State Superseded
Headers show
Series Fix USB vdd info for IPQ9574 | expand

Commit Message

Varadarajan Narayanan Feb. 5, 2025, 7:46 a.m. UTC 
USB phys in ipq9574 use the 'L5' regulator. The commit
ec4f047679d5 ("arm64: dts: qcom: ipq9574: Enable USB")
incorrectly specified it as 'L2'. Because of this when the phy
module turns off/on its regulators, 'L2' is turned off/on
resulting in 2 issues, namely 'L5' is not turned off/on and the
network module powered by the 'L2' is turned off/on.

Cc: stable@vger.kernel.org
Fixes: ec4f047679d5 ("arm64: dts: qcom: ipq9574: Enable USB")
Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
---
 arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

Comments

Konrad Dybcio Feb. 6, 2025, 7:40 p.m. UTC | #1 
On 5.02.2025 8:46 AM, Varadarajan Narayanan wrote:
> USB phys in ipq9574 use the 'L5' regulator. The commit
> ec4f047679d5 ("arm64: dts: qcom: ipq9574: Enable USB")
> incorrectly specified it as 'L2'. Because of this when the phy
> module turns off/on its regulators, 'L2' is turned off/on
> resulting in 2 issues, namely 'L5' is not turned off/on and the
> network module powered by the 'L2' is turned off/on.

Please wrap your lines at ~72 chars

You use "'L5'" and "'L2'" a lot, making it hard to read. Try focusing
on the effect.

Konrad
Varadarajan Narayanan Feb. 7, 2025, 7:36 a.m. UTC | #2 
On Thu, Feb 06, 2025 at 08:40:43PM +0100, Konrad Dybcio wrote:
> On 5.02.2025 8:46 AM, Varadarajan Narayanan wrote:
> > USB phys in ipq9574 use the 'L5' regulator. The commit
> > ec4f047679d5 ("arm64: dts: qcom: ipq9574: Enable USB")
> > incorrectly specified it as 'L2'. Because of this when the phy
> > module turns off/on its regulators, 'L2' is turned off/on
> > resulting in 2 issues, namely 'L5' is not turned off/on and the
> > network module powered by the 'L2' is turned off/on.
>
> Please wrap your lines at ~72 chars
>
> You use "'L5'" and "'L2'" a lot, making it hard to read. Try focusing
> on the effect.

Have posted the next version addressing this. Please take a look.

Thanks
Varada
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
index ae12f069f26f..b24b795873d4 100644
--- a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
@@ -111,6 +111,13 @@  mp5496_l2: l2 {
 			regulator-always-on;
 			regulator-boot-on;
 		};
+
+		mp5496_l5: l5 {
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-always-on;
+			regulator-boot-on;
+		};
 	};
 };
 
@@ -146,7 +153,7 @@  &usb_0_dwc3 {
 };
 
 &usb_0_qmpphy {
-	vdda-pll-supply = <&mp5496_l2>;
+	vdda-pll-supply = <&mp5496_l5>;
 	vdda-phy-supply = <&regulator_fixed_0p925>;
 
 	status = "okay";
@@ -154,7 +161,7 @@  &usb_0_qmpphy {
 
 &usb_0_qusbphy {
 	vdd-supply = <&regulator_fixed_0p925>;
-	vdda-pll-supply = <&mp5496_l2>;
+	vdda-pll-supply = <&mp5496_l5>;
 	vdda-phy-dpdm-supply = <&regulator_fixed_3p3>;
 
 	status = "okay";