| Message ID | 20250207-ppcyaml-v2-0-8137b0c42526@posteo.net |
|---|---|
| Headers | show |
| Series | YAML conversion of several Freescale/PowerPC DT bindings | expand |
On Fri, Feb 07, 2025 at 10:30:17PM +0100, J. Neuschäfer via B4 Relay wrote: > This is a spin-off of the series titled > "powerpc: MPC83xx cleanup and LANCOM NWAPP2 board". > During the development of that series, it became clear that many > devicetree bindings for Freescale MPC8xxx platforms are still in the old > plain-text format, or don't exist at all, and in any case don't mention > all valid compatible strings. What's the story with dependencies here - why is all this stuff in one series? Normally I'd expect bindings conversions to be standalone.
On 2/8/25 06:30, J. Neuschäfer via B4 Relay wrote: > From: "J. Neuschäfer" <j.ne@posteo.net> > > Convert the Freescale PowerQUICC SATA controller binding from text form > to YAML. The list of compatible strings reflects current usage. > > To clarify the description, I changed it to mention "each SATA > controller" instead of each port. > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> > Signed-off-by: J. Neuschäfer <j.ne@posteo.net> Acked-by: Damien Le Moal <dlemoal@kernel.org>
On Fri, 07 Feb 2025 22:30:26 +0100, J. Neuschäfer wrote: > Convert the Freescale localbus controller bindings from text form to > YAML. The updated list of compatible strings reflects current usage > in arch/powerpc/boot/dts/, except that many existing device trees > erroneously specify "simple-bus" in addition to fsl,*elbc. > > Changes compared to the txt version: > - removed the board-control (fsl,mpc8272ads-bcsr) node because it only > appears in this example and nowhere else > - added a new example with NAND flash > - updated list of compatible strings > > Signed-off-by: J. Neuschäfer <j.ne@posteo.net> > --- > > V2: > - fix order of properties in examples, according to dts coding style > - move to Documentation/devicetree/bindings/memory-controllers > - clarify the commit message a tiny bit > - remove unnecessary multiline markers (|) > - define address format in patternProperties > - trim subject line (remove "binding") > - remove use of "simple-bus", because it's technically incorrect > --- > .../bindings/memory-controllers/fsl,elbc.yaml | 146 +++++++++++++++++++++ > .../devicetree/bindings/powerpc/fsl/lbc.txt | 43 ------ > 2 files changed, 146 insertions(+), 43 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/memory-controllers/fsl,elbc.example.dtb: /example-0/localbus@f0010100/simple-periph@2,0: failed to match any schema with compatible: ['fsl,elbc-gpcm-uio'] Documentation/devicetree/bindings/memory-controllers/fsl,elbc.example.dtb: /example-1/localbus@e0005000/nand@1,0: failed to match any schema with compatible: ['fsl,mpc8315-fcm-nand', 'fsl,elbc-fcm-nand'] Documentation/devicetree/bindings/memory-controllers/fsl,elbc.example.dtb: /example-1/localbus@e0005000/nand@1,0: failed to match any schema with compatible: ['fsl,mpc8315-fcm-nand', 'fsl,elbc-fcm-nand'] doc reference errors (make refcheckdocs): Warning: Documentation/devicetree/bindings/display/ssd1289fb.txt references a file that doesn't exist: Documentation/devicetree/bindings/powerpc/fsl/lbc.txt Documentation/devicetree/bindings/display/ssd1289fb.txt: Documentation/devicetree/bindings/powerpc/fsl/lbc.txt See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250207-ppcyaml-v2-9-8137b0c42526@posteo.net The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Fri, Feb 07, 2025 at 09:38:05PM +0000, Mark Brown wrote: > On Fri, Feb 07, 2025 at 10:30:17PM +0100, J. Neuschäfer via B4 Relay wrote: > > > This is a spin-off of the series titled > > "powerpc: MPC83xx cleanup and LANCOM NWAPP2 board". > > > During the development of that series, it became clear that many > > devicetree bindings for Freescale MPC8xxx platforms are still in the old > > plain-text format, or don't exist at all, and in any case don't mention > > all valid compatible strings. > > What's the story with dependencies here - why is all this stuff in one > series? The patches are independent of each other, except for the four elbc/nand patches. They are in the same series because they came up during the same project and achieve similar goals, but it isn't necessary. > Normally I'd expect bindings conversions to be standalone. Noted. J. Neuschäfer
On Sat, Feb 08, 2025 at 02:20:47AM +0000, J. Neuschäfer wrote: > On Fri, Feb 07, 2025 at 09:38:05PM +0000, Mark Brown wrote: > > What's the story with dependencies here - why is all this stuff in one > > series? > The patches are independent of each other, except for the four elbc/nand > patches. They are in the same series because they came up during the > same project and achieve similar goals, but it isn't necessary. Please don't do this, it just makes it harder to merge things since it makes it look like there's cross tree merges needed when that's not the case, complicating merging, and puts the entire series in everyone's inbox which makes things more noisy.
On Mon, Feb 10, 2025 at 03:57:42PM +0000, J. Neuschäfer wrote: > On Mon, Feb 10, 2025 at 12:59:35PM +0000, Mark Brown wrote: > > Please don't do this, it just makes it harder to merge things since it > > makes it look like there's cross tree merges needed when that's not the > > case, complicating merging, and puts the entire series in everyone's > > inbox which makes things more noisy. > How should I proceed with this series, in your opinion? > I see potential advantages (less of the issues you describe) and > disadvantages (somewhat harder to track patches) of splitting it up > before sending v3. I'd rather that at least the SPI stuff were sent separately (well, ideally what you've done already is fine and it doesn't need a resend at all).
This is a spin-off of the series titled "powerpc: MPC83xx cleanup and LANCOM NWAPP2 board". During the development of that series, it became clear that many devicetree bindings for Freescale MPC8xxx platforms are still in the old plain-text format, or don't exist at all, and in any case don't mention all valid compatible strings. Signed-off-by: J. Neuschäfer <j.ne@posteo.net> --- Changes in v2: - rebased on v6.14-rc1 - various style cleanups, both in YAML and in DTS examples - minor improvements to the commit messages - Link to v1: https://lore.kernel.org/r/20250126-ppcyaml-v1-0-50649f51c3dd@posteo.net --- J. Neuschäfer (12): dt-bindings: powerpc: Add Freescale/NXP MPC83xx SoCs dt-bindings: ata: Convert fsl,pq-sata to YAML dt-bindings: crypto: Convert fsl,sec-2.0 to YAML dt-bindings: mfd: Convert fsl,mcu-mpc8349emitx to YAML dt-bindings: dma: Convert fsl,elo*-dma to YAML dt-bindings: pci: Convert fsl,mpc83xx-pcie to YAML dt-bindings: watchdog: Convert mpc8xxx-wdt to YAML dt-bindings: spi: Convert Freescale SPI bindings to YAML dt-bindings: memory-controllers: Convert fsl,elbc to YAML dt-bindings: memory-controllers: Add fsl,elbc-gpcm-uio dt-bindings: nand: Add fsl,elbc-fcm-nand dt-bindings: mtd: raw-nand-chip: Relax node name pattern .../devicetree/bindings/ata/fsl,pq-sata.yaml | 59 ++++++ Documentation/devicetree/bindings/ata/fsl-sata.txt | 28 --- .../devicetree/bindings/crypto/fsl,sec2.0.yaml | 142 ++++++++++++++ .../devicetree/bindings/crypto/fsl-sec2.txt | 65 ------- .../devicetree/bindings/dma/fsl,elo-dma.yaml | 140 ++++++++++++++ .../devicetree/bindings/dma/fsl,elo3-dma.yaml | 123 +++++++++++++ .../devicetree/bindings/dma/fsl,eloplus-dma.yaml | 134 ++++++++++++++ .../memory-controllers/fsl,elbc-gpcm-uio.yaml | 59 ++++++ .../bindings/memory-controllers/fsl,elbc.yaml | 146 +++++++++++++++ .../bindings/mfd/fsl,mcu-mpc8349emitx.yaml | 53 ++++++ .../devicetree/bindings/mtd/fsl,elbc-fcm-nand.yaml | 68 +++++++ .../devicetree/bindings/mtd/raw-nand-chip.yaml | 2 +- .../devicetree/bindings/pci/fsl,mpc8xxx-pci.yaml | 115 ++++++++++++ Documentation/devicetree/bindings/pci/fsl,pci.txt | 27 --- .../devicetree/bindings/powerpc/fsl/dma.txt | 204 --------------------- .../bindings/powerpc/fsl/fsl,mpc83xx.yaml | 67 +++++++ .../devicetree/bindings/powerpc/fsl/lbc.txt | 43 ----- .../bindings/powerpc/fsl/mcu-mpc8349emitx.txt | 17 -- .../devicetree/bindings/spi/fsl,espi.yaml | 64 +++++++ Documentation/devicetree/bindings/spi/fsl,spi.yaml | 73 ++++++++ Documentation/devicetree/bindings/spi/fsl-spi.txt | 62 ------- .../devicetree/bindings/watchdog/mpc8xxx-wdt.txt | 25 --- .../devicetree/bindings/watchdog/mpc8xxx-wdt.yaml | 64 +++++++ 23 files changed, 1308 insertions(+), 472 deletions(-) --- base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b change-id: 20250126-ppcyaml-680ccd8b3fc2 Best regards,