diff mbox series

[2/6] hostfs: store inode in dentry after mkdir if possible.

Message ID 20250220234630.983190-3-neilb@suse.de
State New
Headers show
Series Change ->mkdir() and vfs_mkdir() to return a dentry. | expand

Commit Message

NeilBrown Feb. 20, 2025, 11:36 p.m. UTC 
After handling a mkdir, get the inode for the name and use
d_splice_alias() to store the correct dentry in the dcache.

Signed-off-by: NeilBrown <neilb@suse.de>
---
 fs/hostfs/hostfs_kern.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

Comments

Jeff Layton Feb. 21, 2025, 1:17 p.m. UTC | #1 
On Fri, 2025-02-21 at 10:36 +1100, NeilBrown wrote:
> After handling a mkdir, get the inode for the name and use
> d_splice_alias() to store the correct dentry in the dcache.
> 
> Signed-off-by: NeilBrown <neilb@suse.de>
> ---
>  fs/hostfs/hostfs_kern.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c
> index ccbb48fe830d..a2c6b9051c5b 100644
> --- a/fs/hostfs/hostfs_kern.c
> +++ b/fs/hostfs/hostfs_kern.c
> @@ -682,14 +682,22 @@ static int hostfs_symlink(struct mnt_idmap *idmap, struct inode *ino,
>  static struct dentry *hostfs_mkdir(struct mnt_idmap *idmap, struct inode *ino,
>  				   struct dentry *dentry, umode_t mode)
>  {
> +	struct inode *inode;
>  	char *file;
>  	int err;
>  
>  	if ((file = dentry_name(dentry)) == NULL)
>  		return ERR_PTR(-ENOMEM);
>  	err = do_mkdir(file, mode);
> +	if (err) {
> +		dentry = ERR_PTR(err);
> +	} else {
> +		inode = hostfs_iget(dentry->d_sb, file);
> +		d_drop(dentry);
> +		dentry = d_splice_alias(inode, dentry);
> +	}
>  	__putname(file);
> -	return ERR_PTR(err);
> +	return dentry;
>  }
>  
>  static int hostfs_rmdir(struct inode *ino, struct dentry *dentry)

Reviewed-by: Jeff Layton <jlayton@kernel.org>
diff mbox series

Patch

diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c
index ccbb48fe830d..a2c6b9051c5b 100644
--- a/fs/hostfs/hostfs_kern.c
+++ b/fs/hostfs/hostfs_kern.c
@@ -682,14 +682,22 @@  static int hostfs_symlink(struct mnt_idmap *idmap, struct inode *ino,
 static struct dentry *hostfs_mkdir(struct mnt_idmap *idmap, struct inode *ino,
 				   struct dentry *dentry, umode_t mode)
 {
+	struct inode *inode;
 	char *file;
 	int err;
 
 	if ((file = dentry_name(dentry)) == NULL)
 		return ERR_PTR(-ENOMEM);
 	err = do_mkdir(file, mode);
+	if (err) {
+		dentry = ERR_PTR(err);
+	} else {
+		inode = hostfs_iget(dentry->d_sb, file);
+		d_drop(dentry);
+		dentry = d_splice_alias(inode, dentry);
+	}
 	__putname(file);
-	return ERR_PTR(err);
+	return dentry;
 }
 
 static int hostfs_rmdir(struct inode *ino, struct dentry *dentry)