| Message ID | 20250220-x1e80100-dts-crd-t14s-enable-typec-retimers-v5-0-380a3e0e7edc@linaro.org |
|---|---|
| Headers | show |
| Series | arm64: dts: qcom: x1e80100: crd/t14s: Enable Parade Type-C retimers | expand |
On Fri, Feb 21, 2025 at 11:41:48AM +0200, Abel Vesa wrote: > On 25-02-21 10:25:00, Johan Hovold wrote: > > On Thu, Feb 20, 2025 at 07:42:29PM +0200, Abel Vesa wrote: > > > Abel Vesa (4): > > > arm64: dts: qcom: x1e80100-crd: Describe the Parade PS8830 retimers > > > arm64: dts: qcom: x1e80100-crd: Enable external DisplayPort support > > > arm64: dts: qcom: x1e80100-t14s: Describe the Parade PS8830 retimers > > > arm64: dts: qcom: x1e80100-t14s: Enable external DisplayPort support > > > > It looks like you've addressed all the comments I had on v1 (except for > > Oh, sorry, missed that one. > > Let me respin. I don't think you need to respin over just that. And that extra newline has already been copy-pasted into two more dts in mainline since (yeah, it's odd to see the original patch go in after the copies). We can just take a pass at cleaning this up at some later point. Johan
On 20.02.2025 6:42 PM, Abel Vesa wrote: > The Lenovo ThinkPad T14s Gen6 laptop comes with 3 Parade PS8830 retimers, > one for each Type-C port. These handle the orientation and altmode > switching and are controlled over I2C. In the connection chain, they sit > between the USB/DisplayPort combo PHY and the Type-C connector. > > Describe the retimers and all gpio controlled voltage regulators used by > each retimer. Also, modify the pmic glink graph to include the retimers in > between the SuperSpeed/Sideband in endpoints and the QMP PHY out > endpoints. > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Konrad
Since the driver and dt-bindings have been alread merged, it has been agreed offline that there is no point of holding on to these DT patches even though there are some issues with plug/unplug during suspend in both pmic-glink-altmode and ucsi-glink. These issues are being worked on meanwhile. Merging these means that even though this will provide external DP and USB orientation, plug/unplug during suspend will give some splats and render both the USB orientation and DP broken. But then, other X Elite boards already have these nodes described, so lets bring the crd and t14s to the same level. These patches are just a resend of the ones found in v5 and dropped in the v6 patchset of the driver and dt-bindings. Link to v5: https://lore.kernel.org/all/20241112-x1e80100-ps8830-v5-0-4ad83af4d162@linaro.org/ Signed-off-by: Abel Vesa <abel.vesa@linaro.org> --- Abel Vesa (4): arm64: dts: qcom: x1e80100-crd: Describe the Parade PS8830 retimers arm64: dts: qcom: x1e80100-crd: Enable external DisplayPort support arm64: dts: qcom: x1e80100-t14s: Describe the Parade PS8830 retimers arm64: dts: qcom: x1e80100-t14s: Enable external DisplayPort support .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 321 +++++++++++++- arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 474 ++++++++++++++++++++- 2 files changed, 785 insertions(+), 10 deletions(-) --- base-commit: 50a0c754714aa3ea0b0e62f3765eb666a1579f24 change-id: 20250220-x1e80100-dts-crd-t14s-enable-typec-retimers-325cdb7b097d Best regards,