| Message ID | 20250303044745.268964-1-raag.jadav@intel.com |
|---|---|
| Headers | show |
| Series | Introduce Intel Elkhart Lake PSE TIO | expand |
On Mon, Mar 03, 2025 at 10:24:43AM +0200, Andy Shevchenko wrote: > On Mon, Mar 03, 2025 at 10:17:41AM +0530, Raag Jadav wrote: > > Intel Elkhart Lake Programmable Service Engine (PSE) includes two PCI > > devices that expose two different capabilities of GPIO and Timed I/O > > as a single PCI function through shared MMIO. > > ... > > > +INTEL GPIO MFD DRIVER > > This also needs to be more precise and follow the name. We have more Intel GPIO > drivers, and MFD doesn't ring any bell about the platform or so. Are you going > to support all of them (existing and comining)? Not that it is planned as of now but I wouldn't mind :) > > +M: Raag Jadav <raag.jadav@intel.com> > > +S: Supported > > +F: drivers/mfd/intel_ehl_pse_gpio.c Raag
On Mon, Mar 03, 2025 at 01:39:16PM +0200, Raag Jadav wrote: > On Mon, Mar 03, 2025 at 10:24:43AM +0200, Andy Shevchenko wrote: > > On Mon, Mar 03, 2025 at 10:17:41AM +0530, Raag Jadav wrote: ... > > > +INTEL GPIO MFD DRIVER > > > > This also needs to be more precise and follow the name. We have more Intel GPIO > > drivers, and MFD doesn't ring any bell about the platform or so. Are you going > > to support all of them (existing and comining)? > > Not that it is planned as of now but I wouldn't mind :) It sounds like solving the problem that even might never appear :-) > > > +M: Raag Jadav <raag.jadav@intel.com> > > > +S: Supported > > > +F: drivers/mfd/intel_ehl_pse_gpio.c
On Mon, Mar 03, 2025 at 01:45:35PM +0200, Andy Shevchenko wrote: > On Mon, Mar 03, 2025 at 01:39:16PM +0200, Raag Jadav wrote: > > On Mon, Mar 03, 2025 at 10:24:43AM +0200, Andy Shevchenko wrote: > > > On Mon, Mar 03, 2025 at 10:17:41AM +0530, Raag Jadav wrote: > > ... > > > > > +INTEL GPIO MFD DRIVER > > > > > > This also needs to be more precise and follow the name. We have more Intel GPIO > > > drivers, and MFD doesn't ring any bell about the platform or so. Are you going > > > to support all of them (existing and comining)? > > > > Not that it is planned as of now but I wouldn't mind :) > > It sounds like solving the problem that even might never appear :-) Right, somehow that sounds familiar :D Raag
On Mon, Mar 03, 2025 at 02:14:35PM +0200, Raag Jadav wrote: > On Mon, Mar 03, 2025 at 01:45:35PM +0200, Andy Shevchenko wrote: > > On Mon, Mar 03, 2025 at 01:39:16PM +0200, Raag Jadav wrote: > > > On Mon, Mar 03, 2025 at 10:24:43AM +0200, Andy Shevchenko wrote: > > > > On Mon, Mar 03, 2025 at 10:17:41AM +0530, Raag Jadav wrote: ... > > > > > +INTEL GPIO MFD DRIVER > > > > > > > > This also needs to be more precise and follow the name. We have more Intel GPIO > > > > drivers, and MFD doesn't ring any bell about the platform or so. Are you going > > > > to support all of them (existing and comining)? > > > > > > Not that it is planned as of now but I wouldn't mind :) > > > > It sounds like solving the problem that even might never appear :-) > > Right, somehow that sounds familiar :D So, can we rename the MAINTAINERS record as the result of our discussion?
On Mon, Mar 03, 2025 at 03:20:12PM +0200, Andy Shevchenko wrote: > On Mon, Mar 03, 2025 at 02:47:29PM +0200, Raag Jadav wrote: > > On Mon, Mar 03, 2025 at 02:22:41PM +0200, Andy Shevchenko wrote: > > > On Mon, Mar 03, 2025 at 02:14:35PM +0200, Raag Jadav wrote: > > > > On Mon, Mar 03, 2025 at 01:45:35PM +0200, Andy Shevchenko wrote: > > > > > On Mon, Mar 03, 2025 at 01:39:16PM +0200, Raag Jadav wrote: > > > > > > On Mon, Mar 03, 2025 at 10:24:43AM +0200, Andy Shevchenko wrote: > > > > > > > On Mon, Mar 03, 2025 at 10:17:41AM +0530, Raag Jadav wrote: > > ... > > > > > > > > > +INTEL GPIO MFD DRIVER > > > > > > > > > > > > > > This also needs to be more precise and follow the name. We have more Intel GPIO > > > > > > > drivers, and MFD doesn't ring any bell about the platform or so. Are you going > > > > > > > to support all of them (existing and comining)? > > > > > > > > > > > > Not that it is planned as of now but I wouldn't mind :) > > > > > > > > > > It sounds like solving the problem that even might never appear :-) > > > > > > > > Right, somehow that sounds familiar :D > > > > > > So, can we rename the MAINTAINERS record as the result of our discussion? > > > > Yep, but perhaps wait a few days for review comments. > > Sure. Or can we just add it under INTEL GPIO DRIVERS? With that I think it'll be in much better hands. Raag
On Tue, Mar 04, 2025 at 07:25:00AM +0200, Raag Jadav wrote: > On Mon, Mar 03, 2025 at 03:20:12PM +0200, Andy Shevchenko wrote: > > On Mon, Mar 03, 2025 at 02:47:29PM +0200, Raag Jadav wrote: > > > On Mon, Mar 03, 2025 at 02:22:41PM +0200, Andy Shevchenko wrote: > > > > On Mon, Mar 03, 2025 at 02:14:35PM +0200, Raag Jadav wrote: > > > > > On Mon, Mar 03, 2025 at 01:45:35PM +0200, Andy Shevchenko wrote: > > > > > > On Mon, Mar 03, 2025 at 01:39:16PM +0200, Raag Jadav wrote: > > > > > > > On Mon, Mar 03, 2025 at 10:24:43AM +0200, Andy Shevchenko wrote: > > > > > > > > On Mon, Mar 03, 2025 at 10:17:41AM +0530, Raag Jadav wrote: ... > > > > > > > > > +INTEL GPIO MFD DRIVER > > > > > > > > > > > > > > > > This also needs to be more precise and follow the name. We have more Intel GPIO > > > > > > > > drivers, and MFD doesn't ring any bell about the platform or so. Are you going > > > > > > > > to support all of them (existing and comining)? > > > > > > > > > > > > > > Not that it is planned as of now but I wouldn't mind :) > > > > > > > > > > > > It sounds like solving the problem that even might never appear :-) > > > > > > > > > > Right, somehow that sounds familiar :D > > > > > > > > So, can we rename the MAINTAINERS record as the result of our discussion? > > > > > > Yep, but perhaps wait a few days for review comments. > > > > Sure. > > Or can we just add it under INTEL GPIO DRIVERS? But it's not a GPIO driver. It's a glue between GPIO and PPS drivers to support such a hardware on some platforms. > With that I think it'll be in much better hands. So, I don't think so.
Intel Elkhart Lake Programmable Service Engine (PSE) includes two PCI devices that expose two different capabilities of GPIO and Timed I/O as a single PCI function through shared MMIO. This series adds MFD driver for them and extends PPS generator driver to support initial PSE TIO functionality. v2: Use consistent naming with Intel drivers (Andy) Add MFD dependency for child drivers (Andy) Aesthetic adjustments (Andy) Update tags Raag Jadav (5): mfd: intel_ehl_pse_gpio: Introduce Intel Elkhart Lake PSE GPIO and TIO gpio: elkhartlake: depend on MFD_INTEL_EHL_PSE_GPIO pps: generators: tio: split pps_gen_tio.h pps: generators: tio: move to match_data() model pps: generators: tio: Introduce Intel Elkhart Lake PSE TIO MAINTAINERS | 5 ++ drivers/gpio/Kconfig | 2 +- drivers/mfd/Kconfig | 12 ++++ drivers/mfd/Makefile | 1 + drivers/mfd/intel_ehl_pse_gpio.c | 100 +++++++++++++++++++++++++++ drivers/pps/generators/Kconfig | 2 +- drivers/pps/generators/pps_gen_tio.c | 80 ++++++++++----------- drivers/pps/generators/pps_gen_tio.h | 67 ++++++++++++++++++ 8 files changed, 228 insertions(+), 41 deletions(-) create mode 100644 drivers/mfd/intel_ehl_pse_gpio.c create mode 100644 drivers/pps/generators/pps_gen_tio.h base-commit: 264ff8415aed324584acc85740596f6e1df7b663