diff mbox series

net: remove commented out line

Message ID 20250321124216.1268147-1-jerome.forissier@linaro.org
State New
Headers show
Series net: remove commented out line | expand

Commit Message

Jerome Forissier March 21, 2025, 12:42 p.m. UTC
Commit 1d5d292b7941 ("net: split net into net{,-common,-legacy,-lwip}")
inadvertendly left a commented out declaration for do_wget() in
net-common.h. Remove it.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
---
 include/net-common.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Heinrich Schuchardt March 21, 2025, 2:47 p.m. UTC | #1
On 21.03.25 13:42, Jerome Forissier wrote:
> Commit 1d5d292b7941 ("net: split net into net{,-common,-legacy,-lwip}")
> inadvertendly left a commented out declaration for do_wget() in
> net-common.h. Remove it.
>
> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>

The definition was moved to include/net-lwip.h.

Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

> ---
>   include/net-common.h | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/include/net-common.h b/include/net-common.h
> index 29d31f37263..89679e20860 100644
> --- a/include/net-common.h
> +++ b/include/net-common.h
> @@ -518,7 +518,6 @@ int wget_do_request(ulong dst_addr, char *uri);
>    * Return:	true if uri is valid, false if uri is invalid
>    */
>   bool wget_validate_uri(char *uri);
> -//int do_wget(struct cmd_tbl *cmdtp, int flag, int argc, char * const argv[]);
>
>   /**
>    * enum wget_http_method - http method
Ilias Apalodimas March 21, 2025, 7:42 p.m. UTC | #2
On Fri, 21 Mar 2025 at 14:42, Jerome Forissier
<jerome.forissier@linaro.org> wrote:
>
> Commit 1d5d292b7941 ("net: split net into net{,-common,-legacy,-lwip}")
> inadvertendly left a commented out declaration for do_wget() in
> net-common.h. Remove it.
>
> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
> ---
>  include/net-common.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/include/net-common.h b/include/net-common.h
> index 29d31f37263..89679e20860 100644
> --- a/include/net-common.h
> +++ b/include/net-common.h
> @@ -518,7 +518,6 @@ int wget_do_request(ulong dst_addr, char *uri);
>   * Return:     true if uri is valid, false if uri is invalid
>   */
>  bool wget_validate_uri(char *uri);
> -//int do_wget(struct cmd_tbl *cmdtp, int flag, int argc, char * const argv[]);
>
>  /**
>   * enum wget_http_method - http method
> --
> 2.43.0
>

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
diff mbox series

Patch

diff --git a/include/net-common.h b/include/net-common.h
index 29d31f37263..89679e20860 100644
--- a/include/net-common.h
+++ b/include/net-common.h
@@ -518,7 +518,6 @@  int wget_do_request(ulong dst_addr, char *uri);
  * Return:	true if uri is valid, false if uri is invalid
  */
 bool wget_validate_uri(char *uri);
-//int do_wget(struct cmd_tbl *cmdtp, int flag, int argc, char * const argv[]);
 
 /**
  * enum wget_http_method - http method