diff mbox series

[1/5] mmc: core: Convert mmc_can_poweroff_notify() into a bool

Message ID 20250320140040.162416-2-ulf.hansson@linaro.org
State New
Headers show
Series mmc: core: Add support for graceful host removal for eMMC/SD | expand

Commit Message

Ulf Hansson March 20, 2025, 2 p.m. UTC
It's really a true/false value that matters, let's make it clear by
returning a bool instead.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
 drivers/mmc/core/mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Avri Altman March 28, 2025, 1:39 p.m. UTC | #1
> It's really a true/false value that matters, let's make it clear by returning a bool
> instead.
> 
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Reviewed-by: Avri Altman <avri.altman@sandisk.com>

> ---
>  drivers/mmc/core/mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index
> 1522fd2b517d..3424bc9e20c5 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -2007,7 +2007,7 @@ static int mmc_sleep(struct mmc_host *host)
>  	return err;
>  }
> 
> -static int mmc_can_poweroff_notify(const struct mmc_card *card)
> +static bool mmc_can_poweroff_notify(const struct mmc_card *card)
>  {
>  	return card &&
>  		mmc_card_mmc(card) &&
> --
> 2.43.0
>
Wolfram Sang March 31, 2025, 8:14 a.m. UTC | #2
On Thu, Mar 20, 2025 at 03:00:32PM +0100, Ulf Hansson wrote:
> It's really a true/false value that matters, let's make it clear by
> returning a bool instead.
> 
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
diff mbox series

Patch

diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 1522fd2b517d..3424bc9e20c5 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -2007,7 +2007,7 @@  static int mmc_sleep(struct mmc_host *host)
 	return err;
 }
 
-static int mmc_can_poweroff_notify(const struct mmc_card *card)
+static bool mmc_can_poweroff_notify(const struct mmc_card *card)
 {
 	return card &&
 		mmc_card_mmc(card) &&