| Message ID | 20250417145819.626733-6-loic.poulain@oss.qualcomm.com |
|---|---|
| State | New |
| Headers | show |
| Series | media: qcom: camss: Add qcm2290 support | expand |
On 17/04/2025 15:58, Loic Poulain wrote: > Add bindings for qcom,qcm2290-camss in order to support the camera > subsystem found in the Qualcomm Robotics RB1 Platform (QRB2210). > > Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com> > --- > .../bindings/media/qcom,qcm2290-camss.yaml | 261 ++++++++++++++++++ > 1 file changed, 261 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml > > diff --git a/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml b/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml > new file mode 100644 > index 000000000000..1af6ed298c66 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml > @@ -0,0 +1,261 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/qcom,qcm2290-camss.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm QCM2290 Camera Subsystem (CAMSS) > + > +maintainers: > + - Loic Poulain <loic.poulain@oss.qualcomm.com> > + > +description: > + The CAMSS IP is a CSI decoder and ISP present on Qualcomm platforms. > + > +properties: > + compatible: > + const: qcom,qcm2290-camss > + > + reg: > + maxItems: 9 > + > + reg-names: > + items: > + - const: csid0 > + - const: csid1 > + - const: csiphy0 > + - const: csiphy1 > + - const: vfe0 > + - const: vfe1 > + - const: tpg0 > + - const: tpg1 > + - const: top > + > + clocks: > + maxItems: 15 > + > + clock-names: > + items: > + - const: ahb > + - const: axi > + - const: top_ahb > + - const: csi0 > + - const: csi1 > + - const: csiphy0 > + - const: csiphy1 > + - const: csiphy0_timer > + - const: csiphy1_timer > + - const: vfe0 > + - const: vfe1 > + - const: vfe0_cphy_rx > + - const: vfe1_cphy_rx > + - const: camnoc_nrt_axi > + - const: camnoc_rt_axi > + > + interrupts: > + maxItems: 8 > + > + interrupt-names: > + items: > + - const: csid0 > + - const: csid1 > + - const: csiphy0 > + - const: csiphy1 > + - const: vfe0 > + - const: vfe1 > + - const: tpg0 > + - const: tpg1 > + > + interconnects: > + maxItems: 3 > + > + interconnect-names: > + items: > + - const: ahb > + - const: hf_mnoc > + - const: sf_mnoc > + > + iommus: > + maxItems: 4 > + > + power-domains: > + items: > + - description: GDSC CAMSS Block, Global Distributed Switch Controller. > + > + vdda-phy-supply: > + description: > + Phandle to a 1.2V regulator supply to CSI PHYs. > + > + vdda-pll-supply: > + description: > + Phandle to 1.8V regulator supply to CAMSS refclk pll block. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + description: > + CSI input ports. patternProperties would be nicer here https://gitlab.freedesktop.org/linux-media/media-committers/-/blob/next/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml?ref_type=heads#L129 > + > +required: > + - compatible > + - reg > + - reg-names > + - clocks > + - clock-names > + - interrupts > + - interrupt-names > + - interconnects > + - interconnect-names > + - iommus > + - power-domains > + - vdda-phy-supply > + - vdda-pll-supply Similarly we are looking for the voltage level on these rails as part of the name. https://gitlab.freedesktop.org/linux-media/media-committers/-/blob/next/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml?ref_type=heads#L173 > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/qcom,gcc-qcm2290.h> > + #include <dt-bindings/interconnect/qcom,rpm-icc.h> > + #include <dt-bindings/interconnect/qcom,qcm2290.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + camss: camss@5c6e000 { > + compatible = "qcom,qcm2290-camss"; > + > + reg = <0 0x5c6e000 0 0x1000>, > + <0 0x5c75000 0 0x1000>, > + <0 0x5c52000 0 0x1000>, > + <0 0x5c53000 0 0x1000>, > + <0 0x5c6f000 0 0x4000>, > + <0 0x5c76000 0 0x4000>, > + <0 0x5c66000 0 0x400>, > + <0 0x5c68000 0 0x400>, > + <0 0x5c11000 0 0x1000>; Recent guidance is for <0x0 0x5c11000 0x0 0x1000> i.e. using hex for both values instead of mixing base 10 and base 16. > + reg-names = "csid0", > + "csid1", > + "csiphy0", > + "csiphy1", > + "vfe0", > + "vfe1", > + "tpg0", > + "tpg1", csitpg0, csitpg1 alphabetise the regs by name too please https://gitlab.freedesktop.org/linux-media/media-committers/-/blob/next/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml?ref_type=heads#L213 https://gitlab.freedesktop.org/linux-media/media-committers/-/blob/next/Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml?ref_type=heads > + "top"; > + > + clocks = <&gcc GCC_CAMERA_AHB_CLK>, > + <&gcc GCC_CAMSS_AXI_CLK>, > + <&gcc GCC_CAMSS_TOP_AHB_CLK>, > + <&gcc GCC_CAMSS_TFE_0_CSID_CLK>, > + <&gcc GCC_CAMSS_TFE_1_CSID_CLK>, > + <&gcc GCC_CAMSS_CPHY_0_CLK>, > + <&gcc GCC_CAMSS_CPHY_1_CLK>, > + <&gcc GCC_CAMSS_CSI0PHYTIMER_CLK>, > + <&gcc GCC_CAMSS_CSI1PHYTIMER_CLK>, > + <&gcc GCC_CAMSS_TFE_0_CLK>, > + <&gcc GCC_CAMSS_TFE_1_CLK>, > + <&gcc GCC_CAMSS_TFE_0_CPHY_RX_CLK>, > + <&gcc GCC_CAMSS_TFE_1_CPHY_RX_CLK>, > + <&gcc GCC_CAMSS_NRT_AXI_CLK>, > + <&gcc GCC_CAMSS_RT_AXI_CLK>; > + clock-names = "ahb", > + "axi", > + "top_ahb", > + "csi0", > + "csi1", > + "csiphy0", > + "csiphy1", > + "csiphy0_timer", > + "csiphy1_timer", > + "vfe0", > + "vfe1", > + "vfe0_cphy_rx", > + "vfe1_cphy_rx", > + "camnoc_nrt_axi", > + "camnoc_rt_axi"; here too > + > + interrupts = <GIC_SPI 210 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 212 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 72 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 73 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 211 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 213 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 309 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 310 IRQ_TYPE_EDGE_RISING>; > + interrupt-names = "csid0", > + "csid1", > + "csiphy0", > + "csiphy1", > + "vfe0", > + "vfe1", > + "tpg0", > + "tpg1"; > + > + interconnects = <&bimc MASTER_APPSS_PROC RPM_ACTIVE_TAG > + &config_noc SLAVE_CAMERA_CFG RPM_ACTIVE_TAG>, > + <&mmrt_virt MASTER_CAMNOC_HF RPM_ALWAYS_TAG > + &bimc SLAVE_EBI1 RPM_ALWAYS_TAG>, > + <&mmnrt_virt MASTER_CAMNOC_SF RPM_ALWAYS_TAG > + &bimc SLAVE_EBI1 RPM_ALWAYS_TAG>; > + interconnect-names = "ahb", > + "hf_mnoc", > + "sf_mnoc"; > + > + iommus = <&apps_smmu 0x400 0x0>, > + <&apps_smmu 0x800 0x0>, > + <&apps_smmu 0x820 0x0>, > + <&apps_smmu 0x840 0x0>; > + > + power-domains = <&gcc GCC_CAMSS_TOP_GDSC>; > + > + vdda-phy-supply = <&pm4125_l5>; > + vdda-pll-supply = <&pm4125_l13>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + }; > + }; ---bod
diff --git a/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml b/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml new file mode 100644 index 000000000000..1af6ed298c66 --- /dev/null +++ b/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml @@ -0,0 +1,261 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/qcom,qcm2290-camss.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm QCM2290 Camera Subsystem (CAMSS) + +maintainers: + - Loic Poulain <loic.poulain@oss.qualcomm.com> + +description: + The CAMSS IP is a CSI decoder and ISP present on Qualcomm platforms. + +properties: + compatible: + const: qcom,qcm2290-camss + + reg: + maxItems: 9 + + reg-names: + items: + - const: csid0 + - const: csid1 + - const: csiphy0 + - const: csiphy1 + - const: vfe0 + - const: vfe1 + - const: tpg0 + - const: tpg1 + - const: top + + clocks: + maxItems: 15 + + clock-names: + items: + - const: ahb + - const: axi + - const: top_ahb + - const: csi0 + - const: csi1 + - const: csiphy0 + - const: csiphy1 + - const: csiphy0_timer + - const: csiphy1_timer + - const: vfe0 + - const: vfe1 + - const: vfe0_cphy_rx + - const: vfe1_cphy_rx + - const: camnoc_nrt_axi + - const: camnoc_rt_axi + + interrupts: + maxItems: 8 + + interrupt-names: + items: + - const: csid0 + - const: csid1 + - const: csiphy0 + - const: csiphy1 + - const: vfe0 + - const: vfe1 + - const: tpg0 + - const: tpg1 + + interconnects: + maxItems: 3 + + interconnect-names: + items: + - const: ahb + - const: hf_mnoc + - const: sf_mnoc + + iommus: + maxItems: 4 + + power-domains: + items: + - description: GDSC CAMSS Block, Global Distributed Switch Controller. + + vdda-phy-supply: + description: + Phandle to a 1.2V regulator supply to CSI PHYs. + + vdda-pll-supply: + description: + Phandle to 1.8V regulator supply to CAMSS refclk pll block. + + ports: + $ref: /schemas/graph.yaml#/properties/ports + + description: + CSI input ports. + + properties: + port@0: + $ref: /schemas/graph.yaml#/$defs/port-base + unevaluatedProperties: false + description: + Input port for receiving CSI data on CSIPHY 0. + + properties: + endpoint: + $ref: video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + minItems: 1 + maxItems: 4 + + required: + - data-lanes + + port@1: + $ref: /schemas/graph.yaml#/$defs/port-base + unevaluatedProperties: false + description: + Input port for receiving CSI data on CSIPHY 1. + + properties: + endpoint: + $ref: video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + minItems: 1 + maxItems: 4 + + required: + - data-lanes + +required: + - compatible + - reg + - reg-names + - clocks + - clock-names + - interrupts + - interrupt-names + - interconnects + - interconnect-names + - iommus + - power-domains + - vdda-phy-supply + - vdda-pll-supply + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/qcom,gcc-qcm2290.h> + #include <dt-bindings/interconnect/qcom,rpm-icc.h> + #include <dt-bindings/interconnect/qcom,qcm2290.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + + soc { + #address-cells = <2>; + #size-cells = <2>; + + camss: camss@5c6e000 { + compatible = "qcom,qcm2290-camss"; + + reg = <0 0x5c6e000 0 0x1000>, + <0 0x5c75000 0 0x1000>, + <0 0x5c52000 0 0x1000>, + <0 0x5c53000 0 0x1000>, + <0 0x5c6f000 0 0x4000>, + <0 0x5c76000 0 0x4000>, + <0 0x5c66000 0 0x400>, + <0 0x5c68000 0 0x400>, + <0 0x5c11000 0 0x1000>; + reg-names = "csid0", + "csid1", + "csiphy0", + "csiphy1", + "vfe0", + "vfe1", + "tpg0", + "tpg1", + "top"; + + clocks = <&gcc GCC_CAMERA_AHB_CLK>, + <&gcc GCC_CAMSS_AXI_CLK>, + <&gcc GCC_CAMSS_TOP_AHB_CLK>, + <&gcc GCC_CAMSS_TFE_0_CSID_CLK>, + <&gcc GCC_CAMSS_TFE_1_CSID_CLK>, + <&gcc GCC_CAMSS_CPHY_0_CLK>, + <&gcc GCC_CAMSS_CPHY_1_CLK>, + <&gcc GCC_CAMSS_CSI0PHYTIMER_CLK>, + <&gcc GCC_CAMSS_CSI1PHYTIMER_CLK>, + <&gcc GCC_CAMSS_TFE_0_CLK>, + <&gcc GCC_CAMSS_TFE_1_CLK>, + <&gcc GCC_CAMSS_TFE_0_CPHY_RX_CLK>, + <&gcc GCC_CAMSS_TFE_1_CPHY_RX_CLK>, + <&gcc GCC_CAMSS_NRT_AXI_CLK>, + <&gcc GCC_CAMSS_RT_AXI_CLK>; + clock-names = "ahb", + "axi", + "top_ahb", + "csi0", + "csi1", + "csiphy0", + "csiphy1", + "csiphy0_timer", + "csiphy1_timer", + "vfe0", + "vfe1", + "vfe0_cphy_rx", + "vfe1_cphy_rx", + "camnoc_nrt_axi", + "camnoc_rt_axi"; + + interrupts = <GIC_SPI 210 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 212 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 72 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 73 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 211 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 213 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 309 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 310 IRQ_TYPE_EDGE_RISING>; + interrupt-names = "csid0", + "csid1", + "csiphy0", + "csiphy1", + "vfe0", + "vfe1", + "tpg0", + "tpg1"; + + interconnects = <&bimc MASTER_APPSS_PROC RPM_ACTIVE_TAG + &config_noc SLAVE_CAMERA_CFG RPM_ACTIVE_TAG>, + <&mmrt_virt MASTER_CAMNOC_HF RPM_ALWAYS_TAG + &bimc SLAVE_EBI1 RPM_ALWAYS_TAG>, + <&mmnrt_virt MASTER_CAMNOC_SF RPM_ALWAYS_TAG + &bimc SLAVE_EBI1 RPM_ALWAYS_TAG>; + interconnect-names = "ahb", + "hf_mnoc", + "sf_mnoc"; + + iommus = <&apps_smmu 0x400 0x0>, + <&apps_smmu 0x800 0x0>, + <&apps_smmu 0x820 0x0>, + <&apps_smmu 0x840 0x0>; + + power-domains = <&gcc GCC_CAMSS_TOP_GDSC>; + + vdda-phy-supply = <&pm4125_l5>; + vdda-pll-supply = <&pm4125_l13>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + }; + }; + };
Add bindings for qcom,qcm2290-camss in order to support the camera subsystem found in the Qualcomm Robotics RB1 Platform (QRB2210). Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com> --- .../bindings/media/qcom,qcm2290-camss.yaml | 261 ++++++++++++++++++ 1 file changed, 261 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml