mbox series

[v3,0/2] Add support for LT3074 low voltage linear regulator

Message ID 20250421-upstream-lt3074-v3-0-71636322f9fe@analog.com
Headers show
Series Add support for LT3074 low voltage linear regulator | expand

Message

Cedric Encarnacion April 21, 2025, 12:18 p.m. UTC 
Introduce hardware monitoring and regulator support for LT3074. The
component is an ultrafast, ultralow noise 3A, 5.5V dropout linear
regulator with a PMBus serial interface that allows telemetry for
input/output voltage, output current, and die temperature. It has a
single channel and requires a bias voltage which can be monitored via
manufacturer-specific registers.

Signed-off-by: Cedric Encarnacion <cedricjustine.encarnacion@analog.com>
---
Changes in v3:
- 
 * Non-nested dt-binding regulator support.
 * PMBUS_REGULATOR_ONE("vout") -> PMBUS_REGULATOR_ONE("regulator").
   New macro needs node-name to be matched.

- Link to v2: https://lore.kernel.org/r/20250225-upstream-lt3074-v2-0-18ad10ba542e@analog.com

Changes in v2:
 * Separated dt-binding for LT3074.
 * Added __maybe_unused attribute to of_device_id. This addresses kernel
   test robot warning.
 * Added entry to MAINTAINERS.

- Link to v1: https://lore.kernel.org/r/20250124-upstream-lt3074-v1-0-7603f346433e@analog.com

---
Cedric Encarnacion (2):
      dt-bindings: hwmon: pmbus: add lt3074
      hwmon: (pmbus/lt3074): add support for lt3074

 .../bindings/hwmon/pmbus/adi,lt3074.yaml           |  50 +++++++++
 Documentation/hwmon/index.rst                      |   1 +
 Documentation/hwmon/lt3074.rst                     |  72 ++++++++++++
 MAINTAINERS                                        |   9 ++
 drivers/hwmon/pmbus/Kconfig                        |  18 +++
 drivers/hwmon/pmbus/Makefile                       |   1 +
 drivers/hwmon/pmbus/lt3074.c                       | 122 +++++++++++++++++++++
 7 files changed, 273 insertions(+)
---
base-commit: 86d264b68309d9f9804db4079642b98104ca15df
change-id: 20250124-upstream-lt3074-123384246e0b

Best regards,

Comments

Krzysztof Kozlowski April 22, 2025, 9:16 a.m. UTC | #1 
On Mon, Apr 21, 2025 at 08:18:18PM GMT, Cedric Encarnacion wrote:
> Add Analog Devices LT3074 Ultralow Noise, High PSRR Dropout Linear
> Regulator.
> 
> Signed-off-by: Cedric Encarnacion <cedricjustine.encarnacion@analog.com>
> ---
>  .../bindings/hwmon/pmbus/adi,lt3074.yaml           | 50 ++++++++++++++++++++++
>  MAINTAINERS                                        |  7 +++
>  2 files changed, 57 insertions(+)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Cedric Encarnacion April 22, 2025, 10:09 a.m. UTC | #2 
> From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck
> Sent: Monday, April 21, 2025 9:23 PM
> To: Encarnacion, Cedric justine <Cedricjustine.Encarnacion@analog.com>; Rob
> Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor
> Dooley <conor+dt@kernel.org>; Jean Delvare <jdelvare@suse.com>; Jonathan
> Corbet <corbet@lwn.net>; Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
> Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> hwmon@vger.kernel.org; linux-doc@vger.kernel.org; linux-i2c@vger.kernel.org
> Subject: Re: [PATCH v3 0/2] Add support for LT3074 low voltage linear regulator
> 
> [External]
> 
> On 4/21/25 05:18, Cedric Encarnacion wrote:
> > Introduce hardware monitoring and regulator support for LT3074. The
> > component is an ultrafast, ultralow noise 3A, 5.5V dropout linear
> > regulator with a PMBus serial interface that allows telemetry for
> > input/output voltage, output current, and die temperature. It has a
> > single channel and requires a bias voltage which can be monitored via
> > manufacturer-specific registers.
> >
> > Signed-off-by: Cedric Encarnacion
> > <cedricjustine.encarnacion@analog.com>
> > ---
> > Changes in v3:
> > -
> >   * Non-nested dt-binding regulator support.
> >   * PMBUS_REGULATOR_ONE("vout") ->
> PMBUS_REGULATOR_ONE("regulator").
> >     New macro needs node-name to be matched.
> >
> 
> Does that mean we can (and maybe should) drop the name parameter of that
> macro ?
> 
> This isn't affecting this patch. If needed I'll do that separately.
> Just asking.

This is used by regulator_desc->of_match to match a node name in dt. By
dropping the name, does this mean the of_match won't be assigned, or
of_match="some-default-regulator-name"? I did some tests, and it appears
the regulators dt properties can only be parsed when the name parameter
exists, and name parameter == node-name. I have tried simply removing the
of_match assignment from the regulator_desc macro, but it does not work in
my case.

Best regards,
Cedric

> > - Link to v2:
> > https://urldefense.com/v3/__https://lore.kernel.org/r/20250225-upstrea
> > m-lt3074-v2-0-
> 18ad10ba542e@analog.com__;!!A3Ni8CS0y2Y!7jXNBOqw7P6dNnjZ
> > TKrDqezkv8BSgZf9ZEeOfTvvbXEP3IfjL8UCdzIWjAIMFy--UJKsE_bztdArzpX5joZt35
> > NsPf0$
> >
> > Changes in v2:
> >   * Separated dt-binding for LT3074.
> >   * Added __maybe_unused attribute to of_device_id. This addresses kernel
> >     test robot warning.
> >   * Added entry to MAINTAINERS.
> >
> > - Link to v1:
> > https://urldefense.com/v3/__https://lore.kernel.org/r/20250124-upstrea
> > m-lt3074-v1-0-
> 7603f346433e@analog.com__;!!A3Ni8CS0y2Y!7jXNBOqw7P6dNnjZ
> > TKrDqezkv8BSgZf9ZEeOfTvvbXEP3IfjL8UCdzIWjAIMFy--UJKsE_bztdArzpX5joZt1h
> > Q_Vuk$
> >
> > ---
> > Cedric Encarnacion (2):
> >        dt-bindings: hwmon: pmbus: add lt3074
> >        hwmon: (pmbus/lt3074): add support for lt3074
> >
> >   .../bindings/hwmon/pmbus/adi,lt3074.yaml           |  50 +++++++++
> >   Documentation/hwmon/index.rst                      |   1 +
> >   Documentation/hwmon/lt3074.rst                     |  72 ++++++++++++
> >   MAINTAINERS                                        |   9 ++
> >   drivers/hwmon/pmbus/Kconfig                        |  18 +++
> >   drivers/hwmon/pmbus/Makefile                       |   1 +
> >   drivers/hwmon/pmbus/lt3074.c                       | 122 +++++++++++++++++++++
> >   7 files changed, 273 insertions(+)
> > ---
> > base-commit: 86d264b68309d9f9804db4079642b98104ca15df
> > change-id: 20250124-upstream-lt3074-123384246e0b
> >
> > Best regards,
Guenter Roeck April 22, 2025, 1:23 p.m. UTC | #3 
On 4/22/25 03:09, Encarnacion, Cedric justine wrote:
>> From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck
>> Sent: Monday, April 21, 2025 9:23 PM
>> To: Encarnacion, Cedric justine <Cedricjustine.Encarnacion@analog.com>; Rob
>> Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor
>> Dooley <conor+dt@kernel.org>; Jean Delvare <jdelvare@suse.com>; Jonathan
>> Corbet <corbet@lwn.net>; Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
>> Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
>> hwmon@vger.kernel.org; linux-doc@vger.kernel.org; linux-i2c@vger.kernel.org
>> Subject: Re: [PATCH v3 0/2] Add support for LT3074 low voltage linear regulator
>>
>> [External]
>>
>> On 4/21/25 05:18, Cedric Encarnacion wrote:
>>> Introduce hardware monitoring and regulator support for LT3074. The
>>> component is an ultrafast, ultralow noise 3A, 5.5V dropout linear
>>> regulator with a PMBus serial interface that allows telemetry for
>>> input/output voltage, output current, and die temperature. It has a
>>> single channel and requires a bias voltage which can be monitored via
>>> manufacturer-specific registers.
>>>
>>> Signed-off-by: Cedric Encarnacion
>>> <cedricjustine.encarnacion@analog.com>
>>> ---
>>> Changes in v3:
>>> -
>>>    * Non-nested dt-binding regulator support.
>>>    * PMBUS_REGULATOR_ONE("vout") ->
>> PMBUS_REGULATOR_ONE("regulator").
>>>      New macro needs node-name to be matched.
>>>
>>
>> Does that mean we can (and maybe should) drop the name parameter of that
>> macro ?
>>
>> This isn't affecting this patch. If needed I'll do that separately.
>> Just asking.
> 
> This is used by regulator_desc->of_match to match a node name in dt. By
> dropping the name, does this mean the of_match won't be assigned, or
> of_match="some-default-regulator-name"? I did some tests, and it appears
> the regulators dt properties can only be parsed when the name parameter
> exists, and name parameter == node-name. I have tried simply removing the
> of_match assignment from the regulator_desc macro, but it does not work in
> my case.
> 

No, I was wondering if the name parameter always needs to be "regulator".
I did not (want to) suggest that the name should be dropped from the structure,
only if it always needs to be "regulator". If it always needs to be "regulator",
it could be hard-coded and would not have to be a macro parameter.

Sorry for the confusion. Just forget that I asked.

Guenter
Guenter Roeck April 22, 2025, 1:25 p.m. UTC | #4 
On Mon, Apr 21, 2025 at 08:18:18PM +0800, Cedric Encarnacion wrote:
> Add Analog Devices LT3074 Ultralow Noise, High PSRR Dropout Linear
> Regulator.
> 
> Signed-off-by: Cedric Encarnacion <cedricjustine.encarnacion@analog.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Applied.

Thanks,
Guenter
Guenter Roeck April 22, 2025, 1:25 p.m. UTC | #5 
On Mon, Apr 21, 2025 at 08:18:19PM +0800, Cedric Encarnacion wrote:
> Add hardware monitoring and regulator support for LT3074. The LT3074 is an
> ultrafast, ultralow noise 3A, 5.5V dropout linear regulator. The PMBus
> serial interface allows telemetry for input/output voltage, bias voltage,
> output current, and die temperature.
> 
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Cedric Encarnacion <cedricjustine.encarnacion@analog.com>

Applied.

Thanks,
Guenter