| Message ID | 20250424094653.35932-4-philmd@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | include: Remove "exec/exec-all.h" | expand |
On 24/04/2025 10:46, Philippe Mathieu-Daudé wrote: > In commit 3549118b498 we moved cpu_loop_exit*() declarations to > "exec/cpu-common.h" but neglected to update tcg-stub.c. We missed > it because "exec/cpu-common.h" is indirectly pulled in via > "exec/exec-all.h" -> "exec/translation-block.h". Include it > directly instead of the not necessary "exec/exec-all.h". > > Commit bb6cf6f0168 ("accel/tcg: Factor tcg_cpu_reset_hold() out") > removed the need for "exec/tb-flush.h", so remote it too. > > Fixes: 3549118b498 ("exec: Move cpu_loop_foo() functions to 'cpu-common.h'") > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > accel/stubs/tcg-stub.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c > index b2b9881bdfb..3b76b8b17c1 100644 > --- a/accel/stubs/tcg-stub.c > +++ b/accel/stubs/tcg-stub.c > @@ -11,8 +11,7 @@ > */ > > #include "qemu/osdep.h" > -#include "exec/tb-flush.h" > -#include "exec/exec-all.h" > +#include "exec/cpu-common.h" > > G_NORETURN void cpu_loop_exit(CPUState *cpu) > { Reviewed-by: Mark Cave-Ayland <mark.caveayland@nutanix.com> ATB, Mark.
diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c index b2b9881bdfb..3b76b8b17c1 100644 --- a/accel/stubs/tcg-stub.c +++ b/accel/stubs/tcg-stub.c @@ -11,8 +11,7 @@ */ #include "qemu/osdep.h" -#include "exec/tb-flush.h" -#include "exec/exec-all.h" +#include "exec/cpu-common.h" G_NORETURN void cpu_loop_exit(CPUState *cpu) {
In commit 3549118b498 we moved cpu_loop_exit*() declarations to "exec/cpu-common.h" but neglected to update tcg-stub.c. We missed it because "exec/cpu-common.h" is indirectly pulled in via "exec/exec-all.h" -> "exec/translation-block.h". Include it directly instead of the not necessary "exec/exec-all.h". Commit bb6cf6f0168 ("accel/tcg: Factor tcg_cpu_reset_hold() out") removed the need for "exec/tb-flush.h", so remote it too. Fixes: 3549118b498 ("exec: Move cpu_loop_foo() functions to 'cpu-common.h'") Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- accel/stubs/tcg-stub.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)