| Message ID | 20250324-dt-bindings-network-class-v5-3-f5c3fe00e8f0@ixit.cz |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: net: Add network-class.yaml schema | expand |
On 24/03/2025 18:41, David Heidelberg via B4 Relay wrote: > From: Janne Grunau <j@jannau.net> > > The wireless-controller schema specifies local-mac-address as > used in the bcm4329-fmac device nodes of Apple silicon devices > (arch/arm64/boot/dts/apple). > > Fixes `make dtbs_check` for those devices. > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> > Signed-off-by: Janne Grunau <j@jannau.net> > Signed-off-by: David Heidelberg <david@ixit.cz> This introduced several new dtbs_check warnings. Including on platforms which were warnings free. It is nice to fix these warnings when you make such changes. Best regards, Krzysztof
On 24/04/2025 10:20, Krzysztof Kozlowski wrote: > On 24/03/2025 18:41, David Heidelberg via B4 Relay wrote: >> From: Janne Grunau <j@jannau.net> >> >> The wireless-controller schema specifies local-mac-address as >> used in the bcm4329-fmac device nodes of Apple silicon devices >> (arch/arm64/boot/dts/apple). >> >> Fixes `make dtbs_check` for those devices. >> >> Reviewed-by: Rob Herring (Arm) <robh@kernel.org> >> Signed-off-by: Janne Grunau <j@jannau.net> >> Signed-off-by: David Heidelberg <david@ixit.cz> > > This introduced several new dtbs_check warnings. Including on platforms > which were warnings free. It is nice to fix these warnings when you make > such changes. I will send the patches for them, except for Apple SoCs. Best regards, Krzysztof
On Thu, 2025-04-24 at 10:28 +0200, Krzysztof Kozlowski wrote: > On 24/04/2025 10:20, Krzysztof Kozlowski wrote: > > On 24/03/2025 18:41, David Heidelberg via B4 Relay wrote: > > > From: Janne Grunau <j@jannau.net> > > > > > > The wireless-controller schema specifies local-mac-address as > > > used in the bcm4329-fmac device nodes of Apple silicon devices > > > (arch/arm64/boot/dts/apple). > > > > > > Fixes `make dtbs_check` for those devices. > > > > > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> > > > Signed-off-by: Janne Grunau <j@jannau.net> > > > Signed-off-by: David Heidelberg <david@ixit.cz> > > > > This introduced several new dtbs_check warnings. Including on platforms > > which were warnings free. It is nice to fix these warnings when you make > > such changes. Heh, especially since it said it should _fix_ things there. > I will send the patches for them, except for Apple SoCs. Thanks, I guess I'll hold the pull request for that. And I guess the Apple ones are on David then. Knew it was a mistake for me to ever do anything with DT stuff ;-) johannes
On 24/04/2025 14:09, Johannes Berg wrote: > On Thu, 2025-04-24 at 10:28 +0200, Krzysztof Kozlowski wrote: >> On 24/04/2025 10:20, Krzysztof Kozlowski wrote: >>> On 24/03/2025 18:41, David Heidelberg via B4 Relay wrote: >>>> From: Janne Grunau <j@jannau.net> >>>> >>>> The wireless-controller schema specifies local-mac-address as >>>> used in the bcm4329-fmac device nodes of Apple silicon devices >>>> (arch/arm64/boot/dts/apple). >>>> >>>> Fixes `make dtbs_check` for those devices. >>>> >>>> Reviewed-by: Rob Herring (Arm) <robh@kernel.org> >>>> Signed-off-by: Janne Grunau <j@jannau.net> >>>> Signed-off-by: David Heidelberg <david@ixit.cz> >>> >>> This introduced several new dtbs_check warnings. Including on platforms >>> which were warnings free. It is nice to fix these warnings when you make >>> such changes. > > Heh, especially since it said it should _fix_ things there. > >> I will send the patches for them, except for Apple SoCs. > > Thanks, I guess I'll hold the pull request for that. And I guess the > Apple ones are on David then. I think you can go ahead. I already referenced that commit from next in my patches, so I hope that SHA will not change (don't rebase your tree): https://lore.kernel.org/linux-devicetree/?q=f%3Akrzysztof+%22Align+wifi+node+name+with+bindings%22 Best regards, Krzysztof
On Thu, 2025-04-24 at 17:37 +0200, Krzysztof Kozlowski wrote: > > > > Thanks, I guess I'll hold the pull request for that. And I guess the > > Apple ones are on David then. > I think you can go ahead. I already referenced that commit from next in > my patches, so I hope that SHA will not change (don't rebase your tree): > > https://lore.kernel.org/linux-devicetree/?q=f%3Akrzysztof+%22Align+wifi+node+name+with+bindings%22 > Hm. I thought this patchset broke it, and it is going through my tree. Wouldn't it be much more complex for fixes on top of it to go through another tree? johannes
On Thu, Apr 24, 2025 at 10:42 AM Johannes Berg <johannes@sipsolutions.net> wrote: > > On Thu, 2025-04-24 at 17:37 +0200, Krzysztof Kozlowski wrote: > > > > > > Thanks, I guess I'll hold the pull request for that. And I guess the > > > Apple ones are on David then. > > I think you can go ahead. I already referenced that commit from next in > > my patches, so I hope that SHA will not change (don't rebase your tree): > > > > https://lore.kernel.org/linux-devicetree/?q=f%3Akrzysztof+%22Align+wifi+node+name+with+bindings%22 > > > > Hm. I thought this patchset broke it, and it is going through my tree. > Wouldn't it be much more complex for fixes on top of it to go through > another tree? While it seems the reviews of the series caused more warnings for Apple, in general, schemas creating warnings is not breaking things. In a way, the whole point is to create warnings because if the .dts files were perfect already we wouldn't need schemas. The main requirement for schemas is only that they don't create warnings for the examples. There's still too many for .dts files to worry about it (and there's intermittent warnings from things getting merged via different trees). Rob
On Thu, 2025-04-24 at 13:26 -0500, Rob Herring wrote: > While it seems the reviews of the series caused more warnings for > Apple, in general, schemas creating warnings is not breaking things. > In a way, the whole point is to create warnings because if the .dts > files were perfect already we wouldn't need schemas. The main > requirement for schemas is only that they don't create warnings for > the examples. There's still too many for .dts files to worry about it > (and there's intermittent warnings from things getting merged via > different trees). > Oh, sure, but now if you want to apply the fixes you probably have to wait for the broken patches in my tree to percolate all the way through to Linus, then back to your tree, and then you can apply the fixes? Seemed it'd be easier to send the fixes to me but it's all your call, just let me know what you prefer. johannes
On Thu, Apr 24, 2025 at 1:39 PM Johannes Berg <johannes@sipsolutions.net> wrote: > > On Thu, 2025-04-24 at 13:26 -0500, Rob Herring wrote: > > While it seems the reviews of the series caused more warnings for > > Apple, in general, schemas creating warnings is not breaking things. > > In a way, the whole point is to create warnings because if the .dts > > files were perfect already we wouldn't need schemas. The main > > requirement for schemas is only that they don't create warnings for > > the examples. There's still too many for .dts files to worry about it > > (and there's intermittent warnings from things getting merged via > > different trees). > > > > Oh, sure, but now if you want to apply the fixes you probably have to > wait for the broken patches in my tree to percolate all the way through > to Linus, then back to your tree, and then you can apply the fixes? No, I never take .dts changes. They all go via the individual platform trees. It's a bit weird if Krzysztof refers to the commit that's not in the linear history, but that shouldn't hold things up. The issues exist with or without the schema change. They might even be backported to stable while the schema change won't be. Rob
On Thu, 2025-04-24 at 14:04 -0500, Rob Herring wrote: > On Thu, Apr 24, 2025 at 1:39 PM Johannes Berg <johannes@sipsolutions.net> wrote: > > > > On Thu, 2025-04-24 at 13:26 -0500, Rob Herring wrote: > > > While it seems the reviews of the series caused more warnings for > > > Apple, in general, schemas creating warnings is not breaking things. > > > In a way, the whole point is to create warnings because if the .dts > > > files were perfect already we wouldn't need schemas. The main > > > requirement for schemas is only that they don't create warnings for > > > the examples. There's still too many for .dts files to worry about it > > > (and there's intermittent warnings from things getting merged via > > > different trees). > > > > > > > Oh, sure, but now if you want to apply the fixes you probably have to > > wait for the broken patches in my tree to percolate all the way through > > to Linus, then back to your tree, and then you can apply the fixes? > > No, I never take .dts changes. They all go via the individual platform > trees. It's a bit weird if Krzysztof refers to the commit that's not > in the linear history, but that shouldn't hold things up. The issues > exist with or without the schema change. They might even be backported > to stable while the schema change won't be. Ah. OK, so never mind then. I'll assume whatever Krzysztof did will go through some other tree and just go on with things :) Thanks for the explanations! johannes
diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml index a3607d55ef3671514cdf2c884cf5bd0ccaadb162..7c8100e59a6cd045837a2f602e367f3f79ced5ba 100644 --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml @@ -16,7 +16,7 @@ description: binding. allOf: - - $ref: ieee80211.yaml# + - $ref: /schemas/net/wireless/wireless-controller.yaml# properties: compatible: