| Message ID | 20250409-mdb-max7360-support-v6-5-7a2535876e39@bootlin.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for MAX7360 | expand |
On Wed, Apr 09, 2025 at 04:19:27PM +0100, Mark Brown wrote: > On Wed, Apr 09, 2025 at 04:55:52PM +0200, Mathieu Dubois-Briand wrote: > > BUG() never returns, so code after it is unreachable: remove it. > > BUG() can be compiled out, CONFIG_BUG. In that case BUG is defined as: #define BUG() do { \ do {} while (1); \ unreachable(); \ } while (0) so the return can be dropped as suggested in the patch. Best regards Uwe
On Wed Apr 9, 2025 at 5:19 PM CEST, Mark Brown wrote: > On Wed, Apr 09, 2025 at 04:55:52PM +0200, Mathieu Dubois-Briand wrote: >> BUG() never returns, so code after it is unreachable: remove it. > > BUG() can be compiled out, CONFIG_BUG. Hi Mark, Thanks for your review. As there has been a bit of discussion on this patch, may I ask you for your current opinion about this change? Should I drop it from my next series? Best regards, Mathieu
On Wed, Apr 23, 2025 at 02:41:47PM +0200, Mathieu Dubois-Briand wrote: > As there has been a bit of discussion on this patch, may I ask you for > your current opinion about this change? > Should I drop it from my next series? Please.
diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regmap/regmap-irq.c index 6c6869188c31..14f5fcc3ec1d 100644 --- a/drivers/base/regmap/regmap-irq.c +++ b/drivers/base/regmap/regmap-irq.c @@ -436,7 +436,6 @@ static irqreturn_t regmap_irq_thread(int irq, void *d) break; default: BUG(); - goto exit; } }
BUG() never returns, so code after it is unreachable: remove it. Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com> --- drivers/base/regmap/regmap-irq.c | 1 - 1 file changed, 1 deletion(-)