diff mbox series

[v3] serdev: Refine several error or debug messages

Message ID 20250425-fix_serdev-v3-1-2e4ea8261640@quicinc.com
State New
Headers show
Series [v3] serdev: Refine several error or debug messages | expand

Commit Message

Zijun Hu April 25, 2025, 12:48 p.m. UTC 
From: Zijun Hu <quic_zijuhu@quicinc.com>

Refine several dev_err() and dev_dbg() messages to solve:

// hardcoded device name
dev_dbg(dev, "...dev_name_str...")

// repeated device name since dev_dbg() also prints it as prefix
dev_err(dev, "...%s...", dev_name(dev))

// not concise as dev_err(dev, "...%d...", err)
dev_err(dev, "...%pe...", ERR_PTR(err))

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
For messages printed by dev_err() and dev_dbg(), this patch series is
to remove hardcoded or repeated device name.
---
Changes in v3:
- Squash both patches as Rob's comments
- Simplify error code printing as Jiri's comments 
- Link to v2: https://lore.kernel.org/r/20250424-fix_serdev-v2-0-a1226ed77435@quicinc.com

Changes in v2:
- Add one more patch to remove repeated device name pointed out by Greg
- Link to v1: https://lore.kernel.org/r/20250423-fix_serdev-v1-1-26ca3403fd33@quicinc.com
---
 drivers/tty/serdev/core.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)


---
base-commit: 9d7a0577c9db35c4cc52db90bc415ea248446472
change-id: 20250422-fix_serdev-9da04229081b

Best regards,

Comments

Jiri Slaby April 28, 2025, 5:32 a.m. UTC | #1 
On 25. 04. 25, 14:48, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@quicinc.com>
> 
> Refine several dev_err() and dev_dbg() messages to solve:
> 
> // hardcoded device name
> dev_dbg(dev, "...dev_name_str...")
> 
> // repeated device name since dev_dbg() also prints it as prefix
> dev_err(dev, "...%s...", dev_name(dev))
> 
> // not concise as dev_err(dev, "...%d...", err)
> dev_err(dev, "...%pe...", ERR_PTR(err))
> 
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>

This LGTM.

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
diff mbox series

Patch

diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
index eb2a2e58fe78fbbdb5839232936a994bda86d0b4..0213381fa35876f43f2f10f6c444160cde73a686 100644
--- a/drivers/tty/serdev/core.c
+++ b/drivers/tty/serdev/core.c
@@ -118,12 +118,11 @@  int serdev_device_add(struct serdev_device *serdev)
 
 	err = device_add(&serdev->dev);
 	if (err < 0) {
-		dev_err(&serdev->dev, "Can't add %s, status %pe\n",
-			dev_name(&serdev->dev), ERR_PTR(err));
+		dev_err(&serdev->dev, "Failed to add serdev: %d\n", err);
 		goto err_clear_serdev;
 	}
 
-	dev_dbg(&serdev->dev, "device %s registered\n", dev_name(&serdev->dev));
+	dev_dbg(&serdev->dev, "serdev registered successfully\n");
 
 	return 0;
 
@@ -783,8 +782,7 @@  int serdev_controller_add(struct serdev_controller *ctrl)
 		goto err_rpm_disable;
 	}
 
-	dev_dbg(&ctrl->dev, "serdev%d registered: dev:%p\n",
-		ctrl->nr, &ctrl->dev);
+	dev_dbg(&ctrl->dev, "serdev controller registered: dev:%p\n", &ctrl->dev);
 	return 0;
 
 err_rpm_disable: