| Message ID | 20250423060034.973-1-yashwant.v@samsung.com |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: exynos: Added the ethernet pin configuration | expand |
-----Original Message----- From: Krzysztof Kozlowski <krzk@kernel.org> Sent: Wednesday, April 23, 2025 8:41 PM To: Yashwant Varur <yashwant.v@samsung.com>; robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org Cc: cs0617.lee@samsung.com; g.naidu@samsung.com; niyas.ahmed@samsung.com Subject: Re: [PATCH] arm64: dts: exynos: Added the ethernet pin configuration On 23/04/2025 08:00, Yashwant Varur wrote: > This patch adds the ethernet pin configuration. > > Signed-off-by: Yashwant Varur <yashwant.v@samsung.com> > Signed-off-by: Changsub Lee <cs0617.lee@samsung.com> Incorrect chain or confusing. Who was the author? What is the meaning of the last SoB? > Sorry will correct the order. > --- > .../dts/exynos/exynosautov920-pinctrl.dtsi | 41 +++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi > b/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi > index 663e8265cbf5..778584d339d5 100644 > --- a/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi > @@ -166,6 +166,24 @@ gph6: gph6-gpio-bank { > interrupt-controller; > #interrupt-cells = <2>; > }; > + > + eth0_pps_out: eth0_pps_out { Please follow DTS coding style carefully. This applies to all commits you try to send from your downstream/vendor code. > Sure, thanks What is more important, I don't really understand why you are doing this - there is no user of these entries - and commit msg does not help here. > Understood, in v2 will add the Ethernet node as well. Best regards, Krzysztof
Hi Krzysztof > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Tuesday, April 29, 2025 6:37 PM > To: Yashwant Varur <yashwant.v@samsung.com>; robh@kernel.org; > krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: cs0617.lee@samsung.com; g.naidu@samsung.com; > niyas.ahmed@samsung.com > Subject: Re: [PATCH] arm64: dts: exynos: Added the ethernet pin configuration > > On 29/04/2025 11:29, Yashwant Varur wrote: > > > > Please follow DTS coding style carefully. This applies to all commits you try to > send from your downstream/vendor code. > > > hm? > Got the issue, coding style says Node and property names can use only the following characters: Lowercase characters: [a-z] Digits: [0-9] Dash: - I was using underscore for node name. > >> > > Sure, thanks > > > > What is more important, I don't really understand why you are doing > > this > > - there is no user of these entries - and commit msg does not help here. > >> > > Understood, in v2 will add the Ethernet node as well. > > I don't understand what is your reply here and what is quote. Use standard email > style, not some mySingle or Outlook output. I suggest reading typical guidelines > how to use email based workflows (kernel also has one). > Looks like mailer was not configured properly, hope this time it is fine. I am working on upstreaming Ethernet driver for exynosauto (which has a variant of STMMAC controller) What I wanted to reply previously was, will add pin control, along with Ethernet node(which will consume the pincontrol) and I realize that first dt-binding should go for this IP. My plan is to send Ethernet driver along with Ethernet dtsi node as well. > > Best regards, > Krzysztof
diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi index 663e8265cbf5..778584d339d5 100644 --- a/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi +++ b/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi @@ -166,6 +166,24 @@ gph6: gph6-gpio-bank { interrupt-controller; #interrupt-cells = <2>; }; + + eth0_pps_out: eth0_pps_out { + samsung,pins = "gph3-0"; + samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>; + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; + }; + + eth0_rgmii: eth0_rgmii { + samsung,pins = "gph3-1", "gph3-2", "gph3-3", "gph3-4", + "gph3-5", "gph3-6", "gph3-7", "gph4-0", + "gph4-1", "gph4-2", "gph4-3", "gph4-4"; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; + }; + + eth0_mdc_mdio: eth0_mdc_mdio { + samsung,pins = "gph4-5", "gph4-6"; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; + }; }; &pinctrl_hsi2ufs { @@ -750,6 +768,29 @@ i3c3_bus: i3c3-bus-pins { samsung,pin-function = <EXYNOS_PIN_FUNC_4>; samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; }; + + eth_extpll_avb: eth_extpll_avb { + samsung,pins = "gpg3-0"; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; + }; + + eth0_pps_out0: eth0_pps_out0 { + samsung,pins = "gpg0-0"; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; + }; + + eth0_pps_out1: eth0_pps_out1 { + samsung,pins = "gpg0-1"; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; + }; + + eth_phy_reset: eth_phy_reset { + samsung,pins = "gpg3-1"; + samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>; + }; + }; &pinctrl_peric1 {