| Message ID | 20250501062344.2526061-26-pierrick.bouvier@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | single-binary: compile target/arm twice | expand |
On 4/30/25 23:23, Pierrick Bouvier wrote: > Associated code is protected by cpu_isar_feature(aa64*) > > Signed-off-by: Pierrick Bouvier<pierrick.bouvier@linaro.org> > --- > target/arm/arch_dump.c | 6 ------ > 1 file changed, 6 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On 1/5/25 08:23, Pierrick Bouvier wrote: > Associated code is protected by cpu_isar_feature(aa64*) > > Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> > --- > target/arm/arch_dump.c | 6 ------ > 1 file changed, 6 deletions(-) Should we assert() in the callees? Anyway, Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On 5/1/25 12:30 PM, Philippe Mathieu-Daudé wrote: > On 1/5/25 08:23, Pierrick Bouvier wrote: >> Associated code is protected by cpu_isar_feature(aa64*) >> >> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> >> --- >> target/arm/arch_dump.c | 6 ------ >> 1 file changed, 6 deletions(-) > > Should we assert() in the callees? Anyway, > I don't think so, as call sites are guarded by cpu_isar_feature(aa64_*). I understand your repeated question on this topic, and I think a good guideline could be to assert only when there are several call sites, or call sites external to compilation units. For a static function called in a single place, the risk to introduce a regression is quite low. > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> >
diff --git a/target/arm/arch_dump.c b/target/arm/arch_dump.c index c40df4e7fd7..1dd79849c13 100644 --- a/target/arm/arch_dump.c +++ b/target/arm/arch_dump.c @@ -143,7 +143,6 @@ static int aarch64_write_elf64_prfpreg(WriteCoreDumpFunction f, return 0; } -#ifdef TARGET_AARCH64 static off_t sve_zreg_offset(uint32_t vq, int n) { off_t off = sizeof(struct aarch64_user_sve_header); @@ -231,7 +230,6 @@ static int aarch64_write_elf64_sve(WriteCoreDumpFunction f, return 0; } -#endif int arm_cpu_write_elf64_note(WriteCoreDumpFunction f, CPUState *cs, int cpuid, DumpState *s) @@ -273,11 +271,9 @@ int arm_cpu_write_elf64_note(WriteCoreDumpFunction f, CPUState *cs, return ret; } -#ifdef TARGET_AARCH64 if (cpu_isar_feature(aa64_sve, cpu)) { ret = aarch64_write_elf64_sve(f, env, cpuid, s); } -#endif return ret; } @@ -451,11 +447,9 @@ ssize_t cpu_get_note_size(int class, int machine, int nr_cpus) if (class == ELFCLASS64) { note_size = AARCH64_PRSTATUS_NOTE_SIZE; note_size += AARCH64_PRFPREG_NOTE_SIZE; -#ifdef TARGET_AARCH64 if (cpu_isar_feature(aa64_sve, cpu)) { note_size += AARCH64_SVE_NOTE_SIZE(&cpu->env); } -#endif } else { note_size = ARM_PRSTATUS_NOTE_SIZE; if (cpu_isar_feature(aa32_vfp_simd, cpu)) {
Associated code is protected by cpu_isar_feature(aa64*) Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> --- target/arm/arch_dump.c | 6 ------ 1 file changed, 6 deletions(-)