| Message ID | 20250502042240.17371-1-haiyuewa@163.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [net,v1] selftests: iou-zcrx: Clean up build warnings for error format | expand |
On Fri, May 02, 2025 at 12:22:20PM +0800, Haiyue Wang wrote: > Clean up two build warnings: > > [1]: > iou-zcrx.c: In function ‘process_recvzc’: > iou-zcrx.c:263:37: warning: too many arguments for > format [-Wformat-extra-args] > 263 | error(1, 0, "payload mismatch at ", i); > | ^~~~~~~~~~~~~~~~~~~~~~ > > [2]: > iou-zcrx.c: In function ‘run_client’: > iou-zcrx.c:357:47: warning: format ‘%d’ expects argument of > type ‘int’, but argument 4 has > type ‘ssize_t’ {aka ‘long int’} [-Wformat=] > 357 | error(1, 0, "send(): %d", sent); > | ~^ ~~~~ > | | | > | int ssize_t {aka long int} > | %ld > > Signed-off-by: Haiyue Wang <haiyuewa@163.com> Hi Haiyue Wang, This feels more like a clean-up for net-next than a bug-fix to net. > --- > tools/testing/selftests/drivers/net/hw/iou-zcrx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/drivers/net/hw/iou-zcrx.c b/tools/testing/selftests/drivers/net/hw/iou-zcrx.c > index c26b4180eddd..19e1ff45deb4 100644 > --- a/tools/testing/selftests/drivers/net/hw/iou-zcrx.c > +++ b/tools/testing/selftests/drivers/net/hw/iou-zcrx.c > @@ -260,7 +260,7 @@ static void process_recvzc(struct io_uring *ring, struct io_uring_cqe *cqe) > > for (i = 0; i < n; i++) { > if (*(data + i) != payload[(received + i)]) > - error(1, 0, "payload mismatch at ", i); > + error(1, 0, "payload mismatch at %d", i); > } > received += n; > > @@ -354,7 +354,7 @@ static void run_client(void) > chunk = min_t(ssize_t, cfg_payload_len, to_send); > res = send(fd, src, chunk, 0); > if (res < 0) > - error(1, 0, "send(): %d", sent); > + error(1, 0, "send(): %ld", sent); As the type of sent is ssize_t I think that "%zd" would be best here. > sent += res; > to_send -= res; > } > -- > 2.49.0 > >
diff --git a/tools/testing/selftests/drivers/net/hw/iou-zcrx.c b/tools/testing/selftests/drivers/net/hw/iou-zcrx.c index c26b4180eddd..19e1ff45deb4 100644 --- a/tools/testing/selftests/drivers/net/hw/iou-zcrx.c +++ b/tools/testing/selftests/drivers/net/hw/iou-zcrx.c @@ -260,7 +260,7 @@ static void process_recvzc(struct io_uring *ring, struct io_uring_cqe *cqe) for (i = 0; i < n; i++) { if (*(data + i) != payload[(received + i)]) - error(1, 0, "payload mismatch at ", i); + error(1, 0, "payload mismatch at %d", i); } received += n; @@ -354,7 +354,7 @@ static void run_client(void) chunk = min_t(ssize_t, cfg_payload_len, to_send); res = send(fd, src, chunk, 0); if (res < 0) - error(1, 0, "send(): %d", sent); + error(1, 0, "send(): %ld", sent); sent += res; to_send -= res; }
Clean up two build warnings: [1]: iou-zcrx.c: In function ‘process_recvzc’: iou-zcrx.c:263:37: warning: too many arguments for format [-Wformat-extra-args] 263 | error(1, 0, "payload mismatch at ", i); | ^~~~~~~~~~~~~~~~~~~~~~ [2]: iou-zcrx.c: In function ‘run_client’: iou-zcrx.c:357:47: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘ssize_t’ {aka ‘long int’} [-Wformat=] 357 | error(1, 0, "send(): %d", sent); | ~^ ~~~~ | | | | int ssize_t {aka long int} | %ld Signed-off-by: Haiyue Wang <haiyuewa@163.com> --- tools/testing/selftests/drivers/net/hw/iou-zcrx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)