| Message ID | 20250502-selftests-timens-fixes-v1-0-fb517c76f04d@linutronix.de |
|---|---|
| Headers | show |
| Series | selftests/timens: Various small fixes | expand |
On 5/2/25 5:03 PM, Thomas Weißschuh wrote: > These functions are never used outside their defining compilation unit and > can be made static. > > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > --- > tools/testing/selftests/timens/clock_nanosleep.c | 2 +- > tools/testing/selftests/timens/timer.c | 2 +- > tools/testing/selftests/timens/timerfd.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/timens/clock_nanosleep.c b/tools/testing/selftests/timens/clock_nanosleep.c > index 346bff3d128dfa8c8c743cc2eba74917994bb2f7..5cc0010e85ff00e00c89940a82268994a1769873 100644 > --- a/tools/testing/selftests/timens/clock_nanosleep.c > +++ b/tools/testing/selftests/timens/clock_nanosleep.c > @@ -38,7 +38,7 @@ void *call_nanosleep(void *_args) > return NULL; > } > > -int run_test(int clockid, int abs) > +static int run_test(int clockid, int abs) > { > struct timespec now = {}, rem; > struct thread_args args = { .now = &now, .rem = &rem, .clockid = clockid}; > diff --git a/tools/testing/selftests/timens/timer.c b/tools/testing/selftests/timens/timer.c > index 51babe63e233bdaaef35c1cafbcb5b5cc91c021e..79543ceb2c0f97fdd638271a762c97a8b19d9a4a 100644 > --- a/tools/testing/selftests/timens/timer.c > +++ b/tools/testing/selftests/timens/timer.c > @@ -15,7 +15,7 @@ > #include "log.h" > #include "timens.h" > > -int run_test(int clockid, struct timespec now) > +static int run_test(int clockid, struct timespec now) > { > struct itimerspec new_value; > long long elapsed; > diff --git a/tools/testing/selftests/timens/timerfd.c b/tools/testing/selftests/timens/timerfd.c > index e58bc8b64ce2738dccb8c2a2c88e592c237b55d5..d6adf66bd8df064f5b76ccc265c13217d7a53f5b 100644 > --- a/tools/testing/selftests/timens/timerfd.c > +++ b/tools/testing/selftests/timens/timerfd.c > @@ -22,7 +22,7 @@ static int tclock_gettime(clock_t clockid, struct timespec *now) > return clock_gettime(clockid, now); > } > > -int run_test(int clockid, struct timespec now) > +static int run_test(int clockid, struct timespec now) > { > struct itimerspec new_value; > long long elapsed; >
Fixes for various issues in the timens selftests. Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> --- Thomas Weißschuh (3): selftests/timens: Print TAP headers selftests/timens: Make run_tests() functions static selftests/timens: timerfd: Use correct clockid type in tclock_gettime() tools/testing/selftests/timens/clock_nanosleep.c | 4 +++- tools/testing/selftests/timens/exec.c | 2 ++ tools/testing/selftests/timens/futex.c | 2 ++ tools/testing/selftests/timens/gettime_perf.c | 2 ++ tools/testing/selftests/timens/procfs.c | 2 ++ tools/testing/selftests/timens/timens.c | 2 ++ tools/testing/selftests/timens/timer.c | 4 +++- tools/testing/selftests/timens/timerfd.c | 6 ++++-- tools/testing/selftests/timens/vfork_exec.c | 2 ++ 9 files changed, 22 insertions(+), 4 deletions(-) --- base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8 change-id: 20250326-selftests-timens-fixes-97662bdb18b6 Best regards,