| Message ID | 20250505015223.3895275-45-pierrick.bouvier@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | single-binary: compile target/arm twice | expand |
On 5/4/25 18:52, Pierrick Bouvier wrote: > Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> > --- > target/arm/tcg/neon_helper.c | 4 +++- > target/arm/tcg/meson.build | 3 ++- > 2 files changed, 5 insertions(+), 2 deletions(-) Likewise, I think this could be built once. r~ > > diff --git a/target/arm/tcg/neon_helper.c b/target/arm/tcg/neon_helper.c > index e2cc7cf4ee6..2cc8241f1e4 100644 > --- a/target/arm/tcg/neon_helper.c > +++ b/target/arm/tcg/neon_helper.c > @@ -9,11 +9,13 @@ > > #include "qemu/osdep.h" > #include "cpu.h" > -#include "exec/helper-proto.h" > #include "tcg/tcg-gvec-desc.h" > #include "fpu/softfloat.h" > #include "vec_internal.h" > > +#define HELPER_H "tcg/helper.h" > +#include "exec/helper-proto.h.inc" > + > #define SIGNBIT (uint32_t)0x80000000 > #define SIGNBIT64 ((uint64_t)1 << 63) > > diff --git a/target/arm/tcg/meson.build b/target/arm/tcg/meson.build > index 3482921ccf0..ec087076b8c 100644 > --- a/target/arm/tcg/meson.build > +++ b/target/arm/tcg/meson.build > @@ -32,7 +32,6 @@ arm_ss.add(files( > 'translate-vfp.c', > 'm_helper.c', > 'mve_helper.c', > - 'neon_helper.c', > 'op_helper.c', > 'tlb_helper.c', > 'vec_helper.c', > @@ -65,9 +64,11 @@ arm_common_system_ss.add(files( > 'crypto_helper.c', > 'hflags.c', > 'iwmmxt_helper.c', > + 'neon_helper.c', > )) > arm_user_ss.add(files( > 'crypto_helper.c', > 'hflags.c', > 'iwmmxt_helper.c', > + 'neon_helper.c', > ))
On 5/5/25 11:44, Richard Henderson wrote: > On 5/4/25 18:52, Pierrick Bouvier wrote: >> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> >> --- >> target/arm/tcg/neon_helper.c | 4 +++- >> target/arm/tcg/meson.build | 3 ++- >> 2 files changed, 5 insertions(+), 2 deletions(-) > > Likewise, I think this could be built once. Likewise re crypto, Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On 5/5/25 11:44 AM, Richard Henderson wrote: > On 5/4/25 18:52, Pierrick Bouvier wrote: >> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> >> --- >> target/arm/tcg/neon_helper.c | 4 +++- >> target/arm/tcg/meson.build | 3 ++- >> 2 files changed, 5 insertions(+), 2 deletions(-) > > Likewise, I think this could be built once. > needs access to env->vfp.qc[0], so pulls cpu.h. > > r~ > >> >> diff --git a/target/arm/tcg/neon_helper.c b/target/arm/tcg/neon_helper.c >> index e2cc7cf4ee6..2cc8241f1e4 100644 >> --- a/target/arm/tcg/neon_helper.c >> +++ b/target/arm/tcg/neon_helper.c >> @@ -9,11 +9,13 @@ >> >> #include "qemu/osdep.h" >> #include "cpu.h" >> -#include "exec/helper-proto.h" >> #include "tcg/tcg-gvec-desc.h" >> #include "fpu/softfloat.h" >> #include "vec_internal.h" >> >> +#define HELPER_H "tcg/helper.h" >> +#include "exec/helper-proto.h.inc" >> + >> #define SIGNBIT (uint32_t)0x80000000 >> #define SIGNBIT64 ((uint64_t)1 << 63) >> >> diff --git a/target/arm/tcg/meson.build b/target/arm/tcg/meson.build >> index 3482921ccf0..ec087076b8c 100644 >> --- a/target/arm/tcg/meson.build >> +++ b/target/arm/tcg/meson.build >> @@ -32,7 +32,6 @@ arm_ss.add(files( >> 'translate-vfp.c', >> 'm_helper.c', >> 'mve_helper.c', >> - 'neon_helper.c', >> 'op_helper.c', >> 'tlb_helper.c', >> 'vec_helper.c', >> @@ -65,9 +64,11 @@ arm_common_system_ss.add(files( >> 'crypto_helper.c', >> 'hflags.c', >> 'iwmmxt_helper.c', >> + 'neon_helper.c', >> )) >> arm_user_ss.add(files( >> 'crypto_helper.c', >> 'hflags.c', >> 'iwmmxt_helper.c', >> + 'neon_helper.c', >> )) >
diff --git a/target/arm/tcg/neon_helper.c b/target/arm/tcg/neon_helper.c index e2cc7cf4ee6..2cc8241f1e4 100644 --- a/target/arm/tcg/neon_helper.c +++ b/target/arm/tcg/neon_helper.c @@ -9,11 +9,13 @@ #include "qemu/osdep.h" #include "cpu.h" -#include "exec/helper-proto.h" #include "tcg/tcg-gvec-desc.h" #include "fpu/softfloat.h" #include "vec_internal.h" +#define HELPER_H "tcg/helper.h" +#include "exec/helper-proto.h.inc" + #define SIGNBIT (uint32_t)0x80000000 #define SIGNBIT64 ((uint64_t)1 << 63) diff --git a/target/arm/tcg/meson.build b/target/arm/tcg/meson.build index 3482921ccf0..ec087076b8c 100644 --- a/target/arm/tcg/meson.build +++ b/target/arm/tcg/meson.build @@ -32,7 +32,6 @@ arm_ss.add(files( 'translate-vfp.c', 'm_helper.c', 'mve_helper.c', - 'neon_helper.c', 'op_helper.c', 'tlb_helper.c', 'vec_helper.c', @@ -65,9 +64,11 @@ arm_common_system_ss.add(files( 'crypto_helper.c', 'hflags.c', 'iwmmxt_helper.c', + 'neon_helper.c', )) arm_user_ss.add(files( 'crypto_helper.c', 'hflags.c', 'iwmmxt_helper.c', + 'neon_helper.c', ))
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> --- target/arm/tcg/neon_helper.c | 4 +++- target/arm/tcg/meson.build | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-)