| Message ID | 20250512-pinctrl-a37xx-fixes-v1-0-d470fb1116a5@gmail.com |
|---|---|
| Headers | show |
| Series | pinctrl: armada-37xx: a couple of small fixes | expand |
On Mon, May 12, 2025 at 04:22:42PM +0200, Gabor Juhos wrote: > The regmap_read() function can fail, so propagate its error up to > the stack instead of silently ignoring that. > > Cc: stable@vger.kernel.org > Fixes: 5715092a458c ("pinctrl: armada-37xx: Add gpio support") > Signed-off-by: Gabor Juhos <j4g8y7@gmail.com> > Signed-off-by: Imre Kaloz <kaloz@openwrt.org> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Mon, May 12, 2025 at 04:22:36PM +0200, Gabor Juhos wrote: > The series contains several small patches to fix various > issues in the pinctrl driver for Armada 3700. I'm not sure all these should be for stable. Some are clear bugs, but not propagating the errors has not bothered anybody so far, a requirement for stable. Andrew
On Mon, May 12, 2025 at 11:33 PM Andrew Lunn <andrew@lunn.ch> wrote: > On Mon, May 12, 2025 at 04:22:36PM +0200, Gabor Juhos wrote: > > The series contains several small patches to fix various > > issues in the pinctrl driver for Armada 3700. > > I'm not sure all these should be for stable. Some are clear bugs, but > not propagating the errors has not bothered anybody so far, a > requirement for stable. So we are at -rc6 so I'm not sending these as fixes to Torvalds right now unless they are super-critical. I will merge this for v6.16 (-rc1) and then the stable maintainers will have to decide from the point it enters mainline. Gabor: can you look over the tags? Once you have decided on stable/non-stable tags I will merge the series. Yours, Linus Walleij
On Tue, May 13, 2025 at 06:51:35PM +0200, Gabor Juhos wrote: > 2025. 05. 13. 15:36 keltezéssel, Linus Walleij írta: > > On Mon, May 12, 2025 at 11:33 PM Andrew Lunn <andrew@lunn.ch> wrote: > >> On Mon, May 12, 2025 at 04:22:36PM +0200, Gabor Juhos wrote: > >>> The series contains several small patches to fix various > >>> issues in the pinctrl driver for Armada 3700. > >> > >> I'm not sure all these should be for stable. Some are clear bugs, but > >> not propagating the errors has not bothered anybody so far, a > >> requirement for stable. > > > > So we are at -rc6 so I'm not sending these as fixes to Torvalds > > right now unless they are super-critical. > > > > I will merge this for v6.16 (-rc1) and then the stable maintainers > > will have to decide from the point it enters mainline. > > > > Gabor: can you look over the tags? Once you have decided > > on stable/non-stable tags I will merge the series. > > Sure, I will send a v2. Just a question, shall I also remove the 'Fixes' tags > along with the 'stable' ones? If I keep those, they might land up in stable > trees anyway. For the return values patches, i would drop the Fixes. It is just really continuing development work for the driver. Andrew
2025. 05. 13. 20:46 keltezéssel, Andrew Lunn írta: > On Tue, May 13, 2025 at 06:51:35PM +0200, Gabor Juhos wrote: >> 2025. 05. 13. 15:36 keltezéssel, Linus Walleij írta: >>> On Mon, May 12, 2025 at 11:33 PM Andrew Lunn <andrew@lunn.ch> wrote: >>>> On Mon, May 12, 2025 at 04:22:36PM +0200, Gabor Juhos wrote: >>>>> The series contains several small patches to fix various >>>>> issues in the pinctrl driver for Armada 3700. >>>> >>>> I'm not sure all these should be for stable. Some are clear bugs, but >>>> not propagating the errors has not bothered anybody so far, a >>>> requirement for stable. >>> >>> So we are at -rc6 so I'm not sending these as fixes to Torvalds >>> right now unless they are super-critical. >>> >>> I will merge this for v6.16 (-rc1) and then the stable maintainers >>> will have to decide from the point it enters mainline. >>> >>> Gabor: can you look over the tags? Once you have decided >>> on stable/non-stable tags I will merge the series. >> >> Sure, I will send a v2. Just a question, shall I also remove the 'Fixes' tags >> along with the 'stable' ones? If I keep those, they might land up in stable >> trees anyway. > > For the return values patches, i would drop the Fixes. It is just > really continuing development work for the driver. Ok, thanks! -Gabor
The series contains several small patches to fix various issues in the pinctrl driver for Armada 3700. Signed-off-by: Gabor Juhos <j4g8y7@gmail.com> --- Gabor Juhos (7): pinctrl: armada-37xx: use correct OUTPUT_VAL register for GPIOs > 31 pinctrl: armada-37xx: propagate error from armada_37xx_gpio_direction_output() pinctrl: armada-37xx: set GPIO output value before setting direction pinctrl: armada-37xx: propagate error from armada_37xx_gpio_get() pinctrl: armada-37xx: propagate error from armada_37xx_pmx_gpio_set_direction() pinctrl: armada-37xx: propagate error from armada_37xx_gpio_get_direction() pinctrl: armada-37xx: propagate error from armada_37xx_pmx_set_by_name() drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 35 ++++++++++++++++------------- 1 file changed, 20 insertions(+), 15 deletions(-) --- base-commit: 82f2b0b97b36ee3fcddf0f0780a9a0825d52fec3 change-id: 20250512-pinctrl-a37xx-fixes-98fabc45cb11 Best regards,