| Message ID | 20250523134207.68481-3-yassine.ouaissa@allegrodvt.com |
|---|---|
| State | New |
| Headers | show |
| Series | media: Add Gen 3 IP stateful decoder driver | expand |
On Fri, 23 May 2025 15:41:47 +0200, Yassine Ouaissa wrote: > Add compatible for video decoder on allegrodvt Gen 3 IP. > > Signed-off-by: Yassine Ouaissa <yassine.ouaissa@allegrodvt.com> > --- > .../bindings/media/allegro,al300-vdec.yaml | 75 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 76 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/allegro,al300-vdec.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/allegro,al300-vdec.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename $id: http://devicetree.org/schemas/media/allegrodvt,al300-vdec.yaml file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/allegro,al300-vdec.yaml doc reference errors (make refcheckdocs): Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/media/allegrodvt,al300-vdec.yaml MAINTAINERS: Documentation/devicetree/bindings/media/allegrodvt,al300-vdec.yaml See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250523134207.68481-3-yassine.ouaissa@allegrodvt.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Hi Yassine,
kernel test robot noticed the following build warnings:
[auto build test WARNING on robh/for-next]
[also build test WARNING on linuxtv-media-pending/master linus/master v6.15-rc7 next-20250523]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Yassine-Ouaissa/media-allegro-dvt-Move-the-current-driver-to-a-subdirectory/20250523-214946
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20250523134207.68481-3-yassine.ouaissa%40allegrodvt.com
patch subject: [PATCH 2/5] dt-bindings: media: allegro-dvt: add decoder dt-bindings for Gen3 IP
reproduce: (https://download.01.org/0day-ci/archive/20250523/202505232350.HEuJSo1z-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505232350.HEuJSo1z-lkp@intel.com/
All warnings (new ones prefixed by >>):
Warning: Documentation/translations/ja_JP/process/submit-checklist.rst references a file that doesn't exist: Documentation/translations/ja_JP/SubmitChecklist
Warning: Documentation/translations/zh_CN/admin-guide/README.rst references a file that doesn't exist: Documentation/dev-tools/kgdb.rst
Warning: Documentation/translations/zh_CN/dev-tools/gdb-kernel-debugging.rst references a file that doesn't exist: Documentation/dev-tools/gdb-kernel-debugging.rst
Warning: Documentation/translations/zh_TW/admin-guide/README.rst references a file that doesn't exist: Documentation/dev-tools/kgdb.rst
Warning: Documentation/translations/zh_TW/dev-tools/gdb-kernel-debugging.rst references a file that doesn't exist: Documentation/dev-tools/gdb-kernel-debugging.rst
>> Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/media/allegrodvt,al300-vdec.yaml
Can't build as 1 mandatory dependency is missing at ./scripts/sphinx-pre-install line 984.
make[2]: *** [Documentation/Makefile:121: htmldocs] Error 255
make[1]: *** [Makefile:1801: htmldocs] Error 2
make: *** [Makefile:248: __sub-make] Error 2
make: Target 'htmldocs' not remade because of errors.
On 23/05/2025 19:11, Krzysztof Kozlowski wrote: > On 23/05/2025 15:41, Yassine Ouaissa wrote: >> Add compatible for video decoder on allegrodvt Gen 3 IP. >> >> Signed-off-by: Yassine Ouaissa <yassine.ouaissa@allegrodvt.com> > Please do not send the same patches over and over again. You got review > which you need to address. > > Once address you send NEXT version with proper CHANGELOG for each patch > or top of cover letter. See submitting patches... or just use b4. This > should be actually requirement for this work. > > Anyway, I see all of previous review ignored so let's be explicit: > > NAK > Now I noticed you actually sent the same second time ignoring review and I asked to stop and implement review, so this is the third time. This is very disappointing. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/media/allegro,al300-vdec.yaml b/Documentation/devicetree/bindings/media/allegro,al300-vdec.yaml new file mode 100644 index 000000000000..e853e7634c4f --- /dev/null +++ b/Documentation/devicetree/bindings/media/allegro,al300-vdec.yaml @@ -0,0 +1,75 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/allegrodvt,al300-vdec.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Allegro DVT Video IP Decoder Gen 3 + +maintainers: + - Yassine OUAISSA <yassine.ouaissa@allegrodvt.com> + +description: + The al300-vdec represents the latest generation of Allegro DVT IP decoding + technology, offering significant advancements over its predecessors. + This new decoder features enhanced processing capabilities with improved + throughput and reduced latency. + + Communication between the host driver software and the MCU is implemented + through a specialized mailbox interface mechanism. This mailbox system + provides a structured channel for exchanging commands, parameters, and + status information between the host CPU and the MCU controlling the codec + engines. + +properties: + compatible: + const: allegro,al300-vdec + + reg: + maxItems: 2 + minItems: 2 + + reg-names: + items: + - const: regs + - const: apb + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + + memory-region: + maxItems: 1 + + firmware-name: + maxItems: 1 + +required: + - compatible + - reg + - reg-names + - interrupts + - clocks + +additionalProperties: False + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + + axi { + #address-cells = <2>; + #size-cells = <2>; + + video-decoder@a0120000 { + compatible = "allegro,al300-vdec"; + reg = <0x00 0xa0120000 0x00 0x10000>, + <0x01 0x80000000 0x00 0x8000>; + reg-names = "regs", "apb"; + interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mcu_core_clk>; + firmware-name = "al300_vdec.fw"; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index d81d2756cb2e..e59011a36e6b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -806,6 +806,7 @@ R: Pengutronix Kernel Team <kernel@pengutronix.de> L: linux-media@vger.kernel.org S: Maintained F: Documentation/devicetree/bindings/media/allegro,al5e.yaml +F: Documentation/devicetree/bindings/media/allegrodvt,al300-vdec.yaml F: drivers/media/platform/allegro-dvt/zynqmp ALLIED VISION ALVIUM CAMERA DRIVER
Add compatible for video decoder on allegrodvt Gen 3 IP. Signed-off-by: Yassine Ouaissa <yassine.ouaissa@allegrodvt.com> --- .../bindings/media/allegro,al300-vdec.yaml | 75 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 76 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/allegro,al300-vdec.yaml